Re: [PATCH v5 07/10] arm64: dts: mt6358: change node names

From: Matthias Brugger <matthias.bgg@gmail.com>
To: Alexandre Mergnat <amergnat@baylibre.com>,
	Flora Fu <flora.fu@mediatek.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Tianping Fang <tianping.fang@mediatek.com>,
	Fabien Parent <fabien.parent@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Mark Brown <broonie@kernel.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Chen Zhong <chen.zhong@mediatek.com>, Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-leds@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	linux-rtc@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v5 07/10] arm64: dts: mt6358: change node names
Date: Thu, 17 Nov 2022 17:02:51 +0100	[thread overview]
Message-ID: <3ab0a069-355c-b3a7-450b-22e58d5f1ea8@gmail.com> (raw)
In-Reply-To: <20221005-mt6357-support-v5-7-8210d955dd3d@baylibre.com>

On 16/11/2022 13:33, Alexandre Mergnat wrote:
> - Change the node name from "mt6358" to "pmic" to be consistent
> with mediatek,pwrap.yaml documentation.
> 
> - Change the node name from "mt6358rtc" to "rtc" to be consistent
> with mediatek,mt6397-rtc.yaml documentation.
> 
> - Change the node name from "mt6358keys" to "keys" to be consistent
> with mediatek,pmic-keys.yaml documentation.
> 

I think the node names should be changed anyway. So I'd advise to update the 
commit message and I can take some right away.

Regards,
Matthias

> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 98f3b0e0c9f6..b605313bed99 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -5,7 +5,7 @@
>   #include <dt-bindings/input/input.h>
>   
>   &pwrap {
> -	pmic: mt6358 {
> +	pmic: pmic {
>   		compatible = "mediatek,mt6358";
>   		interrupt-controller;
>   		interrupt-parent = <&pio>;
> @@ -355,11 +355,11 @@ mt6358_vsim2_reg: ldo_vsim2 {
>   			};
>   		};
>   
> -		mt6358rtc: mt6358rtc {
> +		mt6358rtc: rtc {
>   			compatible = "mediatek,mt6358-rtc";
>   		};
>   
> -		mt6358keys: mt6358keys {
> +		mt6358keys: keys {
>   			compatible = "mediatek,mt6358-keys";
>   			power {
>   				linux,keycodes = <KEY_POWER>;
> 