* [Buildroot] [PATCH 0/2] support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry)
@ 2021-11-23 20:56 Yann E. MORIN
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
2021-11-23 20:56 ` [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry Yann E. MORIN
0 siblings, 2 replies; 8+ messages in thread
From: Yann E. MORIN @ 2021-11-23 20:56 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Yann E . MORIN
Hello All!
This two-patch series changes our Dockerfile to directly use the Gitlab
registry, and drop references to the Docker hub, as we no longer use it.
Regards,
Yann E. MORIN.
----------------------------------------------------------------
Yann E. MORIN (2):
support/docker: don't use sudo to build
support/docker: drop use of Docker hub, use Gitlab registry
support/docker/Dockerfile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build
2021-11-23 20:56 [Buildroot] [PATCH 0/2] support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry) Yann E. MORIN
@ 2021-11-23 20:56 ` Yann E. MORIN
2021-11-23 21:40 ` Romain Naour
` (2 more replies)
2021-11-23 20:56 ` [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry Yann E. MORIN
1 sibling, 3 replies; 8+ messages in thread
From: Yann E. MORIN @ 2021-11-23 20:56 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Yann E. MORIN
On a properly setup machine, it is totally useless to use sudo to run
docker; it is very bad practice. Instead, users really should add
themselves to the docker group.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
support/docker/Dockerfile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
index 2aee129668..57445d5cd1 100644
--- a/support/docker/Dockerfile
+++ b/support/docker/Dockerfile
@@ -1,7 +1,7 @@
# This Dockerfile generates the docker image that gets used by Gitlab CI
# To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-# sudo docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-# sudo docker push buildroot/base:YYYYMMDD.HHMM
+# docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
+# docker push buildroot/base:YYYYMMDD.HHMM
# We use a specific tag for the base image *and* the corresponding date
# for the repository., so do not forget to update the apt-sources.list
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry
2021-11-23 20:56 [Buildroot] [PATCH 0/2] support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry) Yann E. MORIN
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
@ 2021-11-23 20:56 ` Yann E. MORIN
2021-11-23 21:42 ` Romain Naour
2021-11-28 13:40 ` Peter Korsgaard
1 sibling, 2 replies; 8+ messages in thread
From: Yann E. MORIN @ 2021-11-23 20:56 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Yann E. MORIN
Now that our pipelines are using the Docker image from the Gitlab
registry, there is no longer any reason to push the image to the
Docker hub.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
support/docker/Dockerfile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
index 57445d5cd1..ad8704873c 100644
--- a/support/docker/Dockerfile
+++ b/support/docker/Dockerfile
@@ -1,7 +1,7 @@
# This Dockerfile generates the docker image that gets used by Gitlab CI
# To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-# docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-# docker push buildroot/base:YYYYMMDD.HHMM
+# docker build -t registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM support/docker
+# docker push registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM
# We use a specific tag for the base image *and* the corresponding date
# for the repository., so do not forget to update the apt-sources.list
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
@ 2021-11-23 21:40 ` Romain Naour
2021-11-28 13:39 ` Peter Korsgaard
2021-12-11 22:42 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Romain Naour @ 2021-11-23 21:40 UTC (permalink / raw)
To: Yann E. MORIN, buildroot
Hello Yann,
Le 23/11/2021 à 21:56, Yann E. MORIN a écrit :
> On a properly setup machine, it is totally useless to use sudo to run
> docker; it is very bad practice. Instead, users really should add
> themselves to the docker group.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> support/docker/Dockerfile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
> index 2aee129668..57445d5cd1 100644
> --- a/support/docker/Dockerfile
> +++ b/support/docker/Dockerfile
> @@ -1,7 +1,7 @@
> # This Dockerfile generates the docker image that gets used by Gitlab CI
> # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
> -# sudo docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
> -# sudo docker push buildroot/base:YYYYMMDD.HHMM
> +# docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
> +# docker push buildroot/base:YYYYMMDD.HHMM
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
>
> # We use a specific tag for the base image *and* the corresponding date
> # for the repository., so do not forget to update the apt-sources.list
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry
2021-11-23 20:56 ` [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry Yann E. MORIN
@ 2021-11-23 21:42 ` Romain Naour
2021-11-28 13:40 ` Peter Korsgaard
1 sibling, 0 replies; 8+ messages in thread
From: Romain Naour @ 2021-11-23 21:42 UTC (permalink / raw)
To: Yann E. MORIN, buildroot
Hello Yann,
Le 23/11/2021 à 21:56, Yann E. MORIN a écrit :
> Now that our pipelines are using the Docker image from the Gitlab
> registry, there is no longer any reason to push the image to the
> Docker hub.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> support/docker/Dockerfile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
> index 57445d5cd1..ad8704873c 100644
> --- a/support/docker/Dockerfile
> +++ b/support/docker/Dockerfile
> @@ -1,7 +1,7 @@
> # This Dockerfile generates the docker image that gets used by Gitlab CI
> # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
> -# docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
> -# docker push buildroot/base:YYYYMMDD.HHMM
> +# docker build -t registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM support/docker
> +# docker push registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
>
> # We use a specific tag for the base image *and* the corresponding date
> # for the repository., so do not forget to update the apt-sources.list
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
2021-11-23 21:40 ` Romain Naour
@ 2021-11-28 13:39 ` Peter Korsgaard
2021-12-11 22:42 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-28 13:39 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Romain Naour, buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> On a properly setup machine, it is totally useless to use sudo to run
> docker; it is very bad practice. Instead, users really should add
> themselves to the docker group.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry
2021-11-23 20:56 ` [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry Yann E. MORIN
2021-11-23 21:42 ` Romain Naour
@ 2021-11-28 13:40 ` Peter Korsgaard
1 sibling, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-28 13:40 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Romain Naour, buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Now that our pipelines are using the Docker image from the Gitlab
> registry, there is no longer any reason to push the image to the
> Docker hub.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
2021-11-23 21:40 ` Romain Naour
2021-11-28 13:39 ` Peter Korsgaard
@ 2021-12-11 22:42 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-12-11 22:42 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Romain Naour, buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> On a properly setup machine, it is totally useless to use sudo to run
> docker; it is very bad practice. Instead, users really should add
> themselves to the docker group.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-11 22:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 20:56 [Buildroot] [PATCH 0/2] support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry) Yann E. MORIN
2021-11-23 20:56 ` [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build Yann E. MORIN
2021-11-23 21:40 ` Romain Naour
2021-11-28 13:39 ` Peter Korsgaard
2021-12-11 22:42 ` Peter Korsgaard
2021-11-23 20:56 ` [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry Yann E. MORIN
2021-11-23 21:42 ` Romain Naour
2021-11-28 13:40 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.