All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	hverkuil@xs4all.nl, p.zabel@pengutronix.de, mchehab@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	gregkh@linuxfoundation.org, mripard@kernel.org,
	paul.kocialkowski@bootlin.com, wens@csie.org,
	jernej.skrabec@siol.net, emil.l.velikov@gmail.com,
	andrzej.p@collabora.com, jc@kynesim.co.uk,
	jernej.skrabec@gmail.com, nicolas@ndufresne.ca
Cc: kernel@pengutronix.de, linux-imx@nxp.com,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] Additional features for Hantro HEVC
Date: Tue, 22 Jun 2021 09:54:35 -0300	[thread overview]
Message-ID: <3ab5878bc03eb91a785c0fa57836e8d226df524d.camel@collabora.com> (raw)
In-Reply-To: <20210618131526.566762-1-benjamin.gaignard@collabora.com>

Hi Benjamin,

On Fri, 2021-06-18 at 15:15 +0200, Benjamin Gaignard wrote:
> version 3:
>  - Change trace file name to hantro_trace.h
> 
> version 2:
>  - Fix structure name in ext-ctrls-codec.rst
>  - Define the value for compression storage size
>  - Add comments about registers usage
>  - Add documentation about P010 padding
> 
> Basic HEVC support has been added to Hantro driver in this pull request:
> https://www.spinics.net/lists/linux-media/msg193744.html
> 
> Thanks to that it is now possible to support more features for this driver.
> 
> The first patch allow to log the hardware performance per macroblock.
> The second patch makes the driver use compressed reference frames to
> reduce memory bandwidth consumption.
> Patches 3 to 5 allow to decode and produce 10-bits P010 frames.
> Patch 6 make usage of G2 post processor to scale down the frames.
> Patches 7 and 8 add the support of HEVC scaling matrix by adding a new
> control.
> 

For the next cover letter, please make sure you provide
some notes about how this was tested, with a gstreamer
public branch if needed; and also fluendo's fluster conformance
results before/after this patchset.

While there, make sure you check for performance regressions/improvements
and add such information to the commit descriptions. The more the merrier.

Thanks a lot,
Ezequiel


WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	hverkuil@xs4all.nl, p.zabel@pengutronix.de, mchehab@kernel.org,
	shawnguo@kernel.org,  s.hauer@pengutronix.de, festevam@gmail.com,
	gregkh@linuxfoundation.org,  mripard@kernel.org,
	paul.kocialkowski@bootlin.com, wens@csie.org,
	 jernej.skrabec@siol.net, emil.l.velikov@gmail.com,
	andrzej.p@collabora.com, jc@kynesim.co.uk,
	jernej.skrabec@gmail.com, nicolas@ndufresne.ca
Cc: kernel@pengutronix.de, linux-imx@nxp.com,
	linux-media@vger.kernel.org,  linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] Additional features for Hantro HEVC
Date: Tue, 22 Jun 2021 09:54:35 -0300	[thread overview]
Message-ID: <3ab5878bc03eb91a785c0fa57836e8d226df524d.camel@collabora.com> (raw)
In-Reply-To: <20210618131526.566762-1-benjamin.gaignard@collabora.com>

Hi Benjamin,

On Fri, 2021-06-18 at 15:15 +0200, Benjamin Gaignard wrote:
> version 3:
>  - Change trace file name to hantro_trace.h
> 
> version 2:
>  - Fix structure name in ext-ctrls-codec.rst
>  - Define the value for compression storage size
>  - Add comments about registers usage
>  - Add documentation about P010 padding
> 
> Basic HEVC support has been added to Hantro driver in this pull request:
> https://www.spinics.net/lists/linux-media/msg193744.html
> 
> Thanks to that it is now possible to support more features for this driver.
> 
> The first patch allow to log the hardware performance per macroblock.
> The second patch makes the driver use compressed reference frames to
> reduce memory bandwidth consumption.
> Patches 3 to 5 allow to decode and produce 10-bits P010 frames.
> Patch 6 make usage of G2 post processor to scale down the frames.
> Patches 7 and 8 add the support of HEVC scaling matrix by adding a new
> control.
> 

For the next cover letter, please make sure you provide
some notes about how this was tested, with a gstreamer
public branch if needed; and also fluendo's fluster conformance
results before/after this patchset.

While there, make sure you check for performance regressions/improvements
and add such information to the commit descriptions. The more the merrier.

Thanks a lot,
Ezequiel


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	hverkuil@xs4all.nl, p.zabel@pengutronix.de, mchehab@kernel.org,
	shawnguo@kernel.org,  s.hauer@pengutronix.de, festevam@gmail.com,
	gregkh@linuxfoundation.org,  mripard@kernel.org,
	paul.kocialkowski@bootlin.com, wens@csie.org,
	 jernej.skrabec@siol.net, emil.l.velikov@gmail.com,
	andrzej.p@collabora.com, jc@kynesim.co.uk,
	jernej.skrabec@gmail.com, nicolas@ndufresne.ca
Cc: kernel@pengutronix.de, linux-imx@nxp.com,
	linux-media@vger.kernel.org,  linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] Additional features for Hantro HEVC
Date: Tue, 22 Jun 2021 09:54:35 -0300	[thread overview]
Message-ID: <3ab5878bc03eb91a785c0fa57836e8d226df524d.camel@collabora.com> (raw)
In-Reply-To: <20210618131526.566762-1-benjamin.gaignard@collabora.com>

Hi Benjamin,

On Fri, 2021-06-18 at 15:15 +0200, Benjamin Gaignard wrote:
> version 3:
>  - Change trace file name to hantro_trace.h
> 
> version 2:
>  - Fix structure name in ext-ctrls-codec.rst
>  - Define the value for compression storage size
>  - Add comments about registers usage
>  - Add documentation about P010 padding
> 
> Basic HEVC support has been added to Hantro driver in this pull request:
> https://www.spinics.net/lists/linux-media/msg193744.html
> 
> Thanks to that it is now possible to support more features for this driver.
> 
> The first patch allow to log the hardware performance per macroblock.
> The second patch makes the driver use compressed reference frames to
> reduce memory bandwidth consumption.
> Patches 3 to 5 allow to decode and produce 10-bits P010 frames.
> Patch 6 make usage of G2 post processor to scale down the frames.
> Patches 7 and 8 add the support of HEVC scaling matrix by adding a new
> control.
> 

For the next cover letter, please make sure you provide
some notes about how this was tested, with a gstreamer
public branch if needed; and also fluendo's fluster conformance
results before/after this patchset.

While there, make sure you check for performance regressions/improvements
and add such information to the commit descriptions. The more the merrier.

Thanks a lot,
Ezequiel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-06-22 12:55 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 13:15 [PATCH v3 0/8] Additional features for Hantro HEVC Benjamin Gaignard
2021-06-18 13:15 ` Benjamin Gaignard
2021-06-18 13:15 ` Benjamin Gaignard
2021-06-18 13:15 ` [PATCH v3 1/8] media: hantro: Trace hevc hw cycles performance register Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 18:58   ` Ezequiel Garcia
2021-06-18 18:58     ` Ezequiel Garcia
2021-06-18 18:58     ` Ezequiel Garcia
2021-06-22 12:23     ` Benjamin Gaignard
2021-06-22 12:23       ` Benjamin Gaignard
2021-06-22 12:23       ` Benjamin Gaignard
2021-06-22 12:48       ` Ezequiel Garcia
2021-06-22 12:48         ` Ezequiel Garcia
2021-06-22 12:48         ` Ezequiel Garcia
2021-06-18 13:15 ` [PATCH v3 2/8] media: hantro: Add support of compressed reference buffers Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15 ` [PATCH v3 3/8] media: hantro: hevc: Allow 10-bits encoded streams Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15 ` [PATCH v3 4/8] media: Add P010 video format Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 19:38   ` Ezequiel Garcia
2021-06-18 19:38     ` Ezequiel Garcia
2021-06-18 19:38     ` Ezequiel Garcia
2021-06-22 21:24     ` Nicolas Dufresne
2021-06-22 21:24       ` Nicolas Dufresne
2021-06-22 21:24       ` Nicolas Dufresne
2021-06-22 22:21       ` Ezequiel Garcia
2021-06-22 22:21         ` Ezequiel Garcia
2021-06-22 22:21         ` Ezequiel Garcia
2021-06-25 19:33   ` Nicolas Dufresne
2021-06-25 19:33     ` Nicolas Dufresne
2021-06-25 19:33     ` Nicolas Dufresne
2021-06-28 13:37     ` Benjamin Gaignard
2021-06-28 13:37       ` Benjamin Gaignard
2021-06-28 13:37       ` Benjamin Gaignard
2021-06-18 13:15 ` [PATCH v3 5/8] media: hantro: hevc: Allow to produce 10-bit frames Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-22 13:26   ` Ezequiel Garcia
2021-06-22 13:26     ` Ezequiel Garcia
2021-06-22 13:26     ` Ezequiel Garcia
2021-06-18 13:15 ` [PATCH v3 6/8] media: hantro: enumerate scaled output formats Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 19:24   ` Ezequiel Garcia
2021-06-18 19:24     ` Ezequiel Garcia
2021-06-18 19:24     ` Ezequiel Garcia
2021-06-22 21:45   ` Nicolas Dufresne
2021-06-22 21:45     ` Nicolas Dufresne
2021-06-22 21:45     ` Nicolas Dufresne
2021-06-18 13:15 ` [PATCH v3 7/8] media: hevc: Add scaling matrix control Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15 ` [PATCH v3 8/8] media: hantro: Add scaling lists feature Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-18 13:15   ` Benjamin Gaignard
2021-06-22 12:54 ` Ezequiel Garcia [this message]
2021-06-22 12:54   ` [PATCH v3 0/8] Additional features for Hantro HEVC Ezequiel Garcia
2021-06-22 12:54   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ab5878bc03eb91a785c0fa57836e8d226df524d.camel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=andrzej.p@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=emil.l.velikov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jc@kynesim.co.uk \
    --cc=jernej.skrabec@gmail.com \
    --cc=jernej.skrabec@siol.net \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.