From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/spdlog: need threads
Date: Sat, 5 Oct 2019 16:22:08 +0200 [thread overview]
Message-ID: <3af3a943-a594-01bd-c387-d2b62dcfa7e9@mind.be> (raw)
In-Reply-To: <20191004083913.15584-1-asafka7@gmail.com>
On 04/10/2019 10:39, Asaf Kahlon wrote:
> Fixes:
> - http://autobuild.buildroot.net/results/f839e70e96a0c7d67034f604565b32ca354da7d0/
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
> package/spdlog/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/spdlog/Config.in b/package/spdlog/Config.in
> index 4b721774eb..f78b4f8959 100644
> --- a/package/spdlog/Config.in
> +++ b/package/spdlog/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_SPDLOG
> bool "spdlog"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_WCHAR # fmt
Please keep these alphabetical.
> select BR2_PACKAGE_FMT
> @@ -9,4 +10,5 @@ config BR2_PACKAGE_SPDLOG
> https://github.com/gabime/spdlog
>
> comment "spdlog needs a toolchain w/ C++, wchar"
threads should have been mentioned here as well.
Applied to master with those fixed, thanks.
Regards,
Arnout
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
> + || !BR2_TOOLCHAIN_HAS_THREADS
>
prev parent reply other threads:[~2019-10-05 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 8:39 [Buildroot] [PATCH 1/1] package/spdlog: need threads Asaf Kahlon
2019-10-05 14:22 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3af3a943-a594-01bd-c387-d2b62dcfa7e9@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.