* [Buildroot] [PATCH 1/1] package/spdlog: need threads
@ 2019-10-04 8:39 Asaf Kahlon
2019-10-05 14:22 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: Asaf Kahlon @ 2019-10-04 8:39 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.net/results/f839e70e96a0c7d67034f604565b32ca354da7d0/
Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
package/spdlog/Config.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/spdlog/Config.in b/package/spdlog/Config.in
index 4b721774eb..f78b4f8959 100644
--- a/package/spdlog/Config.in
+++ b/package/spdlog/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_SPDLOG
bool "spdlog"
+ depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_USE_WCHAR # fmt
select BR2_PACKAGE_FMT
@@ -9,4 +10,5 @@ config BR2_PACKAGE_SPDLOG
https://github.com/gabime/spdlog
comment "spdlog needs a toolchain w/ C++, wchar"
- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+ || !BR2_TOOLCHAIN_HAS_THREADS
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/spdlog: need threads
2019-10-04 8:39 [Buildroot] [PATCH 1/1] package/spdlog: need threads Asaf Kahlon
@ 2019-10-05 14:22 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2019-10-05 14:22 UTC (permalink / raw)
To: buildroot
On 04/10/2019 10:39, Asaf Kahlon wrote:
> Fixes:
> - http://autobuild.buildroot.net/results/f839e70e96a0c7d67034f604565b32ca354da7d0/
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
> package/spdlog/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/spdlog/Config.in b/package/spdlog/Config.in
> index 4b721774eb..f78b4f8959 100644
> --- a/package/spdlog/Config.in
> +++ b/package/spdlog/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_SPDLOG
> bool "spdlog"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_WCHAR # fmt
Please keep these alphabetical.
> select BR2_PACKAGE_FMT
> @@ -9,4 +10,5 @@ config BR2_PACKAGE_SPDLOG
> https://github.com/gabime/spdlog
>
> comment "spdlog needs a toolchain w/ C++, wchar"
threads should have been mentioned here as well.
Applied to master with those fixed, thanks.
Regards,
Arnout
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
> + || !BR2_TOOLCHAIN_HAS_THREADS
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-05 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 8:39 [Buildroot] [PATCH 1/1] package/spdlog: need threads Asaf Kahlon
2019-10-05 14:22 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.