All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: kernel test robot <lkp@intel.com>, kvmarm@lists.cs.columbia.edu
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	eauger@redhat.com, oupton@google.com,
	Jonathan.Cameron@huawei.com, vkuznets@redhat.com,
	will@kernel.org, shannon.zhaosl@gmail.com, james.morse@arm.com,
	mark.rutland@arm.com, maz@kernel.org, pbonzini@redhat.com,
	shan.gavin@gmail.com
Subject: Re: [PATCH] KVM: arm64: fix returnvar.cocci warnings
Date: Mon, 4 Apr 2022 18:54:18 +0800	[thread overview]
Message-ID: <3afd08d2-223c-ea02-0983-616fee32e587@redhat.com> (raw)
In-Reply-To: <YkrH6t5QVUREfijB@fdced1fdac95>

On 4/4/22 6:26 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> arch/arm64/kvm/sdei.c:346:15-18: Unneeded variable: "ret". Return "SDEI_SUCCESS" on line 352
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Gavin Shan <gshan@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Gavin-Shan/Support-SDEI-Virtualization/20220403-234350
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
> :::::: branch date: 19 hours ago
> :::::: commit date: 19 hours ago
> 
>   arch/arm64/kvm/sdei.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/arch/arm64/kvm/sdei.c
> +++ b/arch/arm64/kvm/sdei.c
> @@ -343,13 +343,12 @@ out:
>   static unsigned long hypercall_mask(struct kvm_vcpu *vcpu, bool mask)
>   {
>   	struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei;
> -	unsigned long ret = SDEI_SUCCESS;
>   
>   	spin_lock(&vsdei->lock);
>   	vsdei->masked = mask ? 1 : 0;
>   	spin_unlock(&vsdei->lock);
>   
> -	return ret;
> +	return SDEI_SUCCESS;
>   }
>   
>   int kvm_sdei_call(struct kvm_vcpu *vcpu)
> 

Thanks for reporting the warning. I will fold the changes in next respin
if needed.

Thanks,
Gavin


WARNING: multiple messages have this Message-ID (diff)
From: Gavin Shan <gshan@redhat.com>
To: kernel test robot <lkp@intel.com>, kvmarm@lists.cs.columbia.edu
Cc: kbuild-all@lists.01.org, maz@kernel.org,
	linux-kernel@vger.kernel.org, eauger@redhat.com,
	shan.gavin@gmail.com, Jonathan.Cameron@huawei.com,
	pbonzini@redhat.com, vkuznets@redhat.com, will@kernel.org
Subject: Re: [PATCH] KVM: arm64: fix returnvar.cocci warnings
Date: Mon, 4 Apr 2022 18:54:18 +0800	[thread overview]
Message-ID: <3afd08d2-223c-ea02-0983-616fee32e587@redhat.com> (raw)
In-Reply-To: <YkrH6t5QVUREfijB@fdced1fdac95>

On 4/4/22 6:26 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> arch/arm64/kvm/sdei.c:346:15-18: Unneeded variable: "ret". Return "SDEI_SUCCESS" on line 352
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Gavin Shan <gshan@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Gavin-Shan/Support-SDEI-Virtualization/20220403-234350
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
> :::::: branch date: 19 hours ago
> :::::: commit date: 19 hours ago
> 
>   arch/arm64/kvm/sdei.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/arch/arm64/kvm/sdei.c
> +++ b/arch/arm64/kvm/sdei.c
> @@ -343,13 +343,12 @@ out:
>   static unsigned long hypercall_mask(struct kvm_vcpu *vcpu, bool mask)
>   {
>   	struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei;
> -	unsigned long ret = SDEI_SUCCESS;
>   
>   	spin_lock(&vsdei->lock);
>   	vsdei->masked = mask ? 1 : 0;
>   	spin_unlock(&vsdei->lock);
>   
> -	return ret;
> +	return SDEI_SUCCESS;
>   }
>   
>   int kvm_sdei_call(struct kvm_vcpu *vcpu)
> 

Thanks for reporting the warning. I will fold the changes in next respin
if needed.

Thanks,
Gavin

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Gavin Shan <gshan@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] KVM: arm64: fix returnvar.cocci warnings
Date: Mon, 04 Apr 2022 18:54:18 +0800	[thread overview]
Message-ID: <3afd08d2-223c-ea02-0983-616fee32e587@redhat.com> (raw)
In-Reply-To: <YkrH6t5QVUREfijB@fdced1fdac95>

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On 4/4/22 6:26 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> arch/arm64/kvm/sdei.c:346:15-18: Unneeded variable: "ret". Return "SDEI_SUCCESS" on line 352
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Gavin Shan <gshan@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Gavin-Shan/Support-SDEI-Virtualization/20220403-234350
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf
> :::::: branch date: 19 hours ago
> :::::: commit date: 19 hours ago
> 
>   arch/arm64/kvm/sdei.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/arch/arm64/kvm/sdei.c
> +++ b/arch/arm64/kvm/sdei.c
> @@ -343,13 +343,12 @@ out:
>   static unsigned long hypercall_mask(struct kvm_vcpu *vcpu, bool mask)
>   {
>   	struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei;
> -	unsigned long ret = SDEI_SUCCESS;
>   
>   	spin_lock(&vsdei->lock);
>   	vsdei->masked = mask ? 1 : 0;
>   	spin_unlock(&vsdei->lock);
>   
> -	return ret;
> +	return SDEI_SUCCESS;
>   }
>   
>   int kvm_sdei_call(struct kvm_vcpu *vcpu)
> 

Thanks for reporting the warning. I will fold the changes in next respin
if needed.

Thanks,
Gavin

  reply	other threads:[~2022-04-04 10:54 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 15:38 [PATCH v6 00/18] Support SDEI Virtualization Gavin Shan
2022-04-03 15:38 ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 01/18] KVM: arm64: Extend smccc_get_argx() Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 02/18] KVM: arm64: Route hypercalls based on their owner Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-21  8:19   ` Oliver Upton
2022-04-21  8:19     ` Oliver Upton
2022-04-22 12:20     ` Gavin Shan
2022-04-22 12:20       ` Gavin Shan
2022-04-22 17:59       ` Oliver Upton
2022-04-22 17:59         ` Oliver Upton
2022-04-23 12:48         ` Gavin Shan
2022-04-23 12:48           ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 03/18] KVM: arm64: Add SDEI virtualization infrastructure Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-22 21:48   ` Oliver Upton
2022-04-22 21:48     ` Oliver Upton
2022-04-23 14:18     ` Gavin Shan
2022-04-23 14:18       ` Gavin Shan
2022-04-23 18:43       ` Oliver Upton
2022-04-23 18:43         ` Oliver Upton
2022-04-24  3:00         ` Gavin Shan
2022-04-24  3:00           ` Gavin Shan
2022-04-28 20:28           ` Oliver Upton
2022-04-28 20:28             ` Oliver Upton
2022-04-30 11:38             ` Gavin Shan
2022-04-30 11:38               ` Gavin Shan
2022-04-30 14:16               ` Oliver Upton
2022-04-30 14:16                 ` Oliver Upton
2022-05-02  2:35                 ` Gavin Shan
2022-05-02  2:35                   ` Gavin Shan
2022-05-02  3:40                   ` Oliver Upton
2022-05-02  3:40                     ` Oliver Upton
2022-05-02  7:25                     ` Gavin Shan
2022-05-02  7:25                       ` Gavin Shan
2022-05-02  7:57                       ` Oliver Upton
2022-05-02  7:57                         ` Oliver Upton
2022-05-02  8:23                         ` Gavin Shan
2022-05-02  8:23                           ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 04/18] KVM: arm64: Support SDEI_EVENT_REGISTER hypercall Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-30 14:54   ` Oliver Upton
2022-04-30 14:54     ` Oliver Upton
2022-05-02  2:55     ` Gavin Shan
2022-05-02  2:55       ` Gavin Shan
2022-05-02  3:43       ` Oliver Upton
2022-05-02  3:43         ` Oliver Upton
2022-05-02  7:28         ` Gavin Shan
2022-05-02  7:28           ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 05/18] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-03 15:38 ` [PATCH v6 06/18] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Gavin Shan
2022-04-03 15:38   ` Gavin Shan
2022-04-30 15:03   ` Oliver Upton
2022-04-30 15:03     ` Oliver Upton
2022-05-02  2:57     ` Gavin Shan
2022-05-02  2:57       ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 07/18] KVM: arm64: Support SDEI_EVENT_UNREGISTER hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 08/18] KVM: arm64: Support SDEI_EVENT_STATUS hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 09/18] KVM: arm64: Support SDEI_EVENT_GET_INFO hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 10/18] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-04 10:26   ` [PATCH] KVM: arm64: fix returnvar.cocci warnings kernel test robot
2022-04-04 10:26     ` kernel test robot
2022-04-04 10:54     ` Gavin Shan [this message]
2022-04-04 10:54       ` Gavin Shan
2022-04-04 10:54       ` Gavin Shan
2022-04-04 10:29   ` [PATCH v6 10/18] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall kernel test robot
2022-04-04 10:29     ` kernel test robot
2022-04-03 15:39 ` [PATCH v6 11/18] KVM: arm64: Support SDEI_{PRIVATE, SHARED}_RESET Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 12/18] KVM: arm64: Support SDEI event injection, delivery Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 13/18] KVM: arm64: Support SDEI_EVENT_{COMPLETE,COMPLETE_AND_RESUME} hypercall Gavin Shan
2022-04-03 15:39   ` [PATCH v6 13/18] KVM: arm64: Support SDEI_EVENT_{COMPLETE, COMPLETE_AND_RESUME} hypercall Gavin Shan
2022-05-01  6:50   ` [PATCH v6 13/18] KVM: arm64: Support SDEI_EVENT_{COMPLETE,COMPLETE_AND_RESUME} hypercall Oliver Upton
2022-05-01  6:50     ` Oliver Upton
2022-05-02  6:19     ` Gavin Shan
2022-05-02  6:19       ` Gavin Shan
2022-05-02  7:38       ` Oliver Upton
2022-05-02  7:38         ` Oliver Upton
2022-05-02  7:51         ` Gavin Shan
2022-05-02  7:51           ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 14/18] KVM: arm64: Support SDEI_EVENT_SIGNAL hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-30 21:32   ` Oliver Upton
2022-04-30 21:32     ` Oliver Upton
2022-05-02  3:04     ` Gavin Shan
2022-05-02  3:04       ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 15/18] KVM: arm64: Support SDEI_FEATURES hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-05-01  6:55   ` Oliver Upton
2022-05-01  6:55     ` Oliver Upton
2022-05-02  3:05     ` Gavin Shan
2022-05-02  3:05       ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 16/18] KVM: arm64: Support SDEI_VERSION hypercall Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 17/18] KVM: arm64: Expose SDEI capability Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:39 ` [PATCH v6 18/18] KVM: selftests: Add SDEI test case Gavin Shan
2022-04-03 15:39   ` Gavin Shan
2022-04-03 15:47 ` [PATCH v6 00/18] Support SDEI Virtualization Gavin Shan
2022-04-03 15:47   ` Gavin Shan
2022-04-04  6:09   ` Oliver Upton
2022-04-04  6:09     ` Oliver Upton
2022-04-04 10:53     ` Gavin Shan
2022-04-04 10:53       ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3afd08d2-223c-ea02-0983-616fee32e587@redhat.com \
    --to=gshan@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=eauger@redhat.com \
    --cc=james.morse@arm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=shan.gavin@gmail.com \
    --cc=shannon.zhaosl@gmail.com \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.