[RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Date: Sat, 5 May 2018 10:21:16 +0800	[thread overview]
Message-ID: <3b0c7ca576fee8220d63c9914483b70b0fbc8783.1525486663.git.chunfeng.yun@mediatek.com> (raw)

The variable of 'count' is declared as u8, this will cause an issue
due to value truncated when works in SS or SSP mode and data length
is greater than 255, so change it as u32.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c b/drivers/usb/mtu3/mtu3_gadget_ep0.c
index ebdcf7a..d67b540 100644
--- a/drivers/usb/mtu3/mtu3_gadget_ep0.c
+++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c
@@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu)
 	struct usb_request *req;
 	u32 csr;
 	u8 *src;
-	u8 count;
+	u32 count;
 	u32 maxp;
 
 	dev_dbg(mtu->dev, "%s\n", __func__);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Date: Sat, 5 May 2018 10:21:16 +0800	[thread overview]
Message-ID: <3b0c7ca576fee8220d63c9914483b70b0fbc8783.1525486663.git.chunfeng.yun@mediatek.com> (raw)

The variable of 'count' is declared as u8, this will cause an issue
due to value truncated when works in SS or SSP mode and data length
is greater than 255, so change it as u32.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c b/drivers/usb/mtu3/mtu3_gadget_ep0.c
index ebdcf7a..d67b540 100644
--- a/drivers/usb/mtu3/mtu3_gadget_ep0.c
+++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c
@@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu)
 	struct usb_request *req;
 	u32 csr;
 	u8 *src;
-	u8 count;
+	u32 count;
 	u32 maxp;
 
 	dev_dbg(mtu->dev, "%s\n", __func__);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [RESEND,1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Date: Sat, 5 May 2018 10:21:16 +0800	[thread overview]
Message-ID: <3b0c7ca576fee8220d63c9914483b70b0fbc8783.1525486663.git.chunfeng.yun@mediatek.com> (raw)

The variable of 'count' is declared as u8, this will cause an issue
due to value truncated when works in SS or SSP mode and data length
is greater than 255, so change it as u32.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c b/drivers/usb/mtu3/mtu3_gadget_ep0.c
index ebdcf7a..d67b540 100644
--- a/drivers/usb/mtu3/mtu3_gadget_ep0.c
+++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c
@@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu)
 	struct usb_request *req;
 	u32 csr;
 	u8 *src;
-	u8 count;
+	u32 count;
 	u32 maxp;
 
 	dev_dbg(mtu->dev, "%s\n", __func__);

WARNING: multiple messages have this Message-ID (diff)

From: chunfeng.yun@mediatek.com (Chunfeng Yun)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Date: Sat, 5 May 2018 10:21:16 +0800	[thread overview]
Message-ID: <3b0c7ca576fee8220d63c9914483b70b0fbc8783.1525486663.git.chunfeng.yun@mediatek.com> (raw)

The variable of 'count' is declared as u8, this will cause an issue
due to value truncated when works in SS or SSP mode and data length
is greater than 255, so change it as u32.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c b/drivers/usb/mtu3/mtu3_gadget_ep0.c
index ebdcf7a..d67b540 100644
--- a/drivers/usb/mtu3/mtu3_gadget_ep0.c
+++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c
@@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu)
 	struct usb_request *req;
 	u32 csr;
 	u8 *src;
-	u8 count;
+	u32 count;
 	u32 maxp;
 
 	dev_dbg(mtu->dev, "%s\n", __func__);
-- 
1.9.1

next             reply	other threads:[~2018-05-05  2:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05  2:21 Chunfeng Yun [this message]
2018-05-05  2:21 ` [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode Chunfeng Yun
2018-05-05  2:21 ` [RESEND,1/5] " Chunfeng Yun
2018-05-05  2:21 ` [RESEND PATCH 1/5] " Chunfeng Yun
2018-05-05  2:21 ` [RESEND PATCH 2/5] usb: mtu3: remove repeated setting of gadget state Chunfeng Yun
2018-05-05  2:21   ` Chunfeng Yun
2018-05-05  2:21   ` [RESEND,2/5] " Chunfeng Yun
2018-05-05  2:21   ` [RESEND PATCH 2/5] " Chunfeng Yun
2018-05-05  2:21 ` [RESEND PATCH 3/5] usb: mtu3: fix an unrecognized issue when connected with PC Chunfeng Yun
2018-05-05  2:21   ` Chunfeng Yun
2018-05-05  2:21   ` [RESEND,3/5] " Chunfeng Yun
2018-05-05  2:21   ` [RESEND PATCH 3/5] " Chunfeng Yun
2018-05-05  2:21 ` [RESEND PATCH 4/5] usb: mtu3: fix operation failure when test TEST_J/K Chunfeng Yun
2018-05-05  2:21   ` Chunfeng Yun
2018-05-05  2:21   ` [RESEND,4/5] " Chunfeng Yun
2018-05-05  2:21   ` [RESEND PATCH 4/5] " Chunfeng Yun
2018-05-05  2:21 ` [RESEND PATCH 5/5] usb: mtu3: make USB_MTU3_DUAL_ROLE depend on EXTCON but not USB_MTU3 Chunfeng Yun
2018-05-05  2:21   ` Chunfeng Yun
2018-05-05  2:21   ` [RESEND,5/5] " Chunfeng Yun
2018-05-05  2:21   ` [RESEND PATCH 5/5] " Chunfeng Yun
2018-05-10  2:16 ` [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode Chunfeng Yun
2018-05-10  2:16   ` Chunfeng Yun
2018-05-10  2:16   ` [RESEND,1/5] " Chunfeng Yun
2018-05-10  2:16   ` [RESEND PATCH 1/5] " Chunfeng Yun
2018-05-10  3:11   ` Chunfeng Yun
2018-05-10  3:11     ` Chunfeng Yun
2018-05-10  3:11     ` [RESEND,1/5] " Chunfeng Yun
2018-05-10  3:11     ` [RESEND PATCH 1/5] " Chunfeng Yun

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:ebdcf7a dfblob:ebdcf7a dfblob:ebdcf7a dfblob:ebdcf7a
dfblob:d67b540 dfblob:d67b540 dfblob:d67b540 dfblob:d67b540
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b0c7ca576fee8220d63c9914483b70b0fbc8783.1525486663.git.chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.