All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Jiri Pirko <jiri@resnulli.us>, Jian-Hong Pan <starnight@g.ncu.edu.tw>
Cc: netdev@vger.kernel.org, linux-lpwan@lists.infradead.org,
	Ben Whitten <ben.whitten@lairdtech.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style
Date: Wed, 16 Jan 2019 16:07:31 +0100	[thread overview]
Message-ID: <3b11ea71-ab65-11b3-2ee1-46f9a9fa145d@suse.de> (raw)
In-Reply-To: <20190116143337.GF5265@nanopsycho>

Am 16.01.19 um 15:33 schrieb Jiri Pirko:
> Wed, Jan 16, 2019 at 03:24:54PM CET, starnight@g.ncu.edu.tw wrote:
>> Signed-off-by: Jian-Hong Pan <starnight@g.ncu.edu.tw>
>> ---
> 
> Patches like this are in general frowned upon. Do one change in one
> patch. Put some patch description.

This patch simply shouldn't have gone to netdev and LKML, as it is a
fixup against a non-stable tree (missing "lora-next"). Once squashed, it
doesn't matter whether it once had a verbose explanation or not. And I
prefer to not mix style and functional changes.

I simply was too impatient to wait for more respins before being able to
base work on it. ;)

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2019-01-16 15:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 14:20 [RFC PATCH 0/5] net: lorawan: Refine the lorawan protocol module Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 1/5] net: lorawan: Refine the coding style Jian-Hong Pan
2019-01-16 14:33   ` Jiri Pirko
2019-01-16 15:07     ` Andreas Färber [this message]
2019-01-16 16:06       ` Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 2/5] net: lorawan: Remove unused lrw_dev_hard_header function Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 3/5] net; lorawan: Fix net device leakage Jian-Hong Pan
2019-01-16 14:34   ` Jiri Pirko
2019-01-16 14:25 ` [RFC PATCH 4/5] net: lorawan: Fulfill the help text of Kconfig Jian-Hong Pan
2019-01-16 14:35   ` Jiri Pirko
2019-01-16 14:25 ` [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header Jian-Hong Pan
2019-01-16 14:36   ` Jiri Pirko
2019-01-16 14:50     ` Andreas Färber
2019-01-16 16:35       ` Jian-Hong Pan
2019-01-16 14:25 ` Jian-Hong Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b11ea71-ab65-11b3-2ee1-46f9a9fa145d@suse.de \
    --to=afaerber@suse.de \
    --cc=ben.whitten@lairdtech.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-lpwan@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=starnight@g.ncu.edu.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.