From: "Andreas Färber" <afaerber@suse.de>
To: Jiri Pirko <jiri@resnulli.us>, Jian-Hong Pan <starnight@g.ncu.edu.tw>
Cc: netdev@vger.kernel.org, linux-lpwan@lists.infradead.org,
Ben Whitten <ben.whitten@lairdtech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header
Date: Wed, 16 Jan 2019 15:50:46 +0100 [thread overview]
Message-ID: <3d905f4f-e354-3607-32e0-84ec385222f0@suse.de> (raw)
In-Reply-To: <20190116143613.GI5265@nanopsycho>
Am 16.01.19 um 15:36 schrieb Jiri Pirko:
> Wed, Jan 16, 2019 at 03:25:02PM CET, starnight@g.ncu.edu.tw wrote:
>> Split LoRaWAN related skb definitions from lora/lorawan_netdev.h into
>> another header lora/lorawan_skb.h.
>
> What is the motivation for this change?
I suggested it because skbs could be used with either LoRa or LoRaWAN
netdevs. I have a lora/skb.h.
In general the lorawan_foo.h looks ugly to me, so I thought I suggested
to avoid that by using [lora/]lorawan/skb.h?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-01-16 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 14:20 [RFC PATCH 0/5] net: lorawan: Refine the lorawan protocol module Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 1/5] net: lorawan: Refine the coding style Jian-Hong Pan
2019-01-16 14:33 ` Jiri Pirko
2019-01-16 15:07 ` Andreas Färber
2019-01-16 16:06 ` Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 2/5] net: lorawan: Remove unused lrw_dev_hard_header function Jian-Hong Pan
2019-01-16 14:24 ` [RFC PATCH 3/5] net; lorawan: Fix net device leakage Jian-Hong Pan
2019-01-16 14:34 ` Jiri Pirko
2019-01-16 14:25 ` [RFC PATCH 4/5] net: lorawan: Fulfill the help text of Kconfig Jian-Hong Pan
2019-01-16 14:35 ` Jiri Pirko
2019-01-16 14:25 ` [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header Jian-Hong Pan
2019-01-16 14:36 ` Jiri Pirko
2019-01-16 14:50 ` Andreas Färber [this message]
2019-01-16 16:35 ` Jian-Hong Pan
2019-01-16 14:25 ` Jian-Hong Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d905f4f-e354-3607-32e0-84ec385222f0@suse.de \
--to=afaerber@suse.de \
--cc=ben.whitten@lairdtech.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lpwan@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=starnight@g.ncu.edu.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.