* [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb
@ 2016-10-15 16:00 Colin King
2016-10-16 15:38 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-10-15 16:00 UTC (permalink / raw)
To: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, linux-mtd
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Static analysis by CoverityScan detected the ec and pnum
arguments are in the wrong order on a call to ubi_alloc_aeb.
Swap the order to fix this.
Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index d6384d9..4eed546 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai,
/* new_aeb is newer */
if (cmp_res & 1) {
- victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum);
+ victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec);
if (!victim)
return -ENOMEM;
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb
2016-10-15 16:00 [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Colin King
@ 2016-10-16 15:38 ` Boris Brezillon
2016-10-18 19:25 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2016-10-16 15:38 UTC (permalink / raw)
To: Colin King
Cc: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, linux-mtd, linux-kernel
On Sat, 15 Oct 2016 17:00:11 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis by CoverityScan detected the ec and pnum
> arguments are in the wrong order on a call to ubi_alloc_aeb.
> Swap the order to fix this.
>
> Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index d6384d9..4eed546 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai,
>
> /* new_aeb is newer */
> if (cmp_res & 1) {
> - victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum);
> + victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec);
> if (!victim)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb
2016-10-16 15:38 ` Boris Brezillon
@ 2016-10-18 19:25 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2016-10-18 19:25 UTC (permalink / raw)
To: Boris Brezillon, Colin King
Cc: Artem Bityutskiy, David Woodhouse, Brian Norris, linux-mtd, linux-kernel
On 16.10.2016 17:38, Boris Brezillon wrote:
> On Sat, 15 Oct 2016 17:00:11 +0100
> Colin King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Static analysis by CoverityScan detected the ec and pnum
>> arguments are in the wrong order on a call to ubi_alloc_aeb.
>> Swap the order to fix this.
>>
>> Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Applied. :)
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-18 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-15 16:00 [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Colin King
2016-10-16 15:38 ` Boris Brezillon
2016-10-18 19:25 ` Richard Weinberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.