From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Alexander Klimov <grandmaster@al2klimov.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Colin Ian King <colin.king@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Gustavo A R Silva <gustavoars@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-arm-kernel@lists.infradead.org,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Rapoport <rppt@kernel.org>, Peter Jones <pjones@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Qilong Zhang <zhangqilong3@huawei.com>,
Randy Dunlap <rdunlap@infradead.org>,
Rich Felker <dalias@libc.org>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Winischhofer <thomas@winischhofer.net>,
Tony Prisk <linux@prisktech.co.nz>,
Michal Januszewski <spock@gentoo.org>
Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning
Date: Mon, 7 Dec 2020 09:18:20 +0100 [thread overview]
Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> (raw)
In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 1257 bytes --]
Am 06.12.20 um 20:02 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
>
> v2:
> - Updated subject (Lee)
>
> v3:
> - Return early in case of an error (Thomas)
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/uvesafb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 6c9cfab39313..4df6772802d7 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
> task->t.regs.eax = 0x4f0a;
> task->t.regs.ebx = 0x0;
> err = uvesafb_exec(task);
> + if (err)
> + return err;
>
> if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
> par->pmi_setpal = par->ypan = 0;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Rich Felker <dalias@libc.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Gustavo A R Silva <gustavoars@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Michal Januszewski <spock@gentoo.org>,
Peter Jones <pjones@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Ellerman <mpe@ellerman.id.au>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Thomas Winischhofer <thomas@winischhofer.net>,
linux-arm-kernel@lists.infradead.org,
Qilong Zhang <zhangqilong3@huawei.com>,
Randy Dunlap <rdunlap@infradead.org>,
Douglas Anderson <dianders@chromium.org>,
Tony Prisk <linux@prisktech.co.nz>,
Thierry Reding <thierry.reding@gmail.com>,
Alexander Klimov <grandmaster@al2klimov.de>,
Colin Ian King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning
Date: Mon, 7 Dec 2020 09:18:20 +0100 [thread overview]
Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> (raw)
In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1257 bytes --]
Am 06.12.20 um 20:02 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
>
> v2:
> - Updated subject (Lee)
>
> v3:
> - Return early in case of an error (Thomas)
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/uvesafb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 6c9cfab39313..4df6772802d7 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
> task->t.regs.eax = 0x4f0a;
> task->t.regs.ebx = 0x0;
> err = uvesafb_exec(task);
> + if (err)
> + return err;
>
> if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
> par->pmi_setpal = par->ypan = 0;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Rich Felker <dalias@libc.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Gustavo A R Silva <gustavoars@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Michal Januszewski <spock@gentoo.org>,
Peter Jones <pjones@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Ellerman <mpe@ellerman.id.au>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Thomas Winischhofer <thomas@winischhofer.net>,
linux-arm-kernel@lists.infradead.org,
Qilong Zhang <zhangqilong3@huawei.com>,
Randy Dunlap <rdunlap@infradead.org>,
Douglas Anderson <dianders@chromium.org>,
Tony Prisk <linux@prisktech.co.nz>,
Thierry Reding <thierry.reding@gmail.com>,
Alexander Klimov <grandmaster@al2klimov.de>,
Colin Ian King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning
Date: Mon, 7 Dec 2020 09:18:20 +0100 [thread overview]
Message-ID: <3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de> (raw)
In-Reply-To: <20201206190247.1861316-5-sam@ravnborg.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1257 bytes --]
Am 06.12.20 um 20:02 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
>
> v2:
> - Updated subject (Lee)
>
> v3:
> - Return early in case of an error (Thomas)
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Januszewski <spock@gentoo.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/uvesafb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 6c9cfab39313..4df6772802d7 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
> task->t.regs.eax = 0x4f0a;
> task->t.regs.ebx = 0x0;
> err = uvesafb_exec(task);
> + if (err)
> + return err;
>
> if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
> par->pmi_setpal = par->ypan = 0;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-07 8:19 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 19:02 [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:34 ` Randy Dunlap
2020-12-06 19:34 ` Randy Dunlap
2020-12-06 19:34 ` Randy Dunlap
2020-12-06 19:02 ` [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:37 ` Randy Dunlap
2020-12-06 19:37 ` Randy Dunlap
2020-12-06 19:37 ` Randy Dunlap
2020-12-06 20:52 ` Sam Ravnborg
2020-12-06 20:52 ` Sam Ravnborg
2020-12-06 20:52 ` Sam Ravnborg
2020-12-06 21:27 ` Randy Dunlap
2020-12-06 21:27 ` Randy Dunlap
2020-12-06 21:27 ` Randy Dunlap
2020-12-07 8:16 ` Thomas Zimmermann
2020-12-07 8:16 ` Thomas Zimmermann
2020-12-07 8:16 ` Thomas Zimmermann
2020-12-07 16:43 ` Randy Dunlap
2020-12-07 16:43 ` Randy Dunlap
2020-12-07 16:43 ` Randy Dunlap
2020-12-07 17:12 ` Sam Ravnborg
2020-12-07 17:12 ` Sam Ravnborg
2020-12-07 17:12 ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 8:17 ` Thomas Zimmermann
2020-12-07 8:17 ` Thomas Zimmermann
2020-12-07 8:17 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 8:18 ` Thomas Zimmermann [this message]
2020-12-07 8:18 ` Thomas Zimmermann
2020-12-07 8:18 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 21:19 ` kernel test robot
2020-12-06 21:19 ` kernel test robot
2020-12-06 21:19 ` kernel test robot
2020-12-06 21:48 ` Sam Ravnborg
2020-12-06 21:48 ` Sam Ravnborg
2020-12-06 21:48 ` Sam Ravnborg
2020-12-06 21:49 ` Sam Ravnborg
2020-12-06 21:49 ` Sam Ravnborg
2020-12-06 21:49 ` Sam Ravnborg
2020-12-07 8:19 ` Thomas Zimmermann
2020-12-07 8:19 ` Thomas Zimmermann
2020-12-07 8:19 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 8:21 ` Thomas Zimmermann
2020-12-07 8:21 ` Thomas Zimmermann
2020-12-07 8:21 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:48 ` Thomas Zimmermann
2020-12-07 13:48 ` Thomas Zimmermann
2020-12-07 13:48 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 10/13] video: fbdev: gbefb: Fix set " Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:50 ` Thomas Zimmermann
2020-12-07 13:50 ` Thomas Zimmermann
2020-12-07 13:50 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:51 ` Thomas Zimmermann
2020-12-07 13:51 ` Thomas Zimmermann
2020-12-07 13:51 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:52 ` Thomas Zimmermann
2020-12-07 13:52 ` Thomas Zimmermann
2020-12-07 13:52 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo() Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-07 13:53 ` Thomas Zimmermann
2020-12-07 13:53 ` Thomas Zimmermann
2020-12-07 13:53 ` Thomas Zimmermann
2020-12-08 18:02 ` [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-08 18:02 ` Sam Ravnborg
2020-12-08 18:02 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b53aee5-9589-3720-f0a1-c30c390eeb2f@suse.de \
--to=tzimmermann@suse.de \
--cc=a.hajda@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dalias@libc.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=grandmaster@al2klimov.de \
--cc=gustavoars@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=sam@ravnborg.org \
--cc=spock@gentoo.org \
--cc=thierry.reding@gmail.com \
--cc=thomas@winischhofer.net \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.