* [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
@ 2020-01-19 10:08 Vitaly Lifshits
2020-01-22 6:23 ` Neftin, Sasha
2020-01-25 2:45 ` Brown, Aaron F
0 siblings, 2 replies; 5+ messages in thread
From: Vitaly Lifshits @ 2020-01-19 10:08 UTC (permalink / raw)
To: intel-wired-lan
Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
---
drivers/net/ethernet/intel/e1000e/hw.h | 1 +
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
index f556163481cb..b85210ef31d9 100644
--- a/drivers/net/ethernet/intel/e1000e/hw.h
+++ b/drivers/net/ethernet/intel/e1000e/hw.h
@@ -97,6 +97,7 @@ struct e1000_hw;
#define E1000_DEV_ID_PCH_TGP_I219_LM14 0x15F9
#define E1000_DEV_ID_PCH_TGP_I219_V14 0x15FA
#define E1000_DEV_ID_PCH_TGP_I219_LM15 0x15F4
+#define E1000_DEV_ID_PCH_TGP_I219_V15 0x15F5
#define E1000_REVISION_4 4
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 8797913b2702..3c3624f276d5 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7764,6 +7764,7 @@ static const struct pci_device_id e1000_pci_tbl[] = {
{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM14), board_pch_cnp },
{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V14), board_pch_cnp },
{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM15), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V15), board_pch_cnp },
{ 0, 0, 0, 0, 0, 0, 0 } /* terminate list */
};
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
2020-01-19 10:08 [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake Vitaly Lifshits
@ 2020-01-22 6:23 ` Neftin, Sasha
2020-01-25 2:45 ` Brown, Aaron F
1 sibling, 0 replies; 5+ messages in thread
From: Neftin, Sasha @ 2020-01-22 6:23 UTC (permalink / raw)
To: intel-wired-lan
On 1/19/2020 12:08, Vitaly Lifshits wrote:
> Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
> Platforms. This patch follows commit:
> 776f5d57ee ("e1000e: Add support for Tiger Lake").
>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/hw.h | 1 +
> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
> index f556163481cb..b85210ef31d9 100644
> --- a/drivers/net/ethernet/intel/e1000e/hw.h
> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
> @@ -97,6 +97,7 @@ struct e1000_hw;
> #define E1000_DEV_ID_PCH_TGP_I219_LM14 0x15F9
> #define E1000_DEV_ID_PCH_TGP_I219_V14 0x15FA
> #define E1000_DEV_ID_PCH_TGP_I219_LM15 0x15F4
> +#define E1000_DEV_ID_PCH_TGP_I219_V15 0x15F5
>
> #define E1000_REVISION_4 4
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 8797913b2702..3c3624f276d5 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -7764,6 +7764,7 @@ static const struct pci_device_id e1000_pci_tbl[] = {
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM14), board_pch_cnp },
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V14), board_pch_cnp },
> { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM15), board_pch_cnp },
> + { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V15), board_pch_cnp },
>
> { 0, 0, 0, 0, 0, 0, 0 } /* terminate list */
> };
>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
2020-01-19 10:08 [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake Vitaly Lifshits
2020-01-22 6:23 ` Neftin, Sasha
@ 2020-01-25 2:45 ` Brown, Aaron F
2020-01-25 12:22 ` Vitaly Lifshits
1 sibling, 1 reply; 5+ messages in thread
From: Brown, Aaron F @ 2020-01-25 2:45 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Vitaly Lifshits
> Sent: Sunday, January 19, 2020 2:08 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device
> Id of Tiger Lake
>
> Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
> Platforms. This patch follows commit:
> 776f5d57ee ("e1000e: Add support for Tiger Lake").
>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/hw.h | 1 +
> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h
> b/drivers/net/ethernet/intel/e1000e/hw.h
> index f556163481cb..b85210ef31d9 100644
> --- a/drivers/net/ethernet/intel/e1000e/hw.h
> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
> @@ -97,6 +97,7 @@ struct e1000_hw;
> #define E1000_DEV_ID_PCH_TGP_I219_LM14 0x15F9
> #define E1000_DEV_ID_PCH_TGP_I219_V14 0x15FA
> #define E1000_DEV_ID_PCH_TGP_I219_LM15 0x15F4
> +#define E1000_DEV_ID_PCH_TGP_I219_V15 0x15F5
<snip>
Something seems to be missing. After building and booting to the kernel with this patch included I do not see the 15f5 device from modinfo:
u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
u1519:[1]/usr/src/kernels/next-queue>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
2020-01-25 2:45 ` Brown, Aaron F
@ 2020-01-25 12:22 ` Vitaly Lifshits
2020-01-27 21:29 ` Brown, Aaron F
0 siblings, 1 reply; 5+ messages in thread
From: Vitaly Lifshits @ 2020-01-25 12:22 UTC (permalink / raw)
To: intel-wired-lan
On 1/25/2020 04:45, Brown, Aaron F wrote:
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>> Vitaly Lifshits
>> Sent: Sunday, January 19, 2020 2:08 AM
>> To: intel-wired-lan at lists.osuosl.org
>> Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device
>> Id of Tiger Lake
>>
>> Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
>> Platforms. This patch follows commit:
>> 776f5d57ee ("e1000e: Add support for Tiger Lake").
>>
>> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
>> ---
>> drivers/net/ethernet/intel/e1000e/hw.h | 1 +
>> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h
>> b/drivers/net/ethernet/intel/e1000e/hw.h
>> index f556163481cb..b85210ef31d9 100644
>> --- a/drivers/net/ethernet/intel/e1000e/hw.h
>> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
>> @@ -97,6 +97,7 @@ struct e1000_hw;
>> #define E1000_DEV_ID_PCH_TGP_I219_LM14 0x15F9
>> #define E1000_DEV_ID_PCH_TGP_I219_V14 0x15FA
>> #define E1000_DEV_ID_PCH_TGP_I219_LM15 0x15F4
>> +#define E1000_DEV_ID_PCH_TGP_I219_V15 0x15F5
> <snip>
>
> Something seems to be missing. After building and booting to the kernel with this patch included I do not see the 15f5 device from modinfo:
> u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
> u1519:[1]/usr/src/kernels/next-queue>
>
If I understand your test correctly, I think you should run:
> modinfo e1000e | grep -i 15f5
Since the patch is to e1000e module and not igc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
2020-01-25 12:22 ` Vitaly Lifshits
@ 2020-01-27 21:29 ` Brown, Aaron F
0 siblings, 0 replies; 5+ messages in thread
From: Brown, Aaron F @ 2020-01-27 21:29 UTC (permalink / raw)
To: intel-wired-lan
> From: Lifshits, Vitaly <vitaly.lifshits@intel.com>
> Sent: Saturday, January 25, 2020 4:22 AM
> To: Brown, Aaron F <aaron.f.brown@intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5
> Device Id of Tiger Lake
>
> On 1/25/2020 04:45, Brown, Aaron F wrote:
> >> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of
> >> Vitaly Lifshits
> >> Sent: Sunday, January 19, 2020 2:08 AM
> >> To: intel-wired-lan at lists.osuosl.org
> >> Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5
> Device
> >> Id of Tiger Lake
> >>
> >> Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
> >> Platforms. This patch follows commit:
> >> 776f5d57ee ("e1000e: Add support for Tiger Lake").
> >>
> >> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> >> ---
> >> drivers/net/ethernet/intel/e1000e/hw.h | 1 +
> >> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
> >> 2 files changed, 2 insertions(+)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> >> <snip>
> >
> > Something seems to be missing. After building and booting to the kernel
> with this patch included I do not see the 15f5 device from modinfo:
> > u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
> > u1519:[1]/usr/src/kernels/next-queue>
> >
>
> If I understand your test correctly, I think you should run:
> > modinfo e1000e | grep -i 15f5
>
> Since the patch is to e1000e module and not igc.
Yes of course, thanks. End of a long week ://)
u1459:[1]/usr/src/kernels/next-queue> modinfo e1000e | grep -i 15f5
alias: pci:v00008086d000015F5sv*sd*bc*sc*i*
u1459:[1]/usr/src/kernels/next-queue>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-27 21:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-19 10:08 [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake Vitaly Lifshits
2020-01-22 6:23 ` Neftin, Sasha
2020-01-25 2:45 ` Brown, Aaron F
2020-01-25 12:22 ` Vitaly Lifshits
2020-01-27 21:29 ` Brown, Aaron F
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.