From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] clk: mediatek: Make mtk_clk_register_composite() static
Date: Tue, 19 Apr 2022 16:45:55 +0200 [thread overview]
Message-ID: <3b622166-6d03-0e8c-8812-47e9fae6e374@collabora.com> (raw)
In-Reply-To: <20220419081246.2546159-2-wenst@chromium.org>
Il 19/04/22 10:12, Chen-Yu Tsai ha scritto:
> mtk_clk_register_composite() is not used anywhere outside of the file it
> is defined.
>
> Make it static.
>
> Fixes: 9741b1a68035 ("clk: mediatek: Add initial common clock support for Mediatek SoCs.")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Hello Chen-Yu,
I think that you should send this patch separately from the rest, as this is
just a simple cleanup that is totally unrelated to the more important conversion
that you're doing in this series.
By the way, for this one, feel free to take my
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] clk: mediatek: Make mtk_clk_register_composite() static
Date: Tue, 19 Apr 2022 16:45:55 +0200 [thread overview]
Message-ID: <3b622166-6d03-0e8c-8812-47e9fae6e374@collabora.com> (raw)
In-Reply-To: <20220419081246.2546159-2-wenst@chromium.org>
Il 19/04/22 10:12, Chen-Yu Tsai ha scritto:
> mtk_clk_register_composite() is not used anywhere outside of the file it
> is defined.
>
> Make it static.
>
> Fixes: 9741b1a68035 ("clk: mediatek: Add initial common clock support for Mediatek SoCs.")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Hello Chen-Yu,
I think that you should send this patch separately from the rest, as this is
just a simple cleanup that is totally unrelated to the more important conversion
that you're doing in this series.
By the way, for this one, feel free to take my
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] clk: mediatek: Make mtk_clk_register_composite() static
Date: Tue, 19 Apr 2022 16:45:55 +0200 [thread overview]
Message-ID: <3b622166-6d03-0e8c-8812-47e9fae6e374@collabora.com> (raw)
In-Reply-To: <20220419081246.2546159-2-wenst@chromium.org>
Il 19/04/22 10:12, Chen-Yu Tsai ha scritto:
> mtk_clk_register_composite() is not used anywhere outside of the file it
> is defined.
>
> Make it static.
>
> Fixes: 9741b1a68035 ("clk: mediatek: Add initial common clock support for Mediatek SoCs.")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Hello Chen-Yu,
I think that you should send this patch separately from the rest, as this is
just a simple cleanup that is totally unrelated to the more important conversion
that you're doing in this series.
By the way, for this one, feel free to take my
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-19 14:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 8:12 [RFC PATCH 0/7] clk: mediatek: Move to struct clk_hw provider APIs Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 1/7] clk: mediatek: Make mtk_clk_register_composite() static Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 14:45 ` AngeloGioacchino Del Regno [this message]
2022-04-19 14:45 ` AngeloGioacchino Del Regno
2022-04-19 14:45 ` AngeloGioacchino Del Regno
2022-04-19 8:12 ` [RFC PATCH 2/7] clk: mediatek: apmixed: Drop error message from clk_register() failure Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 3/7] clk: mediatek: Convert mtk_{alloc,free}_clk_data to struct clk_hw Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 3/7] clk: mediatek: Convert mtk_{alloc, free}_clk_data " Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 4/7] clk: mediatek: Replace 'struct clk' with 'struct clk_hw' Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 5/7] clk: mediatek: Switch to clk_hw provider APIs Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 6/7] clk: mediatek: mt8173: Fix usage of mtk_clk_register_ref2usb_tx() Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` [RFC PATCH 7/7] clk: mediatek: mt8173: Switch to clk_hw provider APIs Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 8:12 ` Chen-Yu Tsai
2022-04-19 15:08 ` [RFC PATCH 0/7] clk: mediatek: Move to struct " AngeloGioacchino Del Regno
2022-04-19 15:08 ` AngeloGioacchino Del Regno
2022-04-19 15:08 ` AngeloGioacchino Del Regno
2022-04-19 16:09 ` Chen-Yu Tsai
2022-04-19 16:09 ` Chen-Yu Tsai
2022-04-19 16:09 ` Chen-Yu Tsai
2022-04-20 12:02 ` AngeloGioacchino Del Regno
2022-04-20 12:02 ` AngeloGioacchino Del Regno
2022-04-20 12:02 ` AngeloGioacchino Del Regno
2022-04-21 6:05 ` Chen-Yu Tsai
2022-04-21 6:05 ` Chen-Yu Tsai
2022-04-21 6:05 ` Chen-Yu Tsai
2022-04-21 9:42 ` AngeloGioacchino Del Regno
2022-04-21 9:42 ` AngeloGioacchino Del Regno
2022-04-21 9:42 ` AngeloGioacchino Del Regno
2022-04-22 1:40 ` Stephen Boyd
2022-04-22 1:40 ` Stephen Boyd
2022-04-22 1:40 ` Stephen Boyd
2022-04-22 4:14 ` Chen-Yu Tsai
2022-04-22 4:14 ` Chen-Yu Tsai
2022-04-22 4:14 ` Chen-Yu Tsai
2022-05-03 16:28 ` Chen-Yu Tsai
2022-05-03 16:28 ` Chen-Yu Tsai
2022-05-03 16:28 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b622166-6d03-0e8c-8812-47e9fae6e374@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=rex-bc.chen@mediatek.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.