All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old
Date: Mon, 16 Dec 2019 11:46:56 +0200	[thread overview]
Message-ID: <3b79edfe-673a-9cb7-d8a0-7bf5b54748c8@intel.com> (raw)
In-Reply-To: <20191216093433.2517697-1-chris@chris-wilson.co.uk>

On 16/12/2019 11:34, Chris Wilson wrote:
> Don't flat out fail if the system doesn't support OA, just skip.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/834
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/perf.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index f5dd6051e..12f552743 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -884,11 +884,9 @@ init_sys_info(void)
>   	const char *test_set_uuid = NULL;
>   	char buf[256];
>   
> -	igt_assert_neq(devid, 0);
> -
>   	timestamp_frequency = get_cs_timestamp_frequency();
>   	igt_debug("timestamp_frequency = %lu\n", timestamp_frequency);
> -	igt_assert_neq(timestamp_frequency, 0);
> +	igt_require(timestamp_frequency);


This requires a kernel version more recent (4.16) than when perf support 
was added (4.13).

Is this what you intended?


-Lionel


>   
>   	if (IS_HASWELL(devid)) {
>   		/* We don't have a TestOa metric set for Haswell so use


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old
Date: Mon, 16 Dec 2019 11:46:56 +0200	[thread overview]
Message-ID: <3b79edfe-673a-9cb7-d8a0-7bf5b54748c8@intel.com> (raw)
In-Reply-To: <20191216093433.2517697-1-chris@chris-wilson.co.uk>

On 16/12/2019 11:34, Chris Wilson wrote:
> Don't flat out fail if the system doesn't support OA, just skip.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/834
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/perf.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index f5dd6051e..12f552743 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -884,11 +884,9 @@ init_sys_info(void)
>   	const char *test_set_uuid = NULL;
>   	char buf[256];
>   
> -	igt_assert_neq(devid, 0);
> -
>   	timestamp_frequency = get_cs_timestamp_frequency();
>   	igt_debug("timestamp_frequency = %lu\n", timestamp_frequency);
> -	igt_assert_neq(timestamp_frequency, 0);
> +	igt_require(timestamp_frequency);


This requires a kernel version more recent (4.16) than when perf support 
was added (4.13).

Is this what you intended?


-Lionel


>   
>   	if (IS_HASWELL(devid)) {
>   		/* We don't have a TestOa metric set for Haswell so use


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-12-16  9:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  9:34 [Intel-gfx] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old Chris Wilson
2019-12-16  9:34 ` [igt-dev] " Chris Wilson
2019-12-16  9:46 ` Lionel Landwerlin [this message]
2019-12-16  9:46   ` Lionel Landwerlin
2019-12-16  9:56   ` [Intel-gfx] " Chris Wilson
2019-12-16  9:56     ` Chris Wilson
2019-12-16 10:06     ` [Intel-gfx] " Lionel Landwerlin
2019-12-16 10:06       ` Lionel Landwerlin
2019-12-16 10:10       ` [Intel-gfx] " Chris Wilson
2019-12-16 10:10         ` Chris Wilson
2019-12-16 10:27       ` [Intel-gfx] " Chris Wilson
2019-12-16 10:27         ` Chris Wilson
2019-12-16 10:41         ` [Intel-gfx] " Lionel Landwerlin
2019-12-16 10:41           ` Lionel Landwerlin
2019-12-16 11:02           ` [Intel-gfx] " Chris Wilson
2019-12-16 11:02             ` Chris Wilson
2019-12-16 10:18 ` [Intel-gfx] " Lionel Landwerlin
2019-12-16 10:18   ` Lionel Landwerlin
2019-12-16 13:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-16 16:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b79edfe-673a-9cb7-d8a0-7bf5b54748c8@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.