From: Hongxu Jia <hongxu.jia@windriver.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES
Date: Tue, 4 Sep 2018 21:29:00 +0800 [thread overview]
Message-ID: <3b83ec3a-af68-928e-6fae-ef71fbca77f6@windriver.com> (raw)
In-Reply-To: <CANNYZj-4XNrwM4xEnnPrdgdobecJa3e+5RQYzoRWYYum=WRyoQ@mail.gmail.com>
On 2018年09月03日 17:54, Alexander Kanavin wrote:
> 2018-09-03 11:35 GMT+02:00 Hongxu Jia <hongxu.jia@windriver.com>:
>> They can't be built without opengl in DISTRO_FEATURES.
>> [snip]
>> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
>> fatal error: GL/gl.h: No such file or directory
>> [snip]
> Apologies, but NAK.
>
> Webkit recipe already has the necessary configuration to handle this:
>
> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
> 'x11', 'wayland' ,d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
> 'webgl opengl', '' ,d)} \
>
> PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
> PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"
>
>
> If disabling opengl does not work, then you should look closer into
> why, instead of just requiring opengl to be present always.
I am afraid whether opengl or not, it always requires virtual/libql
just like Ubuntu/Fedora does.
[Fedora webkitgtk.spec]
BuildRequires: mesa-libGL-devel
[Fedora webkitgtk.spec]
[Ubuntu debian/control]
Build-Depends: libgl1-mesa-dev [!armel !armhf !arm64]
[Ubuntu debian/control]
I tried to move `virtual/libgl' from PACKAGECONFIG to DEPENDS,
but unfortunately, the provider of `virtual/libgl' -- mesa/mesa-ql,
they require `opengl 'or `vulkan' in distro features check.
//Hongxu
> Alex
next prev parent reply other threads:[~2018-09-04 13:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 9:35 [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES Hongxu Jia
2018-09-03 9:35 ` [PATCH 2/2] weston: fix build failure with --disable-egl Hongxu Jia
2018-09-03 16:51 ` Khem Raj
2018-09-03 9:54 ` [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES Alexander Kanavin
2018-09-04 13:29 ` Hongxu Jia [this message]
2018-09-04 14:39 ` Alexander Kanavin
2018-09-03 16:51 ` Khem Raj
2018-10-09 1:49 ` ChenQi
2018-10-09 1:53 ` ChenQi
2018-10-09 1:53 ` Khem Raj
2018-10-10 3:06 ` Hongxu Jia
2018-10-10 3:09 ` [PATCH V2] " Hongxu Jia
2018-10-10 3:21 ` Andre McCurdy
2018-10-10 5:56 ` [PATCH V3] " Hongxu Jia
2018-10-10 7:16 ` [PATCH V4] webkitgtk/epiphany: " Hongxu Jia
2018-10-10 7:14 ` Hongxu Jia
2018-10-10 3:33 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev2) Patchwork
2018-10-10 6:03 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev3) Patchwork
2018-10-10 7:32 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b83ec3a-af68-928e-6fae-ef71fbca77f6@windriver.com \
--to=hongxu.jia@windriver.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.