Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Khem Raj <raj.khem@gmail.com>]

On Mon, Sep 3, 2018 at 2:35 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>

whichever source file is including OpenGLShims.h should ensure that
openGL is enabled
before including this header. you can check that with #if USE(OPENGL)
and keep in mind
that webkit has enable_opengl which means both openGL and openGLES support but
use_opengl and use_opengles are mutually exclusive. So if the
component where its failing
might be only supported with opengles2 then we need to ensure that we
check for that before
including the above header  e.g.

if !USE(OPENGL_ES_2)
 #include "OpenGLShims.h"
 #endif



> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> index a528c5d..93d74bb 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>
>  inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>
>  DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>             gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
> --
> 2.7.4
>