* [MPTCP] Re: [PATCH 5/6] mptcp: Export low-level routines for IPv6
@ 2019-10-31 8:26 Paolo Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2019-10-31 8:26 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
Hi,
On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> @@ -1111,7 +1111,8 @@ static void tcp_v6_restore_cb(struct sk_buff *skb)
> sizeof(struct inet6_skb_parm));
> }
>
> -static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
> +static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk,
> + struct sk_buff *skb,
> struct request_sock *req,
> struct dst_entry *dst,
> struct request_sock *req_unhash,
Minor nit: it looks like this chunk is not needed ?
Cheers,
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
* [MPTCP] Re: [PATCH 5/6] mptcp: Export low-level routines for IPv6
@ 2019-11-05 23:36 Peter Krystad
0 siblings, 0 replies; 2+ messages in thread
From: Peter Krystad @ 2019-11-05 23:36 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Thu, 2019-10-31 at 09:26 +0100, Paolo Abeni wrote:
> Hi,
>
> On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> > @@ -1111,7 +1111,8 @@ static void tcp_v6_restore_cb(struct sk_buff *skb)
> > sizeof(struct inet6_skb_parm));
> > }
> >
> > -static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
> > +static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk,
> > + struct sk_buff *skb,
> > struct request_sock *req,
> > struct dst_entry *dst,
> > struct request_sock *req_unhash,
>
> Minor nit: it looks like this chunk is not needed ?
It seemed like since I was in the neighborhood I would fix this over-80 char
line. If that's not appropriate we can drop this chunk.
Peter.
> Cheers,
>
> Paolo
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 8:26 [MPTCP] Re: [PATCH 5/6] mptcp: Export low-level routines for IPv6 Paolo Abeni
2019-11-05 23:36 Peter Krystad
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.