* [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support
@ 2020-07-07 21:09 Arthur She
2020-07-07 23:43 ` Anuj Mittal
0 siblings, 1 reply; 5+ messages in thread
From: Arthur She @ 2020-07-07 21:09 UTC (permalink / raw)
To: openembedded-core; +Cc: Arthur She
Chamelium is a hardware device that can be used for external display
test automation [1].
It is disabled by default and can be turned on through PACKAGECONFIG.
[1] https://www.chromium.org/chromium-os/testing/chamelium
Signed-off-by: Arthur She <arthur.she@linaro.org>
---
meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
index f60880c292..29031e64dc 100644
--- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
+++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
@@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash"
PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
-EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled"
+PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,-Dchamelium=disabled,gsl xmlrpc-c"
+
+EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled -Dchamelium=disabled"
COMPATIBLE_HOST = "(x86_64.*|i.86.*|arm.*|aarch64).*-linux"
COMPATIBLE_HOST_libc-musl_class-target = "null"
SECURITY_LDFLAGS = "${SECURITY_X_LDFLAGS}"
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support
2020-07-07 21:09 [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support Arthur She
@ 2020-07-07 23:43 ` Anuj Mittal
2020-07-08 1:01 ` Arthur She
0 siblings, 1 reply; 5+ messages in thread
From: Anuj Mittal @ 2020-07-07 23:43 UTC (permalink / raw)
To: openembedded-core, arthur.she
On Tue, 2020-07-07 at 14:09 -0700, Arthur She wrote:
> Chamelium is a hardware device that can be used for external display
> test automation [1].
> It is disabled by default and can be turned on through PACKAGECONFIG.
>
> [1] https://www.chromium.org/chromium-os/testing/chamelium
>
> Signed-off-by: Arthur She <arthur.she@linaro.org>
> ---
> meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> index f60880c292..29031e64dc 100644
> --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> @@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash"
>
> PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
>
> -EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled"
> +PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,-
> Dchamelium=disabled,gsl xmlrpc-c"
> +
> +EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled
> -Dchamelium=disabled"
This is disabling chamelium even if it's enabled using PACKAGECONFIG.
Thanks,
Anuj
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support
2020-07-07 23:43 ` Anuj Mittal
@ 2020-07-08 1:01 ` Arthur She
2020-07-09 1:29 ` Anuj Mittal
0 siblings, 1 reply; 5+ messages in thread
From: Arthur She @ 2020-07-08 1:01 UTC (permalink / raw)
To: Mittal, Anuj; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi Anuj,
Thanks for your review.
I don't need to put "-Dchamelium=disabled" in the EXTRA_OEMESON.
Because chamelium is disabled by default.
Is it correct?
Thanks,
Arthur
On Tue, Jul 7, 2020 at 4:43 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
> On Tue, 2020-07-07 at 14:09 -0700, Arthur She wrote:
> > Chamelium is a hardware device that can be used for external display
> > test automation [1].
> > It is disabled by default and can be turned on through PACKAGECONFIG.
> >
> > [1] https://www.chromium.org/chromium-os/testing/chamelium
> >
> > Signed-off-by: Arthur She <arthur.she@linaro.org>
> > ---
> > meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > index f60880c292..29031e64dc 100644
> > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > @@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash"
> >
> > PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
> >
> > -EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled"
> > +PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,-
> > Dchamelium=disabled,gsl xmlrpc-c"
> > +
> > +EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled
> > -Dchamelium=disabled"
>
> This is disabling chamelium even if it's enabled using PACKAGECONFIG.
>
> Thanks,
>
> Anuj
>
[-- Attachment #2: Type: text/html, Size: 2652 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support
2020-07-08 1:01 ` Arthur She
@ 2020-07-09 1:29 ` Anuj Mittal
2020-07-09 2:19 ` Arthur She
0 siblings, 1 reply; 5+ messages in thread
From: Anuj Mittal @ 2020-07-09 1:29 UTC (permalink / raw)
To: arthur.she; +Cc: openembedded-core
On Tue, 2020-07-07 at 18:01 -0700, Arthur She wrote:
> Hi Anuj,
> Thanks for your review.
> I don't need to put "-Dchamelium=disabled" in the EXTRA_OEMESON.
> Because chamelium is disabled by default.
> Is it correct?
Yes, since it's disabled by default, -Dchamelium=disabled is already
being passed to EXTRA_OEMESON.
In this change, if you add chamelium to PACKAGECONFIG, it will pass
both -Dchamelium=enabled and -Dchamelium=disabled to EXTRA_OEMESON
which is incorrect. It probably works for you because PACKAGECONFIG
arguments are added last ...
Thanks,
Anuj
>
> Thanks,
> Arthur
>
> On Tue, Jul 7, 2020 at 4:43 PM Mittal, Anuj <anuj.mittal@intel.com>
> wrote:
> > On Tue, 2020-07-07 at 14:09 -0700, Arthur She wrote:
> > > Chamelium is a hardware device that can be used for external
> > display
> > > test automation [1].
> > > It is disabled by default and can be turned on through
> > PACKAGECONFIG.
> > >
> > > [1] https://www.chromium.org/chromium-os/testing/chamelium
> > >
> > > Signed-off-by: Arthur She <arthur.she@linaro.org>
> > > ---
> > > meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4
> > +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-
> > tools_git.bb
> > > b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > index f60880c292..29031e64dc 100644
> > > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > @@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash"
> > >
> > > PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
> > >
> > > -EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled"
> > > +PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,-
> > > Dchamelium=disabled,gsl xmlrpc-c"
> > > +
> > > +EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled
> > > -Dchamelium=disabled"
> >
> > This is disabling chamelium even if it's enabled using
> > PACKAGECONFIG.
> >
> > Thanks,
> >
> > Anuj
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support
2020-07-09 1:29 ` Anuj Mittal
@ 2020-07-09 2:19 ` Arthur She
0 siblings, 0 replies; 5+ messages in thread
From: Arthur She @ 2020-07-09 2:19 UTC (permalink / raw)
To: Mittal, Anuj; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2354 bytes --]
Hi Anuj,
Thanks for your explanation.
I've sent patch v2 out.
Thanks,
Arthur
On Wed, Jul 8, 2020 at 6:29 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
> On Tue, 2020-07-07 at 18:01 -0700, Arthur She wrote:
> > Hi Anuj,
> > Thanks for your review.
> > I don't need to put "-Dchamelium=disabled" in the EXTRA_OEMESON.
> > Because chamelium is disabled by default.
> > Is it correct?
>
> Yes, since it's disabled by default, -Dchamelium=disabled is already
> being passed to EXTRA_OEMESON.
>
> In this change, if you add chamelium to PACKAGECONFIG, it will pass
> both -Dchamelium=enabled and -Dchamelium=disabled to EXTRA_OEMESON
> which is incorrect. It probably works for you because PACKAGECONFIG
> arguments are added last ...
>
> Thanks,
>
> Anuj
>
> >
> > Thanks,
> > Arthur
> >
> > On Tue, Jul 7, 2020 at 4:43 PM Mittal, Anuj <anuj.mittal@intel.com>
> > wrote:
> > > On Tue, 2020-07-07 at 14:09 -0700, Arthur She wrote:
> > > > Chamelium is a hardware device that can be used for external
> > > display
> > > > test automation [1].
> > > > It is disabled by default and can be turned on through
> > > PACKAGECONFIG.
> > > >
> > > > [1] https://www.chromium.org/chromium-os/testing/chamelium
> > > >
> > > > Signed-off-by: Arthur She <arthur.she@linaro.org>
> > > > ---
> > > > meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4
> > > +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-
> > > tools_git.bb
> > > > b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > > index f60880c292..29031e64dc 100644
> > > > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
> > > > @@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash"
> > > >
> > > > PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests"
> > > >
> > > > -EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled"
> > > > +PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,-
> > > > Dchamelium=disabled,gsl xmlrpc-c"
> > > > +
> > > > +EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled
> > > > -Dchamelium=disabled"
> > >
> > > This is disabling chamelium even if it's enabled using
> > > PACKAGECONFIG.
> > >
> > > Thanks,
> > >
> > > Anuj
>
[-- Attachment #2: Type: text/html, Size: 3840 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-09 2:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 21:09 [OE-core][PATCH] igt-gpu-tools: Add PACKAGECONFIG for Chamelium support Arthur She
2020-07-07 23:43 ` Anuj Mittal
2020-07-08 1:01 ` Arthur She
2020-07-09 1:29 ` Anuj Mittal
2020-07-09 2:19 ` Arthur She
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.