* [PATCH] misc: Remove redundant new line in perror()
@ 2021-07-06 9:44 Li Zhijian
2021-07-06 9:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Li Zhijian @ 2021-07-06 9:44 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, richard.henderson, dgilbert, Li Zhijian, quintela
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
migration/rdma.c | 2 +-
softmmu/cpus.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 7fb9646f6ef..e99e2e16a73 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1133,7 +1133,7 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
IBV_ACCESS_REMOTE_WRITE
);
if (!local->block[i].mr) {
- perror("Failed to register local dest ram block!\n");
+ perror("Failed to register local dest ram block!");
break;
}
rdma->total_registrations++;
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index c3caaeb26ec..071085f840b 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -325,7 +325,7 @@ static void sigbus_reraise(void)
sigaddset(&set, SIGBUS);
pthread_sigmask(SIG_UNBLOCK, &set, NULL);
}
- perror("Failed to re-raise SIGBUS!\n");
+ perror("Failed to re-raise SIGBUS!");
abort();
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: Remove redundant new line in perror()
2021-07-06 9:44 [PATCH] misc: Remove redundant new line in perror() Li Zhijian
@ 2021-07-06 9:55 ` Philippe Mathieu-Daudé
2021-07-09 9:09 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-06 9:55 UTC (permalink / raw)
To: Li Zhijian, qemu-devel
Cc: QEMU Trivial, pbonzini, richard.henderson, dgilbert, quintela
Cc'ing qemu-trivial@
On 7/6/21 11:44 AM, Li Zhijian wrote:
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> migration/rdma.c | 2 +-
> softmmu/cpus.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 7fb9646f6ef..e99e2e16a73 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -1133,7 +1133,7 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
> IBV_ACCESS_REMOTE_WRITE
> );
> if (!local->block[i].mr) {
> - perror("Failed to register local dest ram block!\n");
> + perror("Failed to register local dest ram block!");
> break;
> }
> rdma->total_registrations++;
> diff --git a/softmmu/cpus.c b/softmmu/cpus.c
> index c3caaeb26ec..071085f840b 100644
> --- a/softmmu/cpus.c
> +++ b/softmmu/cpus.c
> @@ -325,7 +325,7 @@ static void sigbus_reraise(void)
> sigaddset(&set, SIGBUS);
> pthread_sigmask(SIG_UNBLOCK, &set, NULL);
> }
> - perror("Failed to re-raise SIGBUS!\n");
> + perror("Failed to re-raise SIGBUS!");
> abort();
> }
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: Remove redundant new line in perror()
2021-07-06 9:55 ` Philippe Mathieu-Daudé
@ 2021-07-09 9:09 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-07-09 9:09 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Li Zhijian, qemu-devel
Cc: QEMU Trivial, pbonzini, richard.henderson, dgilbert, quintela
Le 06/07/2021 à 11:55, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
>
> On 7/6/21 11:44 AM, Li Zhijian wrote:
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>> migration/rdma.c | 2 +-
>> softmmu/cpus.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index 7fb9646f6ef..e99e2e16a73 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -1133,7 +1133,7 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
>> IBV_ACCESS_REMOTE_WRITE
>> );
>> if (!local->block[i].mr) {
>> - perror("Failed to register local dest ram block!\n");
>> + perror("Failed to register local dest ram block!");
>> break;
>> }
>> rdma->total_registrations++;
>> diff --git a/softmmu/cpus.c b/softmmu/cpus.c
>> index c3caaeb26ec..071085f840b 100644
>> --- a/softmmu/cpus.c
>> +++ b/softmmu/cpus.c
>> @@ -325,7 +325,7 @@ static void sigbus_reraise(void)
>> sigaddset(&set, SIGBUS);
>> pthread_sigmask(SIG_UNBLOCK, &set, NULL);
>> }
>> - perror("Failed to re-raise SIGBUS!\n");
>> + perror("Failed to re-raise SIGBUS!");
>> abort();
>> }
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-09 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 9:44 [PATCH] misc: Remove redundant new line in perror() Li Zhijian
2021-07-06 9:55 ` Philippe Mathieu-Daudé
2021-07-09 9:09 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.