All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny
@ 2022-01-22 22:33 Alejandro Hernandez Samaniego
  2022-01-24 17:38 ` [poky] " Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Alejandro Hernandez Samaniego @ 2022-01-22 22:33 UTC (permalink / raw)
  To: poky; +Cc: Alejandro Enedino Hernandez Samaniego

Fix error when trying to boot core-image-tiny-initramfs:

/init: line 144: syntax error: support for $((arith)) is disabled
Kernel panic - not syncing: Attempted to kill init!

[YOCTO #14702]

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alhe@linux.microsoft.com>
---
 meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
index b0fb88a0c1..6e9faa4119 100644
--- a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
+++ b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
@@ -1160,7 +1160,7 @@ CONFIG_CTTYHACK=y
 #
 # Options common to all shells
 #
-# CONFIG_FEATURE_SH_MATH is not set
+CONFIG_FEATURE_SH_MATH=y
 # CONFIG_FEATURE_SH_MATH_64 is not set
 # CONFIG_FEATURE_SH_MATH_BASE is not set
 CONFIG_FEATURE_SH_EXTRA_QUIET=y
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [poky] [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny
  2022-01-22 22:33 [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny Alejandro Hernandez Samaniego
@ 2022-01-24 17:38 ` Khem Raj
  2022-01-26  6:38   ` Alejandro Hernandez Samaniego
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2022-01-24 17:38 UTC (permalink / raw)
  To: Alejandro Hernandez Samaniego, poky



On 1/22/22 2:33 PM, Alejandro Hernandez Samaniego wrote:
> Fix error when trying to boot core-image-tiny-initramfs:
> 
> /init: line 144: syntax error: support for $((arith)) is disabled
> Kernel panic - not syncing: Attempted to kill init!
> 
> [YOCTO #14702]
> 
> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alhe@linux.microsoft.com>
> ---
>   meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> index b0fb88a0c1..6e9faa4119 100644
> --- a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> +++ b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> @@ -1160,7 +1160,7 @@ CONFIG_CTTYHACK=y
>   #
>   # Options common to all shells
>   #
> -# CONFIG_FEATURE_SH_MATH is not set
> +CONFIG_FEATURE_SH_MATH=y


how much does it add to binary size ?

>   # CONFIG_FEATURE_SH_MATH_64 is not set
>   # CONFIG_FEATURE_SH_MATH_BASE is not set
>   CONFIG_FEATURE_SH_EXTRA_QUIET=y
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [poky] [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny
  2022-01-24 17:38 ` [poky] " Khem Raj
@ 2022-01-26  6:38   ` Alejandro Hernandez Samaniego
  2022-01-26  6:44     ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Alejandro Hernandez Samaniego @ 2022-01-26  6:38 UTC (permalink / raw)
  To: Khem Raj; +Cc: Alejandro Hernandez Samaniego, poky

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

On Mon, 24 Jan 2022 at 17:38, Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On 1/22/22 2:33 PM, Alejandro Hernandez Samaniego wrote:
> > Fix error when trying to boot core-image-tiny-initramfs:
> >
> > /init: line 144: syntax error: support for $((arith)) is disabled
> > Kernel panic - not syncing: Attempted to kill init!
> >
> > [YOCTO #14702]
> >
> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <
> alhe@linux.microsoft.com>
> > ---
> >   meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> > index b0fb88a0c1..6e9faa4119 100644
> > --- a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> > +++ b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> > @@ -1160,7 +1160,7 @@ CONFIG_CTTYHACK=y
> >   #
> >   # Options common to all shells
> >   #
> > -# CONFIG_FEATURE_SH_MATH is not set
> > +CONFIG_FEATURE_SH_MATH=y
>
>
> Hey Khem,
This adds 12KB to the compiled binary (less than 1%) and does not reflect
on the installed binary size, its required both by the tiny-init and the
initramfs-framework which throws the same error.

Alejandro



> how much does it add to binary size ?
>
> >   # CONFIG_FEATURE_SH_MATH_64 is not set
> >   # CONFIG_FEATURE_SH_MATH_BASE is not set
> >   CONFIG_FEATURE_SH_EXTRA_QUIET=y
> >
> >
> >
> >
> >
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2675 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [poky] [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny
  2022-01-26  6:38   ` Alejandro Hernandez Samaniego
@ 2022-01-26  6:44     ` Khem Raj
  2022-01-26  6:53       ` Alejandro Hernandez Samaniego
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2022-01-26  6:44 UTC (permalink / raw)
  To: Alejandro Hernandez; +Cc: Alejandro Hernandez Samaniego, poky

On Tue, Jan 25, 2022 at 10:39 PM Alejandro Hernandez <aehs29@gmail.com> wrote:
>
>
> On Mon, 24 Jan 2022 at 17:38, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>
>>
>> On 1/22/22 2:33 PM, Alejandro Hernandez Samaniego wrote:
>> > Fix error when trying to boot core-image-tiny-initramfs:
>> >
>> > /init: line 144: syntax error: support for $((arith)) is disabled
>> > Kernel panic - not syncing: Attempted to kill init!
>> >
>> > [YOCTO #14702]
>> >
>> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <alhe@linux.microsoft.com>
>> > ---
>> >   meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig | 2 +-
>> >   1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
>> > index b0fb88a0c1..6e9faa4119 100644
>> > --- a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
>> > +++ b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
>> > @@ -1160,7 +1160,7 @@ CONFIG_CTTYHACK=y
>> >   #
>> >   # Options common to all shells
>> >   #
>> > -# CONFIG_FEATURE_SH_MATH is not set
>> > +CONFIG_FEATURE_SH_MATH=y
>>
>>
> Hey Khem,
> This adds 12KB to the compiled binary (less than 1%) and does not reflect on the installed binary size, its required both by the tiny-init and the initramfs-framework which throws the same error.

yeah perhaps using $((arith)) could be avoided in these shell scripts
but I guess it should be ok if thats too hard.

>
> Alejandro
>
>
>>
>> how much does it add to binary size ?
>>
>> >   # CONFIG_FEATURE_SH_MATH_64 is not set
>> >   # CONFIG_FEATURE_SH_MATH_BASE is not set
>> >   CONFIG_FEATURE_SH_EXTRA_QUIET=y
>> >
>> >
>> >
>> >
>> >
>>
>> 
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [poky] [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny
  2022-01-26  6:44     ` Khem Raj
@ 2022-01-26  6:53       ` Alejandro Hernandez Samaniego
  0 siblings, 0 replies; 5+ messages in thread
From: Alejandro Hernandez Samaniego @ 2022-01-26  6:53 UTC (permalink / raw)
  To: Khem Raj; +Cc: Alejandro Hernandez Samaniego, poky

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

On Wed, 26 Jan 2022 at 06:44, Khem Raj <raj.khem@gmail.com> wrote:

> On Tue, Jan 25, 2022 at 10:39 PM Alejandro Hernandez <aehs29@gmail.com>
> wrote:
> >
> >
> > On Mon, 24 Jan 2022 at 17:38, Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >>
> >>
> >> On 1/22/22 2:33 PM, Alejandro Hernandez Samaniego wrote:
> >> > Fix error when trying to boot core-image-tiny-initramfs:
> >> >
> >> > /init: line 144: syntax error: support for $((arith)) is disabled
> >> > Kernel panic - not syncing: Attempted to kill init!
> >> >
> >> > [YOCTO #14702]
> >> >
> >> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <
> alhe@linux.microsoft.com>
> >> > ---
> >> >   meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig | 2 +-
> >> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git
> a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> >> > index b0fb88a0c1..6e9faa4119 100644
> >> > --- a/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> >> > +++ b/meta-poky/recipes-core/busybox/busybox/poky-tiny/defconfig
> >> > @@ -1160,7 +1160,7 @@ CONFIG_CTTYHACK=y
> >> >   #
> >> >   # Options common to all shells
> >> >   #
> >> > -# CONFIG_FEATURE_SH_MATH is not set
> >> > +CONFIG_FEATURE_SH_MATH=y
> >>
> >>
> > Hey Khem,
> > This adds 12KB to the compiled binary (less than 1%) and does not
> reflect on the installed binary size, its required both by the tiny-init
> and the initramfs-framework which throws the same error.
>
> yeah perhaps using $((arith)) could be avoided in these shell scripts
> but I guess it should be ok if thats too hard.
>

Its true, my initial thought was to fix tiny-init but when I saw that
initramfs-framework is also
failing I thought adding it here was worth it.


> >
> > Alejandro
> >
> >
> >>
> >> how much does it add to binary size ?
> >>
> >> >   # CONFIG_FEATURE_SH_MATH_64 is not set
> >> >   # CONFIG_FEATURE_SH_MATH_BASE is not set
> >> >   CONFIG_FEATURE_SH_EXTRA_QUIET=y
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >> 
> >>
>

[-- Attachment #2: Type: text/html, Size: 3510 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-01-26  6:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 22:33 [PATCH 1/1] busybox: Add shell arithmetic to work with poky-tiny Alejandro Hernandez Samaniego
2022-01-24 17:38 ` [poky] " Khem Raj
2022-01-26  6:38   ` Alejandro Hernandez Samaniego
2022-01-26  6:44     ` Khem Raj
2022-01-26  6:53       ` Alejandro Hernandez Samaniego

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.