From: Hans de Goede <hdegoede@redhat.com> To: Lyude Paul <lyude@redhat.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: 5.6 DP-MST regression: 1 of 2 monitors on TB3 (DP-MST) dock no longer light up Date: Thu, 27 Feb 2020 19:45:37 +0100 [thread overview] Message-ID: <3bcd1280-0690-0193-31ef-36a937290cfb@redhat.com> (raw) In-Reply-To: <cd775055fc4450bba045cfbde66d45502e16162c.camel@redhat.com> Hi, On 2/27/20 7:41 PM, Lyude Paul wrote: > hi - I almost certainly know the solution to this, the patches that we got > from amd to do bandwidth checking in the DP MST helpers don't actually work > correctly in a lot of cases and I need to fix them. I've just been busy on PTO > and only just got back today, and have been busy with fixing a lot of RHEL > stuff at the same time. I'll take a closer look at this soonb Great, I'm a bit worried about the timing for getting this fixed though. We are not that far into the cycle yet, but still I have the feeling it might be better to just revert the commit triggering the probably pre-existing problems here and then queue up the necessary fixes + a new version of that commit when we have everything in place ? This way you can take your time to fix this properly instead of having to do a rush job to fix the regression before 5.6 ships. I think rushing things never is a good idea. So my vote on this goes to just reverting the commit triggering this for now and taking our time to get this right. Regards, Hans > > On Wed, 2020-02-26 at 16:15 +0100, Hans de Goede wrote: >> Hi Lyude and everyone else, >> >> Lyude I'm mailing you about this because you have done a lot of >> work on DP MST, but if this rings a bell to anyone else feel >> free to weigh in on this. >> >> I'm currently using a Lenovo X1 7th gen + a Lenovo TB3 gen 2 dock >> as my daily rider for testing purposes. When 5.6-rc1 came out I >> noticed that only 1 of the 2 1920x1080@60 monitors on the dock >> lights up. >> >> There are no kernel errors in the logs, but mutter/gnome-shell says: >> >> gnome-shell[1316]: Failed to post KMS update: Page flip of 93 failed >> >> With 93 being the crtc-id of the crtc used for the monitor which is >> displaying black. Since then I've waited for 5.6-rc3 hoping that a >> fix was already queued up, but 5.6-rc3 still has this problem. >> >> gnome-shell does behave as if all monitors are connected, so the >> monitor is seen, but we are failing to actually send any frames >> to it. >> >> I've put a log collected with drm.debug=0x104 here: >> https://fedorapeople.org/~jwrdegoede/drm-debug.log >> >> This message stands out as pointing to the likely cause of this problem: >> >> [ 3.309061] [drm:intel_dump_pipe_config [i915]] MST master transcoder: >> <invalid> >> >> Regards, >> >> Hans >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Lyude Paul <lyude@redhat.com> Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] 5.6 DP-MST regression: 1 of 2 monitors on TB3 (DP-MST) dock no longer light up Date: Thu, 27 Feb 2020 19:45:37 +0100 [thread overview] Message-ID: <3bcd1280-0690-0193-31ef-36a937290cfb@redhat.com> (raw) In-Reply-To: <cd775055fc4450bba045cfbde66d45502e16162c.camel@redhat.com> Hi, On 2/27/20 7:41 PM, Lyude Paul wrote: > hi - I almost certainly know the solution to this, the patches that we got > from amd to do bandwidth checking in the DP MST helpers don't actually work > correctly in a lot of cases and I need to fix them. I've just been busy on PTO > and only just got back today, and have been busy with fixing a lot of RHEL > stuff at the same time. I'll take a closer look at this soonb Great, I'm a bit worried about the timing for getting this fixed though. We are not that far into the cycle yet, but still I have the feeling it might be better to just revert the commit triggering the probably pre-existing problems here and then queue up the necessary fixes + a new version of that commit when we have everything in place ? This way you can take your time to fix this properly instead of having to do a rush job to fix the regression before 5.6 ships. I think rushing things never is a good idea. So my vote on this goes to just reverting the commit triggering this for now and taking our time to get this right. Regards, Hans > > On Wed, 2020-02-26 at 16:15 +0100, Hans de Goede wrote: >> Hi Lyude and everyone else, >> >> Lyude I'm mailing you about this because you have done a lot of >> work on DP MST, but if this rings a bell to anyone else feel >> free to weigh in on this. >> >> I'm currently using a Lenovo X1 7th gen + a Lenovo TB3 gen 2 dock >> as my daily rider for testing purposes. When 5.6-rc1 came out I >> noticed that only 1 of the 2 1920x1080@60 monitors on the dock >> lights up. >> >> There are no kernel errors in the logs, but mutter/gnome-shell says: >> >> gnome-shell[1316]: Failed to post KMS update: Page flip of 93 failed >> >> With 93 being the crtc-id of the crtc used for the monitor which is >> displaying black. Since then I've waited for 5.6-rc3 hoping that a >> fix was already queued up, but 5.6-rc3 still has this problem. >> >> gnome-shell does behave as if all monitors are connected, so the >> monitor is seen, but we are failing to actually send any frames >> to it. >> >> I've put a log collected with drm.debug=0x104 here: >> https://fedorapeople.org/~jwrdegoede/drm-debug.log >> >> This message stands out as pointing to the likely cause of this problem: >> >> [ 3.309061] [drm:intel_dump_pipe_config [i915]] MST master transcoder: >> <invalid> >> >> Regards, >> >> Hans >> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-27 18:45 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-26 15:15 5.6 DP-MST regression: 1 of 2 monitors on TB3 (DP-MST) dock no longer light up Hans de Goede 2020-02-26 15:15 ` [Intel-gfx] " Hans de Goede 2020-02-26 15:29 ` Alex Deucher 2020-02-26 15:29 ` [Intel-gfx] " Alex Deucher 2020-02-26 15:43 ` Hans de Goede 2020-02-26 15:43 ` [Intel-gfx] " Hans de Goede 2020-02-26 16:05 ` Alex Deucher 2020-02-26 16:05 ` [Intel-gfx] " Alex Deucher 2020-02-26 17:52 ` Hans de Goede 2020-02-26 17:52 ` [Intel-gfx] " Hans de Goede 2020-02-26 23:41 ` Souza, Jose 2020-02-26 23:41 ` [Intel-gfx] " Souza, Jose 2020-02-27 15:04 ` Mikita Lipski 2020-02-27 18:42 ` Lyude Paul 2020-02-27 18:42 ` [Intel-gfx] " Lyude Paul 2020-03-06 23:54 ` Lyude Paul 2020-03-06 23:54 ` [Intel-gfx] " Lyude Paul 2020-03-07 12:09 ` Hans de Goede 2020-03-07 12:09 ` [Intel-gfx] " Hans de Goede 2020-02-27 18:41 ` Lyude Paul 2020-02-27 18:41 ` [Intel-gfx] " Lyude Paul 2020-02-27 18:45 ` Hans de Goede [this message] 2020-02-27 18:45 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3bcd1280-0690-0193-31ef-36a937290cfb@redhat.com \ --to=hdegoede@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=lyude@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.