* [MPTCP] Re: [PATCH mptcp-next] Squash-to: "mptcp: implement delegated actions"
@ 2021-01-19 12:28 Paolo Abeni
0 siblings, 0 replies; only message in thread
From: Paolo Abeni @ 2021-01-19 12:28 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Tue, 2021-01-19 at 13:15 +0100, Paolo Abeni wrote:
> Many issues in the reference patch:
>
> - mptcp_subflow_has_delegated_action() tested the wrong condition,
> fix it - things did not break hard too much, because usually
> mptcp_napi_poll() kicked in and processed the pending action
> without any sanity check
>
> - subflow->delegated_node/mptcp_delegated_action->head is
> touched/modified by the subflow release callback, which is
> helding the local BH, but can run on a CPU other then the
> one that originally scheduled the delegated action. That
> would cause list corruption. Clarify the locking schema in
> the header file and touch the node only in mptcp_delegated_action
> poll, which is always running on the relevant CPU (unless
> the whole net is broken hard [which is currently apparently
> the case]).
This is still buggy, it will need a v2. Sorry for the noise.
/P
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-19 12:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 12:28 [MPTCP] Re: [PATCH mptcp-next] Squash-to: "mptcp: implement delegated actions" Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.