* [PATCH] drm/amdgpu: Fix VRAM eviction issue
@ 2022-09-22 15:14 Arunpravin Paneer Selvam
2022-09-22 15:31 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Arunpravin Paneer Selvam @ 2022-09-22 15:14 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, christian.koenig, Arunpravin Paneer Selvam
A user reported that when he starts a game (MTGA) with wine,
he observed an error msg failed to pin framebuffer with error -12.
Found an issue with the VRAM mem type eviction decision condition
logic. This patch will fix the if condition code error.
Gitlab bug link:
https://gitlab.freedesktop.org/drm/amd/-/issues/2159
Fixes: ded910f368a5 ("drm/amdgpu: Implement intersect/compatible functions")
Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
index d1a2619fa89f..73a517bcf5c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
@@ -746,7 +746,7 @@ static bool amdgpu_vram_mgr_intersects(struct ttm_resource_manager *man,
(amdgpu_vram_mgr_block_size(block) >> PAGE_SHIFT);
if (place->fpfn < lpfn &&
- (place->lpfn && place->lpfn > fpfn))
+ (!place->lpfn || place->lpfn > fpfn))
return true;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue
2022-09-22 15:14 [PATCH] drm/amdgpu: Fix VRAM eviction issue Arunpravin Paneer Selvam
@ 2022-09-22 15:31 ` Christian König
2022-09-22 15:42 ` Arunpravin Paneer Selvam
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2022-09-22 15:31 UTC (permalink / raw)
To: Arunpravin Paneer Selvam, amd-gfx; +Cc: alexander.deucher
Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam:
> A user reported that when he starts a game (MTGA) with wine,
> he observed an error msg failed to pin framebuffer with error -12.
> Found an issue with the VRAM mem type eviction decision condition
> logic. This patch will fix the if condition code error.
>
> Gitlab bug link:
> https://gitlab.freedesktop.org/drm/amd/-/issues/2159
>
> Fixes: ded910f368a5 ("drm/amdgpu: Implement intersect/compatible functions")
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Can you push it yourself now?
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> index d1a2619fa89f..73a517bcf5c1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> @@ -746,7 +746,7 @@ static bool amdgpu_vram_mgr_intersects(struct ttm_resource_manager *man,
> (amdgpu_vram_mgr_block_size(block) >> PAGE_SHIFT);
>
> if (place->fpfn < lpfn &&
> - (place->lpfn && place->lpfn > fpfn))
> + (!place->lpfn || place->lpfn > fpfn))
> return true;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue
2022-09-22 15:31 ` Christian König
@ 2022-09-22 15:42 ` Arunpravin Paneer Selvam
2022-09-22 17:54 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Arunpravin Paneer Selvam @ 2022-09-22 15:42 UTC (permalink / raw)
To: Christian König, amd-gfx; +Cc: alexander.deucher
On 9/22/2022 9:01 PM, Christian König wrote:
> Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam:
>> A user reported that when he starts a game (MTGA) with wine,
>> he observed an error msg failed to pin framebuffer with error -12.
>> Found an issue with the VRAM mem type eviction decision condition
>> logic. This patch will fix the if condition code error.
>>
>> Gitlab bug link:
>> https://gitlab.freedesktop.org/drm/amd/-/issues/2159
>>
>> Fixes: ded910f368a5 ("drm/amdgpu: Implement intersect/compatible
>> functions")
>> Signed-off-by: Arunpravin Paneer Selvam
>> <Arunpravin.PaneerSelvam@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Can you push it yourself now?
No, I didn't get the commit rights yet.
Thanks,
Arun
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> index d1a2619fa89f..73a517bcf5c1 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> @@ -746,7 +746,7 @@ static bool amdgpu_vram_mgr_intersects(struct
>> ttm_resource_manager *man,
>> (amdgpu_vram_mgr_block_size(block) >> PAGE_SHIFT);
>> if (place->fpfn < lpfn &&
>> - (place->lpfn && place->lpfn > fpfn))
>> + (!place->lpfn || place->lpfn > fpfn))
>> return true;
>> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue
2022-09-22 15:42 ` Arunpravin Paneer Selvam
@ 2022-09-22 17:54 ` Christian König
2022-09-23 6:18 ` Arunpravin Paneer Selvam
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2022-09-22 17:54 UTC (permalink / raw)
To: Arunpravin Paneer Selvam, Christian König, amd-gfx; +Cc: alexander.deucher
Am 22.09.22 um 17:42 schrieb Arunpravin Paneer Selvam:
>
>
> On 9/22/2022 9:01 PM, Christian König wrote:
>> Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam:
>>> A user reported that when he starts a game (MTGA) with wine,
>>> he observed an error msg failed to pin framebuffer with error -12.
>>> Found an issue with the VRAM mem type eviction decision condition
>>> logic. This patch will fix the if condition code error.
>>>
>>> Gitlab bug link:
>>> https://gitlab.freedesktop.org/drm/amd/-/issues/2159
>>>
>>> Fixes: ded910f368a5 ("drm/amdgpu: Implement intersect/compatible
>>> functions")
>>> Signed-off-by: Arunpravin Paneer Selvam
>>> <Arunpravin.PaneerSelvam@amd.com>
>>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Can you push it yourself now?
> No, I didn't get the commit rights yet.
Pushed to drm-misc-next. Please make sure the bug is closed.
Thanks,
Christian.
>
> Thanks,
> Arun
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>> index d1a2619fa89f..73a517bcf5c1 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>> @@ -746,7 +746,7 @@ static bool amdgpu_vram_mgr_intersects(struct
>>> ttm_resource_manager *man,
>>> (amdgpu_vram_mgr_block_size(block) >> PAGE_SHIFT);
>>> if (place->fpfn < lpfn &&
>>> - (place->lpfn && place->lpfn > fpfn))
>>> + (!place->lpfn || place->lpfn > fpfn))
>>> return true;
>>> }
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix VRAM eviction issue
2022-09-22 17:54 ` Christian König
@ 2022-09-23 6:18 ` Arunpravin Paneer Selvam
0 siblings, 0 replies; 5+ messages in thread
From: Arunpravin Paneer Selvam @ 2022-09-23 6:18 UTC (permalink / raw)
To: Christian König, Christian König, amd-gfx; +Cc: alexander.deucher
On 9/22/2022 11:24 PM, Christian König wrote:
>
>
> Am 22.09.22 um 17:42 schrieb Arunpravin Paneer Selvam:
>>
>>
>> On 9/22/2022 9:01 PM, Christian König wrote:
>>> Am 22.09.22 um 17:14 schrieb Arunpravin Paneer Selvam:
>>>> A user reported that when he starts a game (MTGA) with wine,
>>>> he observed an error msg failed to pin framebuffer with error -12.
>>>> Found an issue with the VRAM mem type eviction decision condition
>>>> logic. This patch will fix the if condition code error.
>>>>
>>>> Gitlab bug link:
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F2159&data=05%7C01%7Carunpravin.paneerselvam%40amd.com%7C4596e95ab9b040a4ef6d08da9cc37678%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637994660587287984%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=E%2Ba1wm6TN4eb3IB6Fg5zWA7gGAxE05U2c%2FZ3lX5hCKc%3D&reserved=0
>>>>
>>>>
>>>> Fixes: ded910f368a5 ("drm/amdgpu: Implement intersect/compatible
>>>> functions")
>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>
>>> Can you push it yourself now?
>> No, I didn't get the commit rights yet.
>
> Pushed to drm-misc-next. Please make sure the bug is closed.
Thanks, I will comment to close the bug.
>
> Thanks,
> Christian.
>
>>
>> Thanks,
>> Arun
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>>> index d1a2619fa89f..73a517bcf5c1 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>>>> @@ -746,7 +746,7 @@ static bool amdgpu_vram_mgr_intersects(struct
>>>> ttm_resource_manager *man,
>>>> (amdgpu_vram_mgr_block_size(block) >> PAGE_SHIFT);
>>>> if (place->fpfn < lpfn &&
>>>> - (place->lpfn && place->lpfn > fpfn))
>>>> + (!place->lpfn || place->lpfn > fpfn))
>>>> return true;
>>>> }
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-23 6:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 15:14 [PATCH] drm/amdgpu: Fix VRAM eviction issue Arunpravin Paneer Selvam
2022-09-22 15:31 ` Christian König
2022-09-22 15:42 ` Arunpravin Paneer Selvam
2022-09-22 17:54 ` Christian König
2022-09-23 6:18 ` Arunpravin Paneer Selvam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.