All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
@ 2018-11-19 16:45 Guillaume GARDET
  2018-11-19 16:46 ` Tom Rini
  0 siblings, 1 reply; 15+ messages in thread
From: Guillaume GARDET @ 2018-11-19 16:45 UTC (permalink / raw)
  To: u-boot

This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is 
now bigger than 512K with GCC8.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>

Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Tom Rini <trini@konsulko.com>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/exynos5-common.h b/include/configs/exynos5-common.h
index cd2a9046af..7da4be5ca8 100644
--- a/include/configs/exynos5-common.h
+++ b/include/configs/exynos5-common.h
@@ -89,7 +89,7 @@
 /* Configuration of BL1, BL2, ENV Blocks on mmc */
 #define CONFIG_RES_BLOCK_SIZE	(512)
 #define CONFIG_BL1_SIZE	(16 << 10) /*16 K reserved for BL1*/
-#define CONFIG_BL2_SIZE	(512UL << 10UL) /* 512 KB */
+#define CONFIG_BL2_SIZE	(512UL << 11UL) /* 1 MB */
 #define CONFIG_ENV_SIZE	(16 << 10) /* 16 KB */
 
 #define CONFIG_BL1_OFFSET	(CONFIG_RES_BLOCK_SIZE + CONFIG_SEC_FW_SIZE)
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
  2018-11-19 16:45 [U-Boot] [PATCH] exynos5: allow bigger BL2 (u-boot.bin) Guillaume GARDET
@ 2018-11-19 16:46 ` Tom Rini
  2018-11-19 16:56   ` [U-Boot] Re : " Guillaume GARDET
  0 siblings, 1 reply; 15+ messages in thread
From: Tom Rini @ 2018-11-19 16:46 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:

> This patch allows SPL to load a bigger BL2 (u-boot.bin).
> This is needed for and has been tested on Arndale board, as u-boot.bin is 
> now bigger than 512K with GCC8.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> 
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  include/configs/exynos5-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Are these platforms using thumb2 to build?  Were it not for some early
Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
global switch to making that option default.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/41215b46/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re: [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
  2018-11-19 16:46 ` Tom Rini
@ 2018-11-19 16:56   ` Guillaume GARDET
  2018-11-19 16:57     ` Tom Rini
  0 siblings, 1 reply; 15+ messages in thread
From: Guillaume GARDET @ 2018-11-19 16:56 UTC (permalink / raw)
  To: u-boot


----- Tom Rini <trini@konsulko.com> a écrit :
> On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:
> 
> > This patch allows SPL to load a bigger BL2 (u-boot.bin).
> > This is needed for and has been tested on Arndale board, as u-boot.bin is 
> > now bigger than 512K with GCC8.
> > 
> > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > 
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > Cc: Tom Rini <trini@konsulko.com>
> > ---
> >  include/configs/exynos5-common.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Are these platforms using thumb2 to build?  Were it not for some early
> Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
> global switch to making that option default.

No, they are not using thumb2:
# CONFIG_SYS_THUMB_BUILD is not set
# CONFIG_SPL_SYS_THUMB_BUILD is not set


Guillaume

> 
> -- 
> Tom

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re: [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
  2018-11-19 16:56   ` [U-Boot] Re : " Guillaume GARDET
@ 2018-11-19 16:57     ` Tom Rini
  2018-11-19 17:03       ` [U-Boot] Re : " Guillaume GARDET
  0 siblings, 1 reply; 15+ messages in thread
From: Tom Rini @ 2018-11-19 16:57 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 19, 2018 at 05:56:37PM +0100, Guillaume GARDET wrote:
> 
> ----- Tom Rini <trini@konsulko.com> a écrit :
> > On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:
> > 
> > > This patch allows SPL to load a bigger BL2 (u-boot.bin).
> > > This is needed for and has been tested on Arndale board, as u-boot.bin is 
> > > now bigger than 512K with GCC8.
> > > 
> > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > 
> > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > Cc: Tom Rini <trini@konsulko.com>
> > > ---
> > >  include/configs/exynos5-common.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Are these platforms using thumb2 to build?  Were it not for some early
> > Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
> > global switch to making that option default.
> 
> No, they are not using thumb2:
> # CONFIG_SYS_THUMB_BUILD is not set
> # CONFIG_SPL_SYS_THUMB_BUILD is not set

I would suggest switching that on instead then.  I'm always wary of
changing stuff on the flash layout.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/b5acf675/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re: Re : Re: [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
  2018-11-19 16:57     ` Tom Rini
@ 2018-11-19 17:03       ` Guillaume GARDET
  2018-11-19 17:18         ` Tom Rini
  0 siblings, 1 reply; 15+ messages in thread
From: Guillaume GARDET @ 2018-11-19 17:03 UTC (permalink / raw)
  To: u-boot


----- Tom Rini <trini@konsulko.com> a écrit :
> On Mon, Nov 19, 2018 at 05:56:37PM +0100, Guillaume GARDET wrote:
> > 
> > ----- Tom Rini <trini@konsulko.com> a écrit :
> > > On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:
> > > 
> > > > This patch allows SPL to load a bigger BL2 (u-boot.bin).
> > > > This is needed for and has been tested on Arndale board, as u-boot.bin is 
> > > > now bigger than 512K with GCC8.
> > > > 
> > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > > 
> > > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > > Cc: Tom Rini <trini@konsulko.com>
> > > > ---
> > > >  include/configs/exynos5-common.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > Are these platforms using thumb2 to build?  Were it not for some early
> > > Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
> > > global switch to making that option default.
> > 
> > No, they are not using thumb2:
> > # CONFIG_SYS_THUMB_BUILD is not set
> > # CONFIG_SPL_SYS_THUMB_BUILD is not set
> 
> I would suggest switching that on instead then.  I'm always wary of
> changing stuff on the flash layout.

I tested thumb2 for SPL and u-boot.bin on arndale and it does boot properly.
u-boot.bin is 397KB with thumb2, which is OK.

Should I make the switch for Arndale board only, or on a bigger range?

Guillaume

> 
> -- 
> Tom

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re: Re : Re: [PATCH] exynos5: allow bigger BL2 (u-boot.bin)
  2018-11-19 17:03       ` [U-Boot] Re : " Guillaume GARDET
@ 2018-11-19 17:18         ` Tom Rini
  2018-11-20 13:15           ` [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD Guillaume GARDET
  0 siblings, 1 reply; 15+ messages in thread
From: Tom Rini @ 2018-11-19 17:18 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 19, 2018 at 06:03:45PM +0100, Guillaume GARDET wrote:
 
> ----- Tom Rini <trini@konsulko.com> a écrit :
> > On Mon, Nov 19, 2018 at 05:56:37PM +0100, Guillaume GARDET wrote:
> > > 
> > > ----- Tom Rini <trini@konsulko.com> a écrit :
> > > > On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:
> > > > 
> > > > > This patch allows SPL to load a bigger BL2 (u-boot.bin).
> > > > > This is needed for and has been tested on Arndale board, as u-boot.bin is 
> > > > > now bigger than 512K with GCC8.
> > > > > 
> > > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > > > 
> > > > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > > > Cc: Tom Rini <trini@konsulko.com>
> > > > > ---
> > > > >  include/configs/exynos5-common.h | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > Are these platforms using thumb2 to build?  Were it not for some early
> > > > Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
> > > > global switch to making that option default.
> > > 
> > > No, they are not using thumb2:
> > > # CONFIG_SYS_THUMB_BUILD is not set
> > > # CONFIG_SPL_SYS_THUMB_BUILD is not set
> > 
> > I would suggest switching that on instead then.  I'm always wary of
> > changing stuff on the flash layout.
> 
> I tested thumb2 for SPL and u-boot.bin on arndale and it does boot properly.
> u-boot.bin is 397KB with thumb2, which is OK.
> 
> Should I make the switch for Arndale board only, or on a bigger range?

I'd go ahead and switch all exynos platforms.  My recollection is it's
really only very old / early Cortex-A platforms with issues and I'm
pretty sure we either have the appropriate errata enabled or they've all
been discarded at this point in time.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/2d89500b/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-11-19 17:18         ` Tom Rini
@ 2018-11-20 13:15           ` Guillaume GARDET
  2018-11-26 23:32             ` Lukasz Majewski
  0 siblings, 1 reply; 15+ messages in thread
From: Guillaume GARDET @ 2018-11-20 13:15 UTC (permalink / raw)
  To: u-boot

This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is
now bigger than the 512K load limit, with GCC8, without thumb mode.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>

Cc: Albert Aribaud <albert.u.boot@aribaud.net>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Tom Rini <trini@konsulko.com>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index f5d4d39683..1ccd53fd0b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-11-20 13:15           ` [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD Guillaume GARDET
@ 2018-11-26 23:32             ` Lukasz Majewski
  2018-12-03 19:57               ` [U-Boot] Re : " Guillaume GARDET
  0 siblings, 1 reply; 15+ messages in thread
From: Lukasz Majewski @ 2018-11-26 23:32 UTC (permalink / raw)
  To: u-boot

Hi Guillaume,

> This patch allows smaller binaries.
> This is needed for and has been tested on Arndale board, as
> u-boot.bin is now bigger than the 512K load limit, with GCC8, without
> thumb mode.
> 

Acked-by: Lukasz Majewski <lukma@denx.de>

> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> 
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f5d4d39683..1ccd53fd0b 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -607,6 +607,7 @@ config ARCH_EXYNOS
>  	select DM_SPI
>  	select DM_SPI_FLASH
>  	select SPI
> +	imply SYS_THUMB_BUILD
>  	imply CMD_DM
>  	imply FAT_WRITE
>  




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181127/6be480c3/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-11-26 23:32             ` Lukasz Majewski
@ 2018-12-03 19:57               ` Guillaume GARDET
  2018-12-03 20:23                 ` Tom Rini
  2018-12-03 22:07                 ` [U-Boot] " Lukasz Majewski
  0 siblings, 2 replies; 15+ messages in thread
From: Guillaume GARDET @ 2018-12-03 19:57 UTC (permalink / raw)
  To: u-boot


Hi,

not sure through which tree it should go and who should take care of it?

Guillaume

----- Lukasz Majewski <lukma@denx.de> a écrit :
> Hi Guillaume,
> 
> > This patch allows smaller binaries.
> > This is needed for and has been tested on Arndale board, as
> > u-boot.bin is now bigger than the 512K load limit, with GCC8, without
> > thumb mode.
> > 
> 
> Acked-by: Lukasz Majewski <lukma@denx.de>
> 
> > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > 
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > Cc: Tom Rini <trini@konsulko.com>
> > ---
> >  arch/arm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index f5d4d39683..1ccd53fd0b 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -607,6 +607,7 @@ config ARCH_EXYNOS
> >  	select DM_SPI
> >  	select DM_SPI_FLASH
> >  	select SPI
> > +	imply SYS_THUMB_BUILD
> >  	imply CMD_DM
> >  	imply FAT_WRITE
> >  
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-03 19:57               ` [U-Boot] Re : " Guillaume GARDET
@ 2018-12-03 20:23                 ` Tom Rini
  2018-12-04  4:47                   ` Minkyu Kang
  2018-12-03 22:07                 ` [U-Boot] " Lukasz Majewski
  1 sibling, 1 reply; 15+ messages in thread
From: Tom Rini @ 2018-12-03 20:23 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote:

> 
> Hi,
> 
> not sure through which tree it should go and who should take care of it?

I will likely pick this up "soon" if I don't seen an overall Samsung PR,
thanks!

> 
> Guillaume
> 
> ----- Lukasz Majewski <lukma@denx.de> a écrit :
> > Hi Guillaume,
> > 
> > > This patch allows smaller binaries.
> > > This is needed for and has been tested on Arndale board, as
> > > u-boot.bin is now bigger than the 512K load limit, with GCC8, without
> > > thumb mode.
> > > 
> > 
> > Acked-by: Lukasz Majewski <lukma@denx.de>
> > 
> > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > 
> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > Cc: Tom Rini <trini@konsulko.com>
> > > ---
> > >  arch/arm/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > index f5d4d39683..1ccd53fd0b 100644
> > > --- a/arch/arm/Kconfig
> > > +++ b/arch/arm/Kconfig
> > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS
> > >  	select DM_SPI
> > >  	select DM_SPI_FLASH
> > >  	select SPI
> > > +	imply SYS_THUMB_BUILD
> > >  	imply CMD_DM
> > >  	imply FAT_WRITE
> > >  
> > 
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
> 

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/72c8a2ac/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-03 19:57               ` [U-Boot] Re : " Guillaume GARDET
  2018-12-03 20:23                 ` Tom Rini
@ 2018-12-03 22:07                 ` Lukasz Majewski
  2018-12-04  7:57                   ` [U-Boot] Re : " Guillaume GARDET
  1 sibling, 1 reply; 15+ messages in thread
From: Lukasz Majewski @ 2018-12-03 22:07 UTC (permalink / raw)
  To: u-boot

Hi Guillaume,

> Hi,
> 
> not sure through which tree it should go and who should take care of
> it?

Please rebase on top of u-boot/master branch.

Then Minkyu will take the patch to his tree.

> 
> Guillaume
> 
> ----- Lukasz Majewski <lukma@denx.de> a écrit :
> > Hi Guillaume,
> >   
> > > This patch allows smaller binaries.
> > > This is needed for and has been tested on Arndale board, as
> > > u-boot.bin is now bigger than the 512K load limit, with GCC8,
> > > without thumb mode.
> > >   
> > 
> > Acked-by: Lukasz Majewski <lukma@denx.de>
> >   
> > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > 
> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > Cc: Tom Rini <trini@konsulko.com>
> > > ---
> > >  arch/arm/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > index f5d4d39683..1ccd53fd0b 100644
> > > --- a/arch/arm/Kconfig
> > > +++ b/arch/arm/Kconfig
> > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS
> > >  	select DM_SPI
> > >  	select DM_SPI_FLASH
> > >  	select SPI
> > > +	imply SYS_THUMB_BUILD
> > >  	imply CMD_DM
> > >  	imply FAT_WRITE
> > >    
> > 
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma at denx.de  
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/9e4430a3/attachment.sig>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-03 20:23                 ` Tom Rini
@ 2018-12-04  4:47                   ` Minkyu Kang
  2018-12-21 13:57                     ` Guillaume Gardet
  0 siblings, 1 reply; 15+ messages in thread
From: Minkyu Kang @ 2018-12-04  4:47 UTC (permalink / raw)
  To: u-boot

Dear Tom,

On 04/12/18 05:23, Tom Rini wrote:
> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote:
> 
>>
>> Hi,
>>
>> not sure through which tree it should go and who should take care of it?
> 
> I will likely pick this up "soon" if I don't seen an overall Samsung PR,
> thanks!
> 

It's OK to take this patch by you.

Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Thanks,
Minkyu Kang.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-03 22:07                 ` [U-Boot] " Lukasz Majewski
@ 2018-12-04  7:57                   ` Guillaume GARDET
  0 siblings, 0 replies; 15+ messages in thread
From: Guillaume GARDET @ 2018-12-04  7:57 UTC (permalink / raw)
  To: u-boot


----- Lukasz Majewski <lukma@denx.de> a écrit :
> Hi Guillaume,
> 
> > Hi,
> > 
> > not sure through which tree it should go and who should take care of
> > it?
> 
> Please rebase on top of u-boot/master branch.

No need, it applies just fine.

> 
> Then Minkyu will take the patch to his tree.

Tom should take it (see Minkyu e-mail).

Thanks,
Guillaume

> 
> > 
> > Guillaume
> > 
> > ----- Lukasz Majewski <lukma@denx.de> a écrit :
> > > Hi Guillaume,
> > >   
> > > > This patch allows smaller binaries.
> > > > This is needed for and has been tested on Arndale board, as
> > > > u-boot.bin is now bigger than the 512K load limit, with GCC8,
> > > > without thumb mode.
> > > >   
> > > 
> > > Acked-by: Lukasz Majewski <lukma@denx.de>
> > >   
> > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> > > > 
> > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > > Cc: Tom Rini <trini@konsulko.com>
> > > > ---
> > > >  arch/arm/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > > index f5d4d39683..1ccd53fd0b 100644
> > > > --- a/arch/arm/Kconfig
> > > > +++ b/arch/arm/Kconfig
> > > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS
> > > >  	select DM_SPI
> > > >  	select DM_SPI_FLASH
> > > >  	select SPI
> > > > +	imply SYS_THUMB_BUILD
> > > >  	imply CMD_DM
> > > >  	imply FAT_WRITE
> > > >    
> > > 
> > > 
> > > 
> > > 
> > > Best regards,
> > > 
> > > Lukasz Majewski
> > > 
> > > --
> > > 
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > > lukma at denx.de  
> > 
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-04  4:47                   ` Minkyu Kang
@ 2018-12-21 13:57                     ` Guillaume Gardet
  2018-12-27  0:47                       ` Minkyu Kang
  0 siblings, 1 reply; 15+ messages in thread
From: Guillaume Gardet @ 2018-12-21 13:57 UTC (permalink / raw)
  To: u-boot

Hi Tom,

Le 04/12/2018 à 05:47, Minkyu Kang a écrit :
> Dear Tom,
>
> On 04/12/18 05:23, Tom Rini wrote:
>> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote:
>>
>>> Hi,
>>>
>>> not sure through which tree it should go and who should take care of it?
>> I will likely pick this up "soon" if I don't seen an overall Samsung PR,
>> thanks!
>>
> It's OK to take this patch by you.
>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>


It seems you missed it for -rc2. Could you take it before the release, please?

Thanks,

Guillaume


>
> Thanks,
> Minkyu Kang.
>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [U-Boot] Re : Re:  [PATCH] exynos: imply SYS_THUMB_BUILD
  2018-12-21 13:57                     ` Guillaume Gardet
@ 2018-12-27  0:47                       ` Minkyu Kang
  0 siblings, 0 replies; 15+ messages in thread
From: Minkyu Kang @ 2018-12-27  0:47 UTC (permalink / raw)
  To: u-boot

Hi,

On 21/12/18 22:57, Guillaume Gardet wrote:
> Hi Tom,
> 
> Le 04/12/2018 à 05:47, Minkyu Kang a écrit :
>> Dear Tom,
>>
>> On 04/12/18 05:23, Tom Rini wrote:
>>> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote:
>>>
>>>> Hi,
>>>>
>>>> not sure through which tree it should go and who should take care of it?
>>> I will likely pick this up "soon" if I don't seen an overall Samsung PR,
>>> thanks!
>>>
>> It's OK to take this patch by you.
>>
>> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> 
> 
> It seems you missed it for -rc2. Could you take it before the release, please?
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-12-27  0:47 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 16:45 [U-Boot] [PATCH] exynos5: allow bigger BL2 (u-boot.bin) Guillaume GARDET
2018-11-19 16:46 ` Tom Rini
2018-11-19 16:56   ` [U-Boot] Re : " Guillaume GARDET
2018-11-19 16:57     ` Tom Rini
2018-11-19 17:03       ` [U-Boot] Re : " Guillaume GARDET
2018-11-19 17:18         ` Tom Rini
2018-11-20 13:15           ` [U-Boot] [PATCH] exynos: imply SYS_THUMB_BUILD Guillaume GARDET
2018-11-26 23:32             ` Lukasz Majewski
2018-12-03 19:57               ` [U-Boot] Re : " Guillaume GARDET
2018-12-03 20:23                 ` Tom Rini
2018-12-04  4:47                   ` Minkyu Kang
2018-12-21 13:57                     ` Guillaume Gardet
2018-12-27  0:47                       ` Minkyu Kang
2018-12-03 22:07                 ` [U-Boot] " Lukasz Majewski
2018-12-04  7:57                   ` [U-Boot] Re : " Guillaume GARDET

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.