From: Gregor Boirie <gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> To: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>, Tomasz Duszynski <tduszyns-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Daniel Baluta <daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Gregor Boirie <gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> Subject: [PATCH v4 1/3] iio:pressure:ms5611: fix oops when probing regulator Date: Tue, 1 Mar 2016 11:31:36 +0100 [thread overview] Message-ID: <3c096730728684f1ce127602179c3ba73cd66cb4.1456828051.git.gregor.boirie@parrot.com> (raw) In-Reply-To: <cover.1456828051.git.gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> When not compiled-in, regulator layer will return a NULL pointer when trying to get a reference to any regulator using devm_regulator_get(). As IS_ERR() does not consider this an error, the ms5611 probing operation will try to enable a NULL regulator, which will invariably cause a kernel crash. This patch fixes this situation by using devm_regulator_get_optional() instead of devm_regulator_get(). Signed-off-by: Gregor Boirie <gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> --- drivers/iio/pressure/ms5611_core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c index 992ad8d..a9c4d49 100644 --- a/drivers/iio/pressure/ms5611_core.c +++ b/drivers/iio/pressure/ms5611_core.c @@ -291,8 +291,8 @@ static const struct iio_info ms5611_info = { static int ms5611_init(struct iio_dev *indio_dev) { int ret; - struct regulator *vdd = devm_regulator_get(indio_dev->dev.parent, - "vdd"); + struct regulator *vdd = + devm_regulator_get_optional(indio_dev->dev.parent, "vdd"); /* Enable attached regulator if any. */ if (!IS_ERR(vdd)) { @@ -302,6 +302,10 @@ static int ms5611_init(struct iio_dev *indio_dev) "failed to enable Vdd supply: %d\n", ret); return ret; } + } else { + ret = PTR_ERR(vdd); + if (ret != -ENODEV) + return ret; } ret = ms5611_reset(indio_dev); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregor Boirie <gregor.boirie@parrot.com> To: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org> Cc: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, Tomasz Duszynski <tduszyns@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Mark Brown <broonie@kernel.org>, "Andrew F. Davis" <afd@ti.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Gregor Boirie <gregor.boirie@parrot.com> Subject: [PATCH v4 1/3] iio:pressure:ms5611: fix oops when probing regulator Date: Tue, 1 Mar 2016 11:31:36 +0100 [thread overview] Message-ID: <3c096730728684f1ce127602179c3ba73cd66cb4.1456828051.git.gregor.boirie@parrot.com> (raw) In-Reply-To: <cover.1456828051.git.gregor.boirie@parrot.com> When not compiled-in, regulator layer will return a NULL pointer when trying to get a reference to any regulator using devm_regulator_get(). As IS_ERR() does not consider this an error, the ms5611 probing operation will try to enable a NULL regulator, which will invariably cause a kernel crash. This patch fixes this situation by using devm_regulator_get_optional() instead of devm_regulator_get(). Signed-off-by: Gregor Boirie <gregor.boirie@parrot.com> --- drivers/iio/pressure/ms5611_core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c index 992ad8d..a9c4d49 100644 --- a/drivers/iio/pressure/ms5611_core.c +++ b/drivers/iio/pressure/ms5611_core.c @@ -291,8 +291,8 @@ static const struct iio_info ms5611_info = { static int ms5611_init(struct iio_dev *indio_dev) { int ret; - struct regulator *vdd = devm_regulator_get(indio_dev->dev.parent, - "vdd"); + struct regulator *vdd = + devm_regulator_get_optional(indio_dev->dev.parent, "vdd"); /* Enable attached regulator if any. */ if (!IS_ERR(vdd)) { @@ -302,6 +302,10 @@ static int ms5611_init(struct iio_dev *indio_dev) "failed to enable Vdd supply: %d\n", ret); return ret; } + } else { + ret = PTR_ERR(vdd); + if (ret != -ENODEV) + return ret; } ret = ms5611_reset(indio_dev); -- 2.1.4
next prev parent reply other threads:[~2016-03-01 10:31 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-01 10:31 [PATCH v4 0/3] iio:pressure:ms5611: fix and enhancements Gregor Boirie 2016-03-01 10:31 ` Gregor Boirie [not found] ` <cover.1456828051.git.gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> 2016-03-01 10:31 ` Gregor Boirie [this message] 2016-03-01 10:31 ` [PATCH v4 1/3] iio:pressure:ms5611: fix oops when probing regulator Gregor Boirie [not found] ` <3c096730728684f1ce127602179c3ba73cd66cb4.1456828051.git.gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> 2016-03-05 14:36 ` Jonathan Cameron 2016-03-05 14:36 ` Jonathan Cameron 2016-03-01 10:31 ` [PATCH v4 2/3] iio:pressure:ms5611: complete DT support Gregor Boirie 2016-03-01 10:31 ` Gregor Boirie [not found] ` <6cbaba17e57b0bdc6c3550f49af9161e33438f84.1456828051.git.gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> 2016-03-05 4:25 ` Rob Herring 2016-03-05 4:25 ` Rob Herring 2016-03-05 14:40 ` Jonathan Cameron 2016-03-05 14:40 ` Jonathan Cameron 2016-03-01 10:31 ` [PATCH v4 3/3] iio:pressure:ms5611: oversampling rate support Gregor Boirie 2016-03-01 10:31 ` Gregor Boirie [not found] ` <968dd61e1b2cf2fa6ba936509594d71c799226c4.1456828051.git.gregor.boirie-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org> 2016-03-05 14:45 ` Jonathan Cameron 2016-03-05 14:45 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c096730728684f1ce127602179c3ba73cd66cb4.1456828051.git.gregor.boirie@parrot.com \ --to=gregor.boirie-itf29qwbsa/qt0dzr+alfa@public.gmane.org \ --cc=afd-l0cyMroinI0@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \ --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=tduszyns-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.