* [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
@ 2018-08-19 12:02 Bernd Kuhls
2018-08-20 13:23 ` Thomas Petazzoni
2018-08-21 18:52 ` Jörg Krause
0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2018-08-19 12:02 UTC (permalink / raw)
To: buildroot
Upstream does not provide a tarball including all submodules so we need
to checkout the git repo including the submodules ourselves.
Added license hash.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/luvi/luvi.hash | 3 ++-
package/luvi/luvi.mk | 7 ++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/package/luvi/luvi.hash b/package/luvi/luvi.hash
index e2239b6171..d5716e0036 100644
--- a/package/luvi/luvi.hash
+++ b/package/luvi/luvi.hash
@@ -1,2 +1,3 @@
# Locally calculated
-sha256 ce9a1fb762e61267618ddea9ea129170fd543bb918c382b71cb35985d0024c42 luvi-src-v2.7.6.tar.gz
+sha256 a18e138c7032ef8406fef6e2135a61fad713861742512f2073adc0b4ab6d8f8b luvi-v2.8.0.tar.gz
+sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE.txt
diff --git a/package/luvi/luvi.mk b/package/luvi/luvi.mk
index a2bc218e77..8b3b7659b0 100644
--- a/package/luvi/luvi.mk
+++ b/package/luvi/luvi.mk
@@ -4,9 +4,10 @@
#
################################################################################
-LUVI_VERSION = v2.7.6
-LUVI_SOURCE = luvi-src-$(LUVI_VERSION).tar.gz
-LUVI_SITE = https://github.com/luvit/luvi/releases/download/$(LUVI_VERSION)
+LUVI_VERSION = v2.8.0
+LUVI_SITE = https://github.com/luvit/luvi.git
+LUVI_SITE_METHOD = git
+LUVI_GIT_SUBMODULES = YES
LUVI_LICENSE = Apache-2.0
LUVI_LICENSE_FILES = LICENSE.txt
LUVI_DEPENDENCIES = libuv luajit luv host-luajit
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
2018-08-19 12:02 [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0 Bernd Kuhls
@ 2018-08-20 13:23 ` Thomas Petazzoni
2018-08-21 18:52 ` Jörg Krause
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-08-20 13:23 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 19 Aug 2018 14:02:19 +0200, Bernd Kuhls wrote:
> Upstream does not provide a tarball including all submodules so we need
> to checkout the git repo including the submodules ourselves.
Could you file an issue an upstream so that they upload a tarball ?
>
> Added license hash.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/luvi/luvi.hash | 3 ++-
> package/luvi/luvi.mk | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
Applied to next, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
2018-08-19 12:02 [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0 Bernd Kuhls
2018-08-20 13:23 ` Thomas Petazzoni
@ 2018-08-21 18:52 ` Jörg Krause
2018-10-10 13:29 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Jörg Krause @ 2018-08-21 18:52 UTC (permalink / raw)
To: buildroot
Hi Bernd,
On Sun, 2018-08-19 at 14:02 +0200, Bernd Kuhls wrote:
> Upstream does not provide a tarball including all submodules so we need
> to checkout the git repo including the submodules ourselves.
>
> Added license hash.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/luvi/luvi.hash | 3 ++-
> package/luvi/luvi.mk | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/package/luvi/luvi.hash b/package/luvi/luvi.hash
> index e2239b6171..d5716e0036 100644
> --- a/package/luvi/luvi.hash
> +++ b/package/luvi/luvi.hash
> @@ -1,2 +1,3 @@
> # Locally calculated
> -sha256 ce9a1fb762e61267618ddea9ea129170fd543bb918c382b71cb35985d0024c42 luvi-src-v2.7.6.tar.gz
> +sha256 a18e138c7032ef8406fef6e2135a61fad713861742512f2073adc0b4ab6d8f8b luvi-v2.8.0.tar.gz
> +sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE.txt
> diff --git a/package/luvi/luvi.mk b/package/luvi/luvi.mk
> index a2bc218e77..8b3b7659b0 100644
> --- a/package/luvi/luvi.mk
> +++ b/package/luvi/luvi.mk
> @@ -4,9 +4,10 @@
> #
> ################################################################################
>
> -LUVI_VERSION = v2.7.6
> -LUVI_SOURCE = luvi-src-$(LUVI_VERSION).tar.gz
> -LUVI_SITE = https://github.com/luvit/luvi/releases/download/$(LUVI_VERSION)
> +LUVI_VERSION = v2.8.0
> +LUVI_SITE = https://github.com/luvit/luvi.git
> +LUVI_SITE_METHOD = git
> +LUVI_GIT_SUBMODULES = YES
> LUVI_LICENSE = Apache-2.0
> LUVI_LICENSE_FILES = LICENSE.txt
> LUVI_DEPENDENCIES = libuv luajit luv host-luajit
I am not so happy about the version bump as version 2.8.0 does only
updates the projects submodules, which we are not using at all.
Instead, we always build luvi with dependencies provided as packages in
Buildroot.
Bumping to version 2.8.0 has the drawback that fetching the package
needs much longer now due to the git submodules than fetching the
tarball and building against the packages provided by Buildroot.
Best regards,
J?rg Krause
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
2018-08-21 18:52 ` Jörg Krause
@ 2018-10-10 13:29 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-10-10 13:29 UTC (permalink / raw)
To: buildroot
J?rg, Bernd,
On Tue, 21 Aug 2018 20:52:45 +0200, J?rg Krause wrote:
> > -LUVI_VERSION = v2.7.6
> > -LUVI_SOURCE = luvi-src-$(LUVI_VERSION).tar.gz
> > -LUVI_SITE = https://github.com/luvit/luvi/releases/download/$(LUVI_VERSION)
> > +LUVI_VERSION = v2.8.0
> > +LUVI_SITE = https://github.com/luvit/luvi.git
> > +LUVI_SITE_METHOD = git
> > +LUVI_GIT_SUBMODULES = YES
> > LUVI_LICENSE = Apache-2.0
> > LUVI_LICENSE_FILES = LICENSE.txt
> > LUVI_DEPENDENCIES = libuv luajit luv host-luajit
>
> I am not so happy about the version bump as version 2.8.0 does only
> updates the projects submodules, which we are not using at all.
> Instead, we always build luvi with dependencies provided as packages in
> Buildroot.
>
> Bumping to version 2.8.0 has the drawback that fetching the package
> needs much longer now due to the git submodules than fetching the
> tarball and building against the packages provided by Buildroot.
Should we revert this 2.8.0 bump then ? If you want to do that, could
you send a patch, and made add a comment in luvi.mk that explains why
bumping to 2.8.0 is useless ?
Also, luvi 2.8.0 has been causing a number of build failures:
http://autobuild.buildroot.net/?reason=luvi-v2.8.0. They need to be
fixed, or indeed reverting will be the only solution.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-10 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-19 12:02 [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0 Bernd Kuhls
2018-08-20 13:23 ` Thomas Petazzoni
2018-08-21 18:52 ` Jörg Krause
2018-10-10 13:29 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.