* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses @ 2020-08-27 19:52 Soeren Moch 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch ` (4 more replies) 0 siblings, 5 replies; 9+ messages in thread From: Soeren Moch @ 2020-08-27 19:52 UTC (permalink / raw) To: u-boot According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry. Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM. Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB. Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd. Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot. Signed-off-by: Soeren Moch <smoch@web.de> --- Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Cc: u-boot at lists.denx.de Recommendations taken from [1]. Distroboot support for the tbs2910 board was added in the v2020.10 merge window. So please pull this in as fix for v2020.10. Thanks, Soeren [1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html --- include/configs/tbs2910.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 8092b9edfb..b05034945e 100644 --- a/include/configs/tbs2910.h +++ b/include/configs/tbs2910.h @@ -85,13 +85,12 @@ "bootm 0x10800000 0x10d00000\0" \ "console=ttymxc0\0" \ "fan=gpio set 92\0" \ - "fdt_addr=0x13000000\0" \ - "fdt_addr_r=0x13000000\0" \ + "fdt_addr_r=0x18000000\0" \ "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ - "kernel_addr_r=0x10008000\0" \ - "pxefile_addr_r=0x10008000\0" \ - "ramdisk_addr_r=0x18000000\0" \ - "scriptaddr=0x14000000\0" \ + "kernel_addr_r=0x12000000\0" \ + "pxefile_addr_r=0x10100000\0" \ + "ramdisk_addr_r=0x18080000\0" \ + "scriptaddr=0x10000000\0" \ "set_con_serial=setenv stdout serial; " \ "setenv stderr serial\0" \ "set_con_hdmi=setenv stdout serial,vidconsole; " \ -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch @ 2020-08-27 19:52 ` Soeren Moch 2020-08-27 21:24 ` Fabio Estevam 2020-09-18 14:06 ` sbabic at denx.de 2020-08-27 21:23 ` [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Fabio Estevam ` (3 subsequent siblings) 4 siblings, 2 replies; 9+ messages in thread From: Soeren Moch @ 2020-08-27 19:52 UTC (permalink / raw) To: u-boot This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables. Signed-off-by: Soeren Moch <smoch@web.de> --- Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Cc: u-boot at lists.denx.de --- configs/tbs2910_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index 34d240565e..070aea59b5 100644 --- a/configs/tbs2910_defconfig +++ b/configs/tbs2910_defconfig @@ -11,7 +11,6 @@ CONFIG_PRE_CON_BUF_ADDR=0x7c000000 CONFIG_CMD_HDMIDETECT=y CONFIG_DEFAULT_DEVICE_TREE="imx6q-tbs2910" CONFIG_AHCI=y -CONFIG_ENV_VARS_UBOOT_CONFIG=y CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="mmc rescan; if run bootcmd_up1; then run bootcmd_up2; else run bootcmd_mmc || run distro_bootcmd; fi" -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch @ 2020-08-27 21:24 ` Fabio Estevam 2020-09-18 14:06 ` sbabic at denx.de 1 sibling, 0 replies; 9+ messages in thread From: Fabio Estevam @ 2020-08-27 21:24 UTC (permalink / raw) To: u-boot On Thu, Aug 27, 2020 at 4:53 PM Soeren Moch <smoch@web.de> wrote: > > This is not required for sysboot (we defined fdtfile), let's save a few > bytes in the binary image without these variables. > > Signed-off-by: Soeren Moch <smoch@web.de> Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch 2020-08-27 21:24 ` Fabio Estevam @ 2020-09-18 14:06 ` sbabic at denx.de 1 sibling, 0 replies; 9+ messages in thread From: sbabic at denx.de @ 2020-09-18 14:06 UTC (permalink / raw) To: u-boot > This is not required for sysboot (we defined fdtfile), let's save a few > bytes in the binary image without these variables. > Signed-off-by: Soeren Moch <smoch@web.de> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch @ 2020-08-27 21:23 ` Fabio Estevam 2020-08-28 12:53 ` Tom Rini ` (2 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: Fabio Estevam @ 2020-08-27 21:23 UTC (permalink / raw) To: u-boot Hi Soeren, On Thu, Aug 27, 2020 at 4:53 PM Soeren Moch <smoch@web.de> wrote: > > According to doc/README.distro fdt_addr must not be set when DTB is not > available from hardware. So remove this entry. > > Use address 32MB above the start of DRAM for kernel_addr_r. This way > we likely can avoid the self-relocation of the compressed kernel image > before it decompresses to offset 0x8000 from start of DRAM. > > Use address 128MB above the start of DRAM for fdt_addr_r, since this is > the maximum location for the end of the kernel. So we avoid overwriting > the DTB. > > Use 512k above that for ramdisk_addr_r. This should be enough for the > DTB, rest of DRAM can be used for initrd. > > Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. > This space is available for processing in U-Boot. > > Signed-off-by: Soeren Moch <smoch@web.de> Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch 2020-08-27 21:23 ` [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Fabio Estevam @ 2020-08-28 12:53 ` Tom Rini 2020-10-02 10:40 ` Soeren Moch 2020-10-02 15:56 ` Tom Rini 4 siblings, 0 replies; 9+ messages in thread From: Tom Rini @ 2020-08-28 12:53 UTC (permalink / raw) To: u-boot On Thu, Aug 27, 2020 at 09:52:46PM +0200, Soeren Moch wrote: > According to doc/README.distro fdt_addr must not be set when DTB is not > available from hardware. So remove this entry. > > Use address 32MB above the start of DRAM for kernel_addr_r. This way > we likely can avoid the self-relocation of the compressed kernel image > before it decompresses to offset 0x8000 from start of DRAM. > > Use address 128MB above the start of DRAM for fdt_addr_r, since this is > the maximum location for the end of the kernel. So we avoid overwriting > the DTB. > > Use 512k above that for ramdisk_addr_r. This should be enough for the > DTB, rest of DRAM can be used for initrd. > > Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. > This space is available for processing in U-Boot. > > Signed-off-by: Soeren Moch <smoch@web.de> Reviewed-by: Tom Rini <trini@konsulko.com> -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/d0e6f617/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch ` (2 preceding siblings ...) 2020-08-28 12:53 ` Tom Rini @ 2020-10-02 10:40 ` Soeren Moch 2020-10-02 10:55 ` Stefano Babic 2020-10-02 15:56 ` Tom Rini 4 siblings, 1 reply; 9+ messages in thread From: Soeren Moch @ 2020-10-02 10:40 UTC (permalink / raw) To: u-boot Stefano, Tom, I would really like to see this merged for v2020.10. Maybe there are no other imx patches pending for v2020.10, so maybe Tom can pick up this directly (as the original patch for sysboot support, that was merged in -next for v2020.10-rc1)? This really is a fix for this newly added sysboot support on tbs2910, so it would be great to get the properly fixed addresses and dtb declaration into the final release. The u-boot internal device tree must not be used for booting linux, since this dtb is stripped down. And the recommended kernel address avoids the additional self-relocation of the kernel after starting linux. Thanks, Soeren On 27.08.20 21:52, Soeren Moch wrote: > According to doc/README.distro fdt_addr must not be set when DTB is not > available from hardware. So remove this entry. > > Use address 32MB above the start of DRAM for kernel_addr_r. This way > we likely can avoid the self-relocation of the compressed kernel image > before it decompresses to offset 0x8000 from start of DRAM. > > Use address 128MB above the start of DRAM for fdt_addr_r, since this is > the maximum location for the end of the kernel. So we avoid overwriting > the DTB. > > Use 512k above that for ramdisk_addr_r. This should be enough for the > DTB, rest of DRAM can be used for initrd. > > Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. > This space is available for processing in U-Boot. > > Signed-off-by: Soeren Moch <smoch@web.de> > --- > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> > Cc: u-boot at lists.denx.de > > Recommendations taken from [1]. > > Distroboot support for the tbs2910 board was added in the v2020.10 > merge window. So please pull this in as fix for v2020.10. > > Thanks, > Soeren > > [1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html > --- > include/configs/tbs2910.h | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index 8092b9edfb..b05034945e 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -85,13 +85,12 @@ > "bootm 0x10800000 0x10d00000\0" \ > "console=ttymxc0\0" \ > "fan=gpio set 92\0" \ > - "fdt_addr=0x13000000\0" \ > - "fdt_addr_r=0x13000000\0" \ > + "fdt_addr_r=0x18000000\0" \ > "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ > - "kernel_addr_r=0x10008000\0" \ > - "pxefile_addr_r=0x10008000\0" \ > - "ramdisk_addr_r=0x18000000\0" \ > - "scriptaddr=0x14000000\0" \ > + "kernel_addr_r=0x12000000\0" \ > + "pxefile_addr_r=0x10100000\0" \ > + "ramdisk_addr_r=0x18080000\0" \ > + "scriptaddr=0x10000000\0" \ > "set_con_serial=setenv stdout serial; " \ > "setenv stderr serial\0" \ > "set_con_hdmi=setenv stdout serial,vidconsole; " \ > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses 2020-10-02 10:40 ` Soeren Moch @ 2020-10-02 10:55 ` Stefano Babic 0 siblings, 0 replies; 9+ messages in thread From: Stefano Babic @ 2020-10-02 10:55 UTC (permalink / raw) To: u-boot Hi Soeren, On 02.10.20 12:40, Soeren Moch wrote: > Stefano, Tom, > > I would really like to see this merged for v2020.10. Maybe there are no > other imx patches pending for v2020.10, Right, I do not see urgent fixes, and remaining patches will be merged after release. > so maybe Tom can pick up this > directly (as the original patch for sysboot support, that was merged in > -next for v2020.10-rc1)? Fine with me - @Tom, could you pick up this ? > > This really is a fix for this newly added sysboot support on tbs2910, so > it would be great to get the properly fixed addresses and dtb > declaration into the final release. The u-boot internal device tree must > not be used for booting linux, since this dtb is stripped down. And the > recommended kernel address avoids the additional self-relocation of the > kernel after starting linux. Regards, Stefano > > Thanks, > Soeren > > On 27.08.20 21:52, Soeren Moch wrote: >> According to doc/README.distro fdt_addr must not be set when DTB is not >> available from hardware. So remove this entry. >> >> Use address 32MB above the start of DRAM for kernel_addr_r. This way >> we likely can avoid the self-relocation of the compressed kernel image >> before it decompresses to offset 0x8000 from start of DRAM. >> >> Use address 128MB above the start of DRAM for fdt_addr_r, since this is >> the maximum location for the end of the kernel. So we avoid overwriting >> the DTB. >> >> Use 512k above that for ramdisk_addr_r. This should be enough for the >> DTB, rest of DRAM can be used for initrd. >> >> Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. >> This space is available for processing in U-Boot. >> >> Signed-off-by: Soeren Moch <smoch@web.de> >> --- >> Cc: Stefano Babic <sbabic@denx.de> >> Cc: Fabio Estevam <festevam@gmail.com> >> Cc: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> >> Cc: u-boot at lists.denx.de >> >> Recommendations taken from [1]. >> >> Distroboot support for the tbs2910 board was added in the v2020.10 >> merge window. So please pull this in as fix for v2020.10. >> >> Thanks, >> Soeren >> >> [1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html >> --- >> include/configs/tbs2910.h | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h >> index 8092b9edfb..b05034945e 100644 >> --- a/include/configs/tbs2910.h >> +++ b/include/configs/tbs2910.h >> @@ -85,13 +85,12 @@ >> "bootm 0x10800000 0x10d00000\0" \ >> "console=ttymxc0\0" \ >> "fan=gpio set 92\0" \ >> - "fdt_addr=0x13000000\0" \ >> - "fdt_addr_r=0x13000000\0" \ >> + "fdt_addr_r=0x18000000\0" \ >> "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ >> - "kernel_addr_r=0x10008000\0" \ >> - "pxefile_addr_r=0x10008000\0" \ >> - "ramdisk_addr_r=0x18000000\0" \ >> - "scriptaddr=0x14000000\0" \ >> + "kernel_addr_r=0x12000000\0" \ >> + "pxefile_addr_r=0x10100000\0" \ >> + "ramdisk_addr_r=0x18080000\0" \ >> + "scriptaddr=0x10000000\0" \ >> "set_con_serial=setenv stdout serial; " \ >> "setenv stderr serial\0" \ >> "set_con_hdmi=setenv stdout serial,vidconsole; " \ >> -- >> 2.17.1 >> -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch ` (3 preceding siblings ...) 2020-10-02 10:40 ` Soeren Moch @ 2020-10-02 15:56 ` Tom Rini 4 siblings, 0 replies; 9+ messages in thread From: Tom Rini @ 2020-10-02 15:56 UTC (permalink / raw) To: u-boot On Thu, Aug 27, 2020 at 09:52:46PM +0200, Soeren Moch wrote: > According to doc/README.distro fdt_addr must not be set when DTB is not > available from hardware. So remove this entry. > > Use address 32MB above the start of DRAM for kernel_addr_r. This way > we likely can avoid the self-relocation of the compressed kernel image > before it decompresses to offset 0x8000 from start of DRAM. > > Use address 128MB above the start of DRAM for fdt_addr_r, since this is > the maximum location for the end of the kernel. So we avoid overwriting > the DTB. > > Use 512k above that for ramdisk_addr_r. This should be enough for the > DTB, rest of DRAM can be used for initrd. > > Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. > This space is available for processing in U-Boot. > > Signed-off-by: Soeren Moch <smoch@web.de> > Reviewed-by: Fabio Estevam <festevam@gmail.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201002/07290455/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-02 15:56 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-27 19:52 [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Soeren Moch 2020-08-27 19:52 ` [PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig Soeren Moch 2020-08-27 21:24 ` Fabio Estevam 2020-09-18 14:06 ` sbabic at denx.de 2020-08-27 21:23 ` [PATCH 1/2] board: tbs2910: Use recommended distroboot addresses Fabio Estevam 2020-08-28 12:53 ` Tom Rini 2020-10-02 10:40 ` Soeren Moch 2020-10-02 10:55 ` Stefano Babic 2020-10-02 15:56 ` Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.