All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
@ 2017-11-02 18:41 Gustavo A. R. Silva
  2017-11-03  8:03 ` Juergen Gross
  2017-11-03  8:03 ` Juergen Gross
  0 siblings, 2 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-02 18:41 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross
  Cc: xen-devel, linux-kernel, Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 146562
Addresses-Coverity-ID: 146563
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/xen/xenbus/xenbus_probe_frontend.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index 19e45ce..07896f4 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -379,10 +379,12 @@ static void xenbus_reset_frontend(char *fe, char *be, int be_state)
 	case XenbusStateConnected:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosing);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosing);
+		/* fall through */
 
 	case XenbusStateClosing:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosed);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosed);
+		/* fall through */
 
 	case XenbusStateClosed:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateInitialising);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
  2017-11-02 18:41 [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2017-11-03  8:03 ` Juergen Gross
  2017-11-08 21:19     ` Boris Ostrovsky
  2017-11-03  8:03 ` Juergen Gross
  1 sibling, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2017-11-03  8:03 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Boris Ostrovsky; +Cc: xen-devel, linux-kernel

On 02/11/17 19:41, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 146562
> Addresses-Coverity-ID: 146563
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
  2017-11-02 18:41 [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs Gustavo A. R. Silva
  2017-11-03  8:03 ` Juergen Gross
@ 2017-11-03  8:03 ` Juergen Gross
  1 sibling, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2017-11-03  8:03 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Boris Ostrovsky; +Cc: xen-devel, linux-kernel

On 02/11/17 19:41, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 146562
> Addresses-Coverity-ID: 146563
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
  2017-11-03  8:03 ` Juergen Gross
@ 2017-11-08 21:19     ` Boris Ostrovsky
  0 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:19 UTC (permalink / raw)
  To: Juergen Gross, Gustavo A. R. Silva; +Cc: xen-devel, linux-kernel

On 11/03/2017 04:03 AM, Juergen Gross wrote:
> On 02/11/17 19:41, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 146562
>> Addresses-Coverity-ID: 146563
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-4.15.

-boris

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
@ 2017-11-08 21:19     ` Boris Ostrovsky
  0 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:19 UTC (permalink / raw)
  To: Juergen Gross, Gustavo A. R. Silva; +Cc: xen-devel, linux-kernel

On 11/03/2017 04:03 AM, Juergen Gross wrote:
> On 02/11/17 19:41, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 146562
>> Addresses-Coverity-ID: 146563
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-4.15.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs
@ 2017-11-02 18:41 Gustavo A. R. Silva
  0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-02 18:41 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross
  Cc: xen-devel, Gustavo A. R. Silva, linux-kernel

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 146562
Addresses-Coverity-ID: 146563
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/xen/xenbus/xenbus_probe_frontend.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index 19e45ce..07896f4 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -379,10 +379,12 @@ static void xenbus_reset_frontend(char *fe, char *be, int be_state)
 	case XenbusStateConnected:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosing);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosing);
+		/* fall through */
 
 	case XenbusStateClosing:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosed);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosed);
+		/* fall through */
 
 	case XenbusStateClosed:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateInitialising);
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-08 21:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 18:41 [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-03  8:03 ` Juergen Gross
2017-11-08 21:19   ` Boris Ostrovsky
2017-11-08 21:19     ` Boris Ostrovsky
2017-11-03  8:03 ` Juergen Gross
  -- strict thread matches above, loose matches on Subject: below --
2017-11-02 18:41 Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.