* [PATCH] fsck.f2fs: sanity check of crc_offset from raw checkpoint
@ 2017-03-15 13:12 Kinglong Mee
0 siblings, 0 replies; only message in thread
From: Kinglong Mee @ 2017-03-15 13:12 UTC (permalink / raw)
To: Jaegeuk Kim, linux-f2fs-devel
The crc_offset towards or beyond the end of block is wrong,
sanity check it.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fsck/mount.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck/mount.c b/fsck/mount.c
index fc4cca8..c54bb95 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -545,7 +545,7 @@ void *validate_checkpoint(struct f2fs_sb_info *sbi, block_t cp_addr,
cp = (struct f2fs_checkpoint *)cp_page_1;
crc_offset = get_cp(checksum_offset);
- if (crc_offset >= blk_size)
+ if (crc_offset > (blk_size - sizeof(__le32)))
goto invalid_cp1;
crc = le32_to_cpu(*(__le32 *)((unsigned char *)cp + crc_offset));
@@ -563,7 +563,7 @@ void *validate_checkpoint(struct f2fs_sb_info *sbi, block_t cp_addr,
cp = (struct f2fs_checkpoint *)cp_page_2;
crc_offset = get_cp(checksum_offset);
- if (crc_offset >= blk_size)
+ if (crc_offset > (blk_size - sizeof(__le32)))
goto invalid_cp2;
crc = le32_to_cpu(*(__le32 *)((unsigned char *)cp + crc_offset));
--
2.9.3
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-15 13:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 13:12 [PATCH] fsck.f2fs: sanity check of crc_offset from raw checkpoint Kinglong Mee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.