* [PATCH 0/5] gpio: Remove unnecessary driver_data set operations
@ 2017-01-30 14:39 William Breathitt Gray
2017-01-30 14:39 ` [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:39 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
In a previous patchset ("gpio: Utilize devm_ functions in driver probe
callbacks") the device remove functions for several drivers were removed
as no longer necessary due to the patchset changes within. Setting
driver_data had been necessary in these drivers in order to access
private data in the respective device remove function. Now that the
device remove functions are gone, setting driver_data is no longer
necessary for these drivers. This patchset removes the relevant code.
William Breathitt Gray (5):
gpio: 104-dio-48e: Remove unnecessary driver_data set
gpio: 104-idi-48: Remove unnecessary driver_data set
gpio: 104-idio-16: Remove unnecessary driver_data set
gpio: gpio-mm: Remove unnecessary driver_data set
gpio: ws16c48: Remove unnecessary driver_data set
drivers/gpio/gpio-104-dio-48e.c | 2 --
drivers/gpio/gpio-104-idi-48.c | 2 --
drivers/gpio/gpio-104-idio-16.c | 2 --
drivers/gpio/gpio-gpio-mm.c | 2 --
drivers/gpio/gpio-ws16c48.c | 2 --
5 files changed, 10 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
@ 2017-01-30 14:39 ` William Breathitt Gray
2017-02-01 13:21 ` Linus Walleij
2017-01-30 14:39 ` [PATCH 2/5] gpio: 104-idi-48: " William Breathitt Gray
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:39 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
Setting driver_data was necessary to access private data in the
dio48e_remove function. Now that the dio48e_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-104-dio-48e.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
index 221243f17d4e..b6b0378166c4 100644
--- a/drivers/gpio/gpio-104-dio-48e.c
+++ b/drivers/gpio/gpio-104-dio-48e.c
@@ -369,8 +369,6 @@ static int dio48e_probe(struct device *dev, unsigned int id)
spin_lock_init(&dio48egpio->lock);
- dev_set_drvdata(dev, dio48egpio);
-
err = devm_gpiochip_add_data(dev, &dio48egpio->chip, dio48egpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
2017-01-30 14:39 ` [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray
@ 2017-01-30 14:39 ` William Breathitt Gray
2017-02-01 13:22 ` Linus Walleij
2017-01-30 14:39 ` [PATCH 3/5] gpio: 104-idio-16: " William Breathitt Gray
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:39 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
Setting driver_data was necessary to access private data in the
idi_48_remove function. Now that the idi_48_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-104-idi-48.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
index eafbf053f3e8..dc100dff6e13 100644
--- a/drivers/gpio/gpio-104-idi-48.c
+++ b/drivers/gpio/gpio-104-idi-48.c
@@ -246,8 +246,6 @@ static int idi_48_probe(struct device *dev, unsigned int id)
spin_lock_init(&idi48gpio->lock);
spin_lock_init(&idi48gpio->ack_lock);
- dev_set_drvdata(dev, idi48gpio);
-
err = devm_gpiochip_add_data(dev, &idi48gpio->chip, idi48gpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] gpio: 104-idio-16: Remove unnecessary driver_data set
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
2017-01-30 14:39 ` [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray
2017-01-30 14:39 ` [PATCH 2/5] gpio: 104-idi-48: " William Breathitt Gray
@ 2017-01-30 14:39 ` William Breathitt Gray
2017-02-01 13:23 ` Linus Walleij
2017-01-30 14:40 ` [PATCH 4/5] gpio: gpio-mm: " William Breathitt Gray
2017-01-30 14:40 ` [PATCH 5/5] gpio: ws16c48: " William Breathitt Gray
4 siblings, 1 reply; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:39 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
Setting driver_data was necessary to access private data in the
idio_16_remove function. Now that the idio_16_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-104-idio-16.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index 01a091e17614..67068b61b90b 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -242,8 +242,6 @@ static int idio_16_probe(struct device *dev, unsigned int id)
spin_lock_init(&idio16gpio->lock);
- dev_set_drvdata(dev, idio16gpio);
-
err = devm_gpiochip_add_data(dev, &idio16gpio->chip, idio16gpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
` (2 preceding siblings ...)
2017-01-30 14:39 ` [PATCH 3/5] gpio: 104-idio-16: " William Breathitt Gray
@ 2017-01-30 14:40 ` William Breathitt Gray
2017-02-01 13:44 ` Linus Walleij
2017-01-30 14:40 ` [PATCH 5/5] gpio: ws16c48: " William Breathitt Gray
4 siblings, 1 reply; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:40 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
Setting driver_data was necessary to access private data in the
gpiomm_remove function. Now that the gpiomm_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-gpio-mm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-gpio-mm.c b/drivers/gpio/gpio-gpio-mm.c
index 393c8f9cf30d..60017425b49f 100644
--- a/drivers/gpio/gpio-gpio-mm.c
+++ b/drivers/gpio/gpio-gpio-mm.c
@@ -261,8 +261,6 @@ static int gpiomm_probe(struct device *dev, unsigned int id)
spin_lock_init(&gpiommgpio->lock);
- dev_set_drvdata(dev, gpiommgpio);
-
err = devm_gpiochip_add_data(dev, &gpiommgpio->chip, gpiommgpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] gpio: ws16c48: Remove unnecessary driver_data set
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
` (3 preceding siblings ...)
2017-01-30 14:40 ` [PATCH 4/5] gpio: gpio-mm: " William Breathitt Gray
@ 2017-01-30 14:40 ` William Breathitt Gray
2017-02-01 13:45 ` Linus Walleij
4 siblings, 1 reply; 11+ messages in thread
From: William Breathitt Gray @ 2017-01-30 14:40 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, William Breathitt Gray
Setting driver_data was necessary to access private data in the
ws16c48_remove function. Now that the ws16c48_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-ws16c48.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c
index 65de20dfbe7a..48b35589b7d6 100644
--- a/drivers/gpio/gpio-ws16c48.c
+++ b/drivers/gpio/gpio-ws16c48.c
@@ -372,8 +372,6 @@ static int ws16c48_probe(struct device *dev, unsigned int id)
spin_lock_init(&ws16c48gpio->lock);
- dev_set_drvdata(dev, ws16c48gpio);
-
err = devm_gpiochip_add_data(dev, &ws16c48gpio->chip, ws16c48gpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set
2017-01-30 14:39 ` [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray
@ 2017-02-01 13:21 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2017-02-01 13:21 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Setting driver_data was necessary to access private data in the
> dio48e_remove function. Now that the dio48e_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set
2017-01-30 14:39 ` [PATCH 2/5] gpio: 104-idi-48: " William Breathitt Gray
@ 2017-02-01 13:22 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2017-02-01 13:22 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Setting driver_data was necessary to access private data in the
> idi_48_remove function. Now that the idi_48_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/5] gpio: 104-idio-16: Remove unnecessary driver_data set
2017-01-30 14:39 ` [PATCH 3/5] gpio: 104-idio-16: " William Breathitt Gray
@ 2017-02-01 13:23 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2017-02-01 13:23 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Setting driver_data was necessary to access private data in the
> idio_16_remove function. Now that the idio_16_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set
2017-01-30 14:40 ` [PATCH 4/5] gpio: gpio-mm: " William Breathitt Gray
@ 2017-02-01 13:44 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2017-02-01 13:44 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Mon, Jan 30, 2017 at 3:40 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Setting driver_data was necessary to access private data in the
> gpiomm_remove function. Now that the gpiomm_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] gpio: ws16c48: Remove unnecessary driver_data set
2017-01-30 14:40 ` [PATCH 5/5] gpio: ws16c48: " William Breathitt Gray
@ 2017-02-01 13:45 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2017-02-01 13:45 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Mon, Jan 30, 2017 at 3:40 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Setting driver_data was necessary to access private data in the
> ws16c48_remove function. Now that the ws16c48_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-02-01 13:45 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-30 14:39 [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray
2017-01-30 14:39 ` [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray
2017-02-01 13:21 ` Linus Walleij
2017-01-30 14:39 ` [PATCH 2/5] gpio: 104-idi-48: " William Breathitt Gray
2017-02-01 13:22 ` Linus Walleij
2017-01-30 14:39 ` [PATCH 3/5] gpio: 104-idio-16: " William Breathitt Gray
2017-02-01 13:23 ` Linus Walleij
2017-01-30 14:40 ` [PATCH 4/5] gpio: gpio-mm: " William Breathitt Gray
2017-02-01 13:44 ` Linus Walleij
2017-01-30 14:40 ` [PATCH 5/5] gpio: ws16c48: " William Breathitt Gray
2017-02-01 13:45 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.