* Re: [PATCH] Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue
[not found] <1502178138-21654-1-git-send-email-justmaker@gmail.com>
@ 2017-08-08 9:40 ` Ian Abbott
2017-08-08 11:25 ` 徐細菌
0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2017-08-08 9:40 UTC (permalink / raw)
To: Chi-Chun Hsu; +Cc: hsweeten, gregkh, devel, linux-kernel
On 08/08/17 08:42, Chi-Chun Hsu wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Chi-Chun Hsu <justmaker@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index 40ff914..b2f6712 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -68,7 +68,7 @@
> struct apci3501_private {
> unsigned long amcc;
> unsigned long tcw;
> - struct task_struct *tsk_Current;
> + struct task_struct *tsk_current;
> unsigned char timer_mode;
> };
>
> @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> }
>
> /* Enable Interrupt Send a signal to from kernel to user space */
> - send_sig(SIGIO, devpriv->tsk_Current, 0);
> + send_sig(SIGIO, devpriv->tsk_current, 0);
> ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
> ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
> ADDI_TCW_CTRL_IRQ_ENA);
>
This patch is incomplete (the 'tsk_Current' member is also used in
"drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd
by "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was
removed in kernel version 4.9 by commit a6672530f6fc ("staging: comedi:
addi_apci_3501: remove timer/counter subdevice support").
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue
2017-08-08 9:40 ` [PATCH] Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue Ian Abbott
@ 2017-08-08 11:25 ` 徐細菌
0 siblings, 0 replies; 2+ messages in thread
From: 徐細菌 @ 2017-08-08 11:25 UTC (permalink / raw)
To: Ian Abbott; +Cc: hsweeten, gregkh, devel, linux-kernel
> This patch is incomplete (the 'tsk_Current' member is also used in
> "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by
> "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in
> kernel version 4.9 by commit a6672530f6fc ("staging: comedi: addi_apci_3501:
> remove timer/counter subdevice support").
>
Got it, great thanks for your detailed reply.
2017-08-08 17:40 GMT+08:00 Ian Abbott <abbotti@mev.co.uk>:
> On 08/08/17 08:42, Chi-Chun Hsu wrote:
>>
>> Fixed a coding style issue.
>>
>> Signed-off-by: Chi-Chun Hsu <justmaker@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c
>> b/drivers/staging/comedi/drivers/addi_apci_3501.c
>> index 40ff914..b2f6712 100644
>> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
>> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
>> @@ -68,7 +68,7 @@
>> struct apci3501_private {
>> unsigned long amcc;
>> unsigned long tcw;
>> - struct task_struct *tsk_Current;
>> + struct task_struct *tsk_current;
>> unsigned char timer_mode;
>> };
>> @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void
>> *d)
>> }
>> /* Enable Interrupt Send a signal to from kernel to user space */
>> - send_sig(SIGIO, devpriv->tsk_Current, 0);
>> + send_sig(SIGIO, devpriv->tsk_current, 0);
>> ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
>> ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
>> ADDI_TCW_CTRL_IRQ_ENA);
>>
>
> This patch is incomplete (the 'tsk_Current' member is also used in
> "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by
> "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in
> kernel version 4.9 by commit a6672530f6fc ("staging: comedi: addi_apci_3501:
> remove timer/counter subdevice support").
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-08 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1502178138-21654-1-git-send-email-justmaker@gmail.com>
2017-08-08 9:40 ` [PATCH] Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue Ian Abbott
2017-08-08 11:25 ` 徐細菌
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.