Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict

[Mark Hatle <mark.hatle@windriver.com>]

On 3/13/19 9:59 PM, Bruce Ashfield wrote:
> I'm waiting for Mark to reply to your explanation. He had the open
> question, I'm waiting for him to ack it.

Sorry, I had nothing to add.. I was satisfied with the answer.

Ack.

--Mark

> Bruce
> 
> On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
>>
>> Ping.
>>
>> 在 2019/3/7 上午10:58, Dengke Du 写道:
>>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
>>> so we should append it, not override.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>>   meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> index b55f9a9..0b0f011 100644
>>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>>>
>>>   inherit useradd
>>>   USERADD_PACKAGES = "${PN}"
>>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
>>>
>>>   do_install_append() {
>>>       sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
> 
> 
>