From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: ddu <dengke.du@windriver.com>
Cc: meta-virtualization@yoctoproject.org
Subject: Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
Date: Wed, 13 Mar 2019 22:59:08 -0400 [thread overview]
Message-ID: <CADkTA4OeoDYtbY3zhgeTUK2LomKcE8-uLy2MBw01SD6Kawj_UA@mail.gmail.com> (raw)
In-Reply-To: <19ea4f51-91c8-21ff-b972-c7d36ec4e04f@windriver.com>
I'm waiting for Mark to reply to your explanation. He had the open
question, I'm waiting for him to ack it.
Bruce
On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
>
> Ping.
>
> 在 2019/3/7 上午10:58, Dengke Du 写道:
> > The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> > so we should append it, not override.
> >
> > Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > ---
> > meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > index b55f9a9..0b0f011 100644
> > --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
> >
> > inherit useradd
> > USERADD_PACKAGES = "${PN}"
> > -GROUPADD_PARAM_${PN} = "--system libvirt"
> > +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> >
> > do_install_append() {
> > sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
next prev parent reply other threads:[~2019-03-14 2:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 2:58 [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict Dengke Du
2019-03-07 14:00 ` Mark Hatle
2019-03-08 2:44 ` ddu
2019-03-08 3:26 ` ddu
2019-03-08 6:00 ` ddu
2019-03-14 8:33 ` ddu
2019-03-14 0:11 ` ddu
2019-03-14 2:59 ` Bruce Ashfield [this message]
2019-03-14 14:18 ` Mark Hatle
2019-03-15 1:33 ` Bruce Ashfield
2019-03-17 0:22 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADkTA4OeoDYtbY3zhgeTUK2LomKcE8-uLy2MBw01SD6Kawj_UA@mail.gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=dengke.du@windriver.com \
--cc=meta-virtualization@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.