From: Marc Gonzalez <marc.w.gonzalez@free.fr> To: Vinod Koul <vkoul@kernel.org>, David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Niklas Cassel <niklas.cassel@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Nori Sekhar <nsekhar@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com> Subject: Re: [PATCH net-next v3 1/2] net: phy: at803x: don't inline helpers Date: Tue, 19 Feb 2019 12:44:56 +0100 [thread overview] Message-ID: <3cc1b4c8-489e-b5a9-d1ae-c0905befc229@free.fr> (raw) In-Reply-To: <20190219061800.31025-2-vkoul@kernel.org> On 19/02/2019 07:17, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optimizations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() I would word it slightly differently: Some helpers were declared with the "inline" function specifier. It is preferable to let the compiler pick the right optimizations, so drop the specifier. [ This is just a random suggestion, feel free to ignore ] > Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
WARNING: multiple messages have this Message-ID (diff)
From: Marc Gonzalez <marc.w.gonzalez@free.fr> To: Vinod Koul <vkoul@kernel.org>, David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org> Cc: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Nori Sekhar <nsekhar@ti.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Niklas Cassel <niklas.cassel@linaro.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH net-next v3 1/2] net: phy: at803x: don't inline helpers Date: Tue, 19 Feb 2019 12:44:56 +0100 [thread overview] Message-ID: <3cc1b4c8-489e-b5a9-d1ae-c0905befc229@free.fr> (raw) In-Reply-To: <20190219061800.31025-2-vkoul@kernel.org> On 19/02/2019 07:17, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optimizations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() I would word it slightly differently: Some helpers were declared with the "inline" function specifier. It is preferable to let the compiler pick the right optimizations, so drop the specifier. [ This is just a random suggestion, feel free to ignore ] > Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-19 11:45 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-19 6:17 [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Vinod Koul 2019-02-19 6:17 ` [PATCH net-next v3 1/2] net: phy: at803x: don't inline helpers Vinod Koul 2019-02-19 11:44 ` Marc Gonzalez [this message] 2019-02-19 11:44 ` Marc Gonzalez 2019-02-19 6:18 ` [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul 2019-02-19 11:57 ` Marc Gonzalez 2019-02-19 12:33 ` Niklas Cassel 2019-02-19 12:41 ` Marc Gonzalez 2019-02-19 8:09 ` [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Peter Ujfalusi 2019-02-19 8:09 ` Peter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3cc1b4c8-489e-b5a9-d1ae-c0905befc229@free.fr \ --to=marc.w.gonzalez@free.fr \ --cc=andrew@lunn.ch \ --cc=bjorn.andersson@linaro.org \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=niklas.cassel@linaro.org \ --cc=nsekhar@ti.com \ --cc=peter.ujfalusi@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.