All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] stubs: update replay-tools to match replay.h types
@ 2022-07-04  7:58 Claudio Fontana
  2022-07-04 14:18 ` Thomas Huth
  2022-07-28 11:51 ` Paolo Bonzini
  0 siblings, 2 replies; 3+ messages in thread
From: Claudio Fontana @ 2022-07-04  7:58 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-devel, Claudio Fontana, Pavel Dovgalyuk

detected with GCC 13 [-Werror=enum-int-mismatch]

Solves Issue #1096.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
---
 stubs/replay-tools.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c
index 43296b3d4e..f2e72bb225 100644
--- a/stubs/replay-tools.c
+++ b/stubs/replay-tools.c
@@ -7,13 +7,14 @@ bool replay_events_enabled(void)
     return false;
 }
 
-int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
+int64_t replay_save_clock(ReplayClockKind kind,
+                          int64_t clock, int64_t raw_icount)
 {
     abort();
     return 0;
 }
 
-int64_t replay_read_clock(unsigned int kind, int64_t raw_icount)
+int64_t replay_read_clock(ReplayClockKind kind, int64_t raw_icount)
 {
     abort();
     return 0;
@@ -48,11 +49,11 @@ void replay_mutex_unlock(void)
 {
 }
 
-void replay_register_char_driver(Chardev *chr)
+void replay_register_char_driver(struct Chardev *chr)
 {
 }
 
-void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
+void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len)
 {
     abort();
 }
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] stubs: update replay-tools to match replay.h types
  2022-07-04  7:58 [PATCH] stubs: update replay-tools to match replay.h types Claudio Fontana
@ 2022-07-04 14:18 ` Thomas Huth
  2022-07-28 11:51 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-07-04 14:18 UTC (permalink / raw)
  To: Claudio Fontana; +Cc: qemu-devel, Pavel Dovgalyuk, QEMU Trivial

On 04/07/2022 09.58, Claudio Fontana wrote:
> detected with GCC 13 [-Werror=enum-int-mismatch]
> 
> Solves Issue #1096.
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> ---
>   stubs/replay-tools.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c
> index 43296b3d4e..f2e72bb225 100644
> --- a/stubs/replay-tools.c
> +++ b/stubs/replay-tools.c
> @@ -7,13 +7,14 @@ bool replay_events_enabled(void)
>       return false;
>   }
>   
> -int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
> +int64_t replay_save_clock(ReplayClockKind kind,
> +                          int64_t clock, int64_t raw_icount)
>   {
>       abort();
>       return 0;
>   }
>   
> -int64_t replay_read_clock(unsigned int kind, int64_t raw_icount)
> +int64_t replay_read_clock(ReplayClockKind kind, int64_t raw_icount)
>   {
>       abort();
>       return 0;
> @@ -48,11 +49,11 @@ void replay_mutex_unlock(void)
>   {
>   }
>   
> -void replay_register_char_driver(Chardev *chr)
> +void replay_register_char_driver(struct Chardev *chr)
>   {
>   }
>   
> -void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
> +void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len)
>   {
>       abort();
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] stubs: update replay-tools to match replay.h types
  2022-07-04  7:58 [PATCH] stubs: update replay-tools to match replay.h types Claudio Fontana
  2022-07-04 14:18 ` Thomas Huth
@ 2022-07-28 11:51 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2022-07-28 11:51 UTC (permalink / raw)
  To: Claudio Fontana; +Cc: Thomas Huth, qemu-devel, Pavel Dovgalyuk

Queued, thanks.

Paolo




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-28 11:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04  7:58 [PATCH] stubs: update replay-tools to match replay.h types Claudio Fontana
2022-07-04 14:18 ` Thomas Huth
2022-07-28 11:51 ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.