* [PATCH -next] staging: pi433: depends on SPI
@ 2017-07-19 23:58 Randy Dunlap
2017-07-20 11:06 ` Wolf Entwicklungen
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2017-07-19 23:58 UTC (permalink / raw)
To: LKML, devel, Greg Kroah-Hartman; +Cc: Marcus Wolf
From: Randy Dunlap <rdunlap@infradead.org>
The pi433 driver uses SPI interfaces so it should depend on SPI.
Also, the "default n" can be removed since that is already the
default.
Fixes these build errors when SPI is not enabled:
drivers/staging/pi433/pi433_if.o: In function `pi433_probe':
pi433_if.c:(.text+0x1135): undefined reference to `spi_setup'
pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read'
drivers/staging/pi433/pi433_if.o: In function `pi433_init':
pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver'
drivers/staging/pi433/rf69.o: In function `rf69_read_fifo':
rf69.c:(.text+0x102): undefined reference to `spi_sync'
drivers/staging/pi433/rf69.o: In function `rf69_write_fifo':
rf69.c:(.text+0x248): undefined reference to `spi_sync'
drivers/staging/pi433/rf69.o: In function `rf69_read_reg':
rf69.c:(.text+0x290): undefined reference to `spi_write_then_read'
drivers/staging/pi433/rf69.o: In function `rf69_write_reg':
rf69.c:(.text+0x523): undefined reference to `spi_sync'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Marcus Wolf <linux@wolf-entwicklungen.de>
---
drivers/staging/pi433/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- next-2017-0719.orig/drivers/staging/pi433/Kconfig
+++ next-2017-0719/drivers/staging/pi433/Kconfig
@@ -1,6 +1,6 @@
config PI433
tristate "Pi433 - a 433MHz radio module for Raspberry Pi"
- default n
+ depends on SPI
---help---
This option allows you to enable support for the radio module Pi433.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] staging: pi433: depends on SPI
2017-07-19 23:58 [PATCH -next] staging: pi433: depends on SPI Randy Dunlap
@ 2017-07-20 11:06 ` Wolf Entwicklungen
0 siblings, 0 replies; 2+ messages in thread
From: Wolf Entwicklungen @ 2017-07-20 11:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, devel, Greg Kroah-Hartman, Marcus Wolf
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> The pi433 driver uses SPI interfaces so it should depend on SPI.
> Also, the "default n" can be removed since that is already the
> default.
>
> Fixes these build errors when SPI is not enabled:
>
> drivers/staging/pi433/pi433_if.o: In function `pi433_probe':
> pi433_if.c:(.text+0x1135): undefined reference to `spi_setup'
> pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read'
> drivers/staging/pi433/pi433_if.o: In function `pi433_init':
> pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver'
> drivers/staging/pi433/rf69.o: In function `rf69_read_fifo':
> rf69.c:(.text+0x102): undefined reference to `spi_sync'
> drivers/staging/pi433/rf69.o: In function `rf69_write_fifo':
> rf69.c:(.text+0x248): undefined reference to `spi_sync'
> drivers/staging/pi433/rf69.o: In function `rf69_read_reg':
> rf69.c:(.text+0x290): undefined reference to `spi_write_then_read'
> drivers/staging/pi433/rf69.o: In function `rf69_write_reg':
> rf69.c:(.text+0x523): undefined reference to `spi_sync'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Marcus Wolf <linux@wolf-entwicklungen.de>
> ---
> drivers/staging/pi433/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- next-2017-0719.orig/drivers/staging/pi433/Kconfig
> +++ next-2017-0719/drivers/staging/pi433/Kconfig
> @@ -1,6 +1,6 @@
> config PI433
> tristate "Pi433 - a 433MHz radio module for Raspberry Pi"
> - default n
> + depends on SPI
> ---help---
> This option allows you to enable support for the radio module Pi433.
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-20 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19 23:58 [PATCH -next] staging: pi433: depends on SPI Randy Dunlap
2017-07-20 11:06 ` Wolf Entwicklungen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.