All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/mm: Use CONT_PMD_SHIFT for ARM64_MEMSTART_SHIFT
Date: Mon, 14 Jun 2021 22:44:18 +1000	[thread overview]
Message-ID: <3d0bdd54-ea21-8300-83e6-6d8f258df4b3@redhat.com> (raw)
In-Reply-To: <1623663755-8949-1-git-send-email-anshuman.khandual@arm.com>

On 6/14/21 7:42 PM, Anshuman Khandual wrote:
> ARM64_MEMSTART_SIZE needs to be aligned with CONT_PMD_SIZE on 16K page size
> config. Hence just directly use CONT_PMD_SHIFT.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.13-rc6.
> 
>   arch/arm64/include/asm/kernel-pgtable.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Yes, It makes the code a bit more understandable.

Reviewed-by: Gavin Shan <gshan@redhat.com>

> diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/asm/kernel-pgtable.h
> index 88b8d681ad91..a848da2b4d90 100644
> --- a/arch/arm64/include/asm/kernel-pgtable.h
> +++ b/arch/arm64/include/asm/kernel-pgtable.h
> @@ -125,7 +125,7 @@
>   #if defined(CONFIG_ARM64_4K_PAGES)
>   #define ARM64_MEMSTART_SHIFT		PUD_SHIFT
>   #elif defined(CONFIG_ARM64_16K_PAGES)
> -#define ARM64_MEMSTART_SHIFT		(PMD_SHIFT + 5)
> +#define ARM64_MEMSTART_SHIFT		CONT_PMD_SHIFT
>   #else
>   #define ARM64_MEMSTART_SHIFT		PMD_SHIFT
>   #endif
> 


WARNING: multiple messages have this Message-ID (diff)
From: Gavin Shan <gshan@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/mm: Use CONT_PMD_SHIFT for ARM64_MEMSTART_SHIFT
Date: Mon, 14 Jun 2021 22:44:18 +1000	[thread overview]
Message-ID: <3d0bdd54-ea21-8300-83e6-6d8f258df4b3@redhat.com> (raw)
In-Reply-To: <1623663755-8949-1-git-send-email-anshuman.khandual@arm.com>

On 6/14/21 7:42 PM, Anshuman Khandual wrote:
> ARM64_MEMSTART_SIZE needs to be aligned with CONT_PMD_SIZE on 16K page size
> config. Hence just directly use CONT_PMD_SHIFT.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.13-rc6.
> 
>   arch/arm64/include/asm/kernel-pgtable.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Yes, It makes the code a bit more understandable.

Reviewed-by: Gavin Shan <gshan@redhat.com>

> diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/asm/kernel-pgtable.h
> index 88b8d681ad91..a848da2b4d90 100644
> --- a/arch/arm64/include/asm/kernel-pgtable.h
> +++ b/arch/arm64/include/asm/kernel-pgtable.h
> @@ -125,7 +125,7 @@
>   #if defined(CONFIG_ARM64_4K_PAGES)
>   #define ARM64_MEMSTART_SHIFT		PUD_SHIFT
>   #elif defined(CONFIG_ARM64_16K_PAGES)
> -#define ARM64_MEMSTART_SHIFT		(PMD_SHIFT + 5)
> +#define ARM64_MEMSTART_SHIFT		CONT_PMD_SHIFT
>   #else
>   #define ARM64_MEMSTART_SHIFT		PMD_SHIFT
>   #endif
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-14 10:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  9:42 [PATCH] arm64/mm: Use CONT_PMD_SHIFT for ARM64_MEMSTART_SHIFT Anshuman Khandual
2021-06-14  9:42 ` Anshuman Khandual
2021-06-14 12:44 ` Gavin Shan [this message]
2021-06-14 12:44   ` Gavin Shan
2021-06-14 15:16 ` Catalin Marinas
2021-06-14 15:16   ` Catalin Marinas
2021-06-15 12:06 ` Will Deacon
2021-06-15 12:06   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d0bdd54-ea21-8300-83e6-6d8f258df4b3@redhat.com \
    --to=gshan@redhat.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.