* [PATCH] fio: remove duplicate global definition of tsc_reliable
@ 2020-01-31 19:19 Eric Sandeen
2020-02-06 17:52 ` Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2020-01-31 19:19 UTC (permalink / raw)
To: fio
From: Eric Sandeen <sandeen@redhat.com>
Newer gcc v10 complains about globals being defined twice due to
a new default -fno-common flag. This causes build failures:
LINK t/fio-dedupe
/usr/bin/ld: t/arch.o:(.bss+0x4): multiple definition of `tsc_reliable'; gettime.o:(.bss+0x4): first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:499: t/fio-dedupe] Error 1
Each of the tests which call arch_init() to initialize tsc_reliable:
File Function Line
1 t/dedupe.c main 536 arch_init(argv);
2 t/lfsr-test.c main 37 arch_init(argv);
3 t/stest.c main 86 arch_init(argv);
already link with gettime.o which defines tsc_reliable,
so there is no need to provide it from t/arch.c
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I can't really tell if this is the right fix across all arches, but
maybe someone smarter than me can sort it out? :)
diff --git a/t/arch.c b/t/arch.c
index bd28a848..a72cef3a 100644
--- a/t/arch.c
+++ b/t/arch.c
@@ -1,5 +1,4 @@
#include "../arch/arch.h"
unsigned long arch_flags = 0;
-bool tsc_reliable;
int arch_random;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fio: remove duplicate global definition of tsc_reliable
2020-01-31 19:19 [PATCH] fio: remove duplicate global definition of tsc_reliable Eric Sandeen
@ 2020-02-06 17:52 ` Eric Sandeen
2020-02-18 20:35 ` Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2020-02-06 17:52 UTC (permalink / raw)
To: fio
On 1/31/20 1:19 PM, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@redhat.com>
>
> Newer gcc v10 complains about globals being defined twice due to
> a new default -fno-common flag. This causes build failures:
Ping?
Thanks,
-Eric
> LINK t/fio-dedupe
> /usr/bin/ld: t/arch.o:(.bss+0x4): multiple definition of `tsc_reliable'; gettime.o:(.bss+0x4): first defined here
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:499: t/fio-dedupe] Error 1
>
> Each of the tests which call arch_init() to initialize tsc_reliable:
>
> File Function Line
> 1 t/dedupe.c main 536 arch_init(argv);
> 2 t/lfsr-test.c main 37 arch_init(argv);
> 3 t/stest.c main 86 arch_init(argv);
>
> already link with gettime.o which defines tsc_reliable,
> so there is no need to provide it from t/arch.c
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I can't really tell if this is the right fix across all arches, but
> maybe someone smarter than me can sort it out? :)
>
> diff --git a/t/arch.c b/t/arch.c
> index bd28a848..a72cef3a 100644
> --- a/t/arch.c
> +++ b/t/arch.c
> @@ -1,5 +1,4 @@
> #include "../arch/arch.h"
>
> unsigned long arch_flags = 0;
> -bool tsc_reliable;
> int arch_random;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fio: remove duplicate global definition of tsc_reliable
2020-02-06 17:52 ` Eric Sandeen
@ 2020-02-18 20:35 ` Eric Sandeen
2020-02-27 2:50 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2020-02-18 20:35 UTC (permalink / raw)
To: fio
On 2/6/20 11:52 AM, Eric Sandeen wrote:
> On 1/31/20 1:19 PM, Eric Sandeen wrote:
>> From: Eric Sandeen <sandeen@redhat.com>
>>
>> Newer gcc v10 complains about globals being defined twice due to
>> a new default -fno-common flag. This causes build failures:
>
> Ping?
>
> Thanks,
> -Eric
Ok, well, this is in Fedora now in any case, since I needed to fix the FTBFS.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fio: remove duplicate global definition of tsc_reliable
2020-02-18 20:35 ` Eric Sandeen
@ 2020-02-27 2:50 ` Jens Axboe
2020-02-27 17:20 ` Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2020-02-27 2:50 UTC (permalink / raw)
To: Eric Sandeen, fio
On 2/18/20 1:35 PM, Eric Sandeen wrote:
> On 2/6/20 11:52 AM, Eric Sandeen wrote:
>> On 1/31/20 1:19 PM, Eric Sandeen wrote:
>>> From: Eric Sandeen <sandeen@redhat.com>
>>>
>>> Newer gcc v10 complains about globals being defined twice due to
>>> a new default -fno-common flag. This causes build failures:
>>
>> Ping?
>>
>> Thanks,
>> -Eric
>
> Ok, well, this is in Fedora now in any case, since I needed to fix the FTBFS.
Sorry, applied it. Don't always see mailing list patches if they aren't
CC'ed to me.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fio: remove duplicate global definition of tsc_reliable
2020-02-27 2:50 ` Jens Axboe
@ 2020-02-27 17:20 ` Eric Sandeen
0 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2020-02-27 17:20 UTC (permalink / raw)
To: Jens Axboe, fio
On 2/26/20 6:50 PM, Jens Axboe wrote:
> On 2/18/20 1:35 PM, Eric Sandeen wrote:
>> On 2/6/20 11:52 AM, Eric Sandeen wrote:
>>> On 1/31/20 1:19 PM, Eric Sandeen wrote:
>>>> From: Eric Sandeen <sandeen@redhat.com>
>>>>
>>>> Newer gcc v10 complains about globals being defined twice due to
>>>> a new default -fno-common flag. This causes build failures:
>>>
>>> Ping?
>>>
>>> Thanks,
>>> -Eric
>>
>> Ok, well, this is in Fedora now in any case, since I needed to fix the FTBFS.
>
> Sorry, applied it. Don't always see mailing list patches if they aren't
> CC'ed to me.
Oh, sorry. I'll keep that in mind.
Thanks!
-Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-27 17:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 19:19 [PATCH] fio: remove duplicate global definition of tsc_reliable Eric Sandeen
2020-02-06 17:52 ` Eric Sandeen
2020-02-18 20:35 ` Eric Sandeen
2020-02-27 2:50 ` Jens Axboe
2020-02-27 17:20 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.