[PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Diego Viola]

med_power_with_dipm causes my T450 to freeze with a SAMSUNG
MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index a9dd4ea7467d..6e594644cb1d 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	/* These specific Samsung models/firmware-revs do not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
 	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
-- 
2.19.1

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Hans de Goede]

Hi,

On 26-10-18 15:45, Diego Viola wrote:
> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> 
> Switching the LPM to max_performance fixes this issue.
> 
> Signed-off-by: Diego Viola <diego.viola@gmail.com>

Thanks, looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/ata/libata-core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index a9dd4ea7467d..6e594644cb1d 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>   	/* These specific Samsung models/firmware-revs do not handle LPM well */
>   	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
>   	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> +	{ "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
>   
>   	/* devices that don't properly handle queued TRIM commands */
>   	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
> 

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Jens Axboe]

On 10/26/18 7:45 AM, Diego Viola wrote:
> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> 
> Switching the LPM to max_performance fixes this issue.

Applied, thanks.

-- 
Jens Axboe

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Diego Viola]

On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 10/26/18 7:45 AM, Diego Viola wrote:
> > med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> >
> > Switching the LPM to max_performance fixes this issue.
>
> Applied, thanks.
>
> --
> Jens Axboe
>

Jens, Hans,

Thank you.

Diego

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Diego Viola]

On Fri, Oct 26, 2018 at 5:36 PM Diego Viola <diego.viola@gmail.com> wrote:
>
> On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > On 10/26/18 7:45 AM, Diego Viola wrote:
> > > med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> > > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> > >
> > > Switching the LPM to max_performance fixes this issue.
> >
> > Applied, thanks.
> >
> > --
> > Jens Axboe
> >
>
> Jens, Hans,
>
> Thank you.
>
> Diego

Hi Hans and Jens,

I just wanted to give you guys an update about this problem.

I've managed to update my SSD firmware to the latest version[1].

For running the update, I've had to install Windows 10, ran the
firmware update, remove Windows and reinstall Arch Linux.

The latest version of the firmware is DXT04L5Q, and it looks like
there hasn't been a new update since 2015.

I'll be running with med_power_with_dipm and hope this firmware update
fixes the problem, if it doesn't and I get another freeze, I'll send
another patch blacklisting the drive completely. Is that OK?

1. https://support.lenovo.com/br/en/downloads/ds038904

Thanks and Best Regards,
Diego

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Hans de Goede]

Hi,

On 28-10-18 05:13, Diego Viola wrote:
> On Fri, Oct 26, 2018 at 5:36 PM Diego Viola <diego.viola@gmail.com> wrote:
>>
>> On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 10/26/18 7:45 AM, Diego Viola wrote:
>>>> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
>>>> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
>>>>
>>>> Switching the LPM to max_performance fixes this issue.
>>>
>>> Applied, thanks.
>>>
>>> --
>>> Jens Axboe
>>>
>>
>> Jens, Hans,
>>
>> Thank you.
>>
>> Diego
> 
> Hi Hans and Jens,
> 
> I just wanted to give you guys an update about this problem.
> 
> I've managed to update my SSD firmware to the latest version[1].
> 
> For running the update, I've had to install Windows 10, ran the
> firmware update, remove Windows and reinstall Arch Linux.
> 
> The latest version of the firmware is DXT04L5Q, and it looks like
> there hasn't been a new update since 2015.
> 
> I'll be running with med_power_with_dipm and hope this firmware update
> fixes the problem, if it doesn't and I get another freeze, I'll send
> another patch blacklisting the drive completely. Is that OK?

Yes, if it still happens with the latest firmware then blacklisting
it completely is the right thing to do.

Unfortunately for reasons which I do not understand OEM SSDs often use
different (customized?) firmware compared to the model on which they
are based and often see less updates and seem to have more bugs :|

Regards,

Hans

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

[Diego Viola]

Hi Hans,

On Sun, Oct 28, 2018 at 7:48 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 28-10-18 05:13, Diego Viola wrote:
> > On Fri, Oct 26, 2018 at 5:36 PM Diego Viola <diego.viola@gmail.com> wrote:
> >>
> >> On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe <axboe@kernel.dk> wrote:
> >>>
> >>> On 10/26/18 7:45 AM, Diego Viola wrote:
> >>>> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> >>>> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> >>>>
> >>>> Switching the LPM to max_performance fixes this issue.
> >>>
> >>> Applied, thanks.
> >>>
> >>> --
> >>> Jens Axboe
> >>>
> >>
> >> Jens, Hans,
> >>
> >> Thank you.
> >>
> >> Diego
> >
> > Hi Hans and Jens,
> >
> > I just wanted to give you guys an update about this problem.
> >
> > I've managed to update my SSD firmware to the latest version[1].
> >
> > For running the update, I've had to install Windows 10, ran the
> > firmware update, remove Windows and reinstall Arch Linux.
> >
> > The latest version of the firmware is DXT04L5Q, and it looks like
> > there hasn't been a new update since 2015.
> >
> > I'll be running with med_power_with_dipm and hope this firmware update
> > fixes the problem, if it doesn't and I get another freeze, I'll send
> > another patch blacklisting the drive completely. Is that OK?
>
> Yes, if it still happens with the latest firmware then blacklisting
> it completely is the right thing to do.
>
> Unfortunately for reasons which I do not understand OEM SSDs often use
> different (customized?) firmware compared to the model on which they
> are based and often see less updates and seem to have more bugs :|
>
> Regards,
>
> Hans

I've just got another freeze with the latest firmware while I was
watching some YouTube videos. I think it's safe to assume this drive
is borked and won't get better, I'll send another patch.

Thanks,
Diego