All of lore.kernel.org
 help / color / mirror / Atom feed
* possible clash between 8ea0f2ba0fa3f and 4affafd7bec7c both decrementing refcount
@ 2022-04-27  9:34 Oliver Neukum
  2022-04-27 10:29 ` Alexey Khoroshilov
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2022-04-27  9:34 UTC (permalink / raw)
  To: Alexey Khoroshilov, Yu Kuai; +Cc: linux-media

Hi,

I was looking at those two patches and I cannot help myself,
it looks to me like they are both fixing the same issue in two
different ways.
Could you clarify?

    Regards
        Oliver


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: possible clash between 8ea0f2ba0fa3f and 4affafd7bec7c both decrementing refcount
  2022-04-27  9:34 possible clash between 8ea0f2ba0fa3f and 4affafd7bec7c both decrementing refcount Oliver Neukum
@ 2022-04-27 10:29 ` Alexey Khoroshilov
  2022-04-28 11:28   ` Oliver Neukum
  0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2022-04-27 10:29 UTC (permalink / raw)
  To: Oliver Neukum, Yu Kuai; +Cc: linux-media

On 27.04.2022 12:34, Oliver Neukum wrote:
> Hi,
> 
> I was looking at those two patches and I cannot help myself,
> it looks to me like they are both fixing the same issue in two
> different ways.
> Could you clarify?

Hi!

As far as I can see

8ea0f2ba0fa3f
adds of_node_put(node);

while 4affafd7bec7c
adds put_device(pm->larbvenclt & pm->larbvenc);

Which clash do you mean?

Best regards,
Alexey

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: possible clash between 8ea0f2ba0fa3f and 4affafd7bec7c both decrementing refcount
  2022-04-27 10:29 ` Alexey Khoroshilov
@ 2022-04-28 11:28   ` Oliver Neukum
  0 siblings, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2022-04-28 11:28 UTC (permalink / raw)
  To: Alexey Khoroshilov, Oliver Neukum, Yu Kuai; +Cc: linux-media



On 27.04.22 12:29, Alexey Khoroshilov wrote:
> On 27.04.2022 12:34, Oliver Neukum wrote:
>> Hi,
>>
>> I was looking at those two patches and I cannot help myself,
>> it looks to me like they are both fixing the same issue in two
>> different ways.
>> Could you clarify?
> Hi!
>
> As far as I can see
>
> 8ea0f2ba0fa3f
> adds of_node_put(node);
>
> while 4affafd7bec7c
> adds put_device(pm->larbvenclt & pm->larbvenc);
>
> Which clash do you mean?
>
Hi,

thank you. I think I had a brain short circuit. It is clear to me,
why of_put_node() needed to be added in  8ea0f2ba0fa3f.
Yet I just cannot see where the get_device() corresponding
to the put_device added in  4affafd7bec7c is. So I jumped
to conclusions.

    Sorry
        Oliver


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-28 11:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27  9:34 possible clash between 8ea0f2ba0fa3f and 4affafd7bec7c both decrementing refcount Oliver Neukum
2022-04-27 10:29 ` Alexey Khoroshilov
2022-04-28 11:28   ` Oliver Neukum

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.