All of lore.kernel.org
 help / color / mirror / Atom feed
From: Apurva Nandan <a-nandan@ti.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Mark Brown <broonie@kernel.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>, Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH 03/13] mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto
Date: Fri, 20 Aug 2021 15:22:54 +0530	[thread overview]
Message-ID: <3de32033-2a6e-bc46-a65a-4027ce78c6d6@ti.com> (raw)
In-Reply-To: <20210806203013.30a41fd5@xps13>

Hi Miquèl,

On 07/08/21 12:00 am, Miquel Raynal wrote:
> Hi Apurva,
> 
> Apurva Nandan <a-nandan@ti.com> wrote on Tue, 13 Jul 2021 13:05:28
> +0000:
> 
>> Currently, the op macros in spinand.h don't give the option to setup
>> any non-array access instructions for Dual/Quad/Octal DTR SPI bus.
>> Having a function that setups the op based on reg_proto would be
>> better than trying to write all the setup logic in op macros.
>>
>> Create a spimem_setup_op() that would setup cmd, addr, dummy and data
>> phase of the spi_mem op, for the given spinand->reg_proto. And hence,
>> call the spimem_setup_op() before executing any spi_mem op.
>>
>> Note: In this commit, spimem_setup_op() isn't called in the
>> read_reg_op(), write_reg_op() and wait() functions, as they need
>> modifications in address value and data nbytes when in Octal DTR mode.
>> This will be fixed in a later commit.
> 
> Thanks for this series!
> 
> So far I am fine with your changes, but I don't like the setup_op()
> naming much. I don't yet have a better idea, could you propose
> something more meaningful?
> 

I made this similar to the spi_nor_spimem_setup_op(), which essentially 
does the same task as this in the spi-nor core.

Other names that I can think of are:

- config_op(), adjust_op(), amend_op(), patch_op()

or

- handle_op_variations(), apply_op_variations()

What do you suggest?

>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> 
> Thanks,
> Miquèl
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 
Thanks,
Apurva Nandan

WARNING: multiple messages have this Message-ID (diff)
From: Apurva Nandan <a-nandan@ti.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Mark Brown <broonie@kernel.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>, Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH 03/13] mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto
Date: Fri, 20 Aug 2021 15:22:54 +0530	[thread overview]
Message-ID: <3de32033-2a6e-bc46-a65a-4027ce78c6d6@ti.com> (raw)
In-Reply-To: <20210806203013.30a41fd5@xps13>

Hi Miquèl,

On 07/08/21 12:00 am, Miquel Raynal wrote:
> Hi Apurva,
> 
> Apurva Nandan <a-nandan@ti.com> wrote on Tue, 13 Jul 2021 13:05:28
> +0000:
> 
>> Currently, the op macros in spinand.h don't give the option to setup
>> any non-array access instructions for Dual/Quad/Octal DTR SPI bus.
>> Having a function that setups the op based on reg_proto would be
>> better than trying to write all the setup logic in op macros.
>>
>> Create a spimem_setup_op() that would setup cmd, addr, dummy and data
>> phase of the spi_mem op, for the given spinand->reg_proto. And hence,
>> call the spimem_setup_op() before executing any spi_mem op.
>>
>> Note: In this commit, spimem_setup_op() isn't called in the
>> read_reg_op(), write_reg_op() and wait() functions, as they need
>> modifications in address value and data nbytes when in Octal DTR mode.
>> This will be fixed in a later commit.
> 
> Thanks for this series!
> 
> So far I am fine with your changes, but I don't like the setup_op()
> naming much. I don't yet have a better idea, could you propose
> something more meaningful?
> 

I made this similar to the spi_nor_spimem_setup_op(), which essentially 
does the same task as this in the spi-nor core.

Other names that I can think of are:

- config_op(), adjust_op(), amend_op(), patch_op()

or

- handle_op_variations(), apply_op_variations()

What do you suggest?

>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> 
> Thanks,
> Miquèl
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 
Thanks,
Apurva Nandan

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-08-20  9:53 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 13:05 [PATCH 00/13] mtd: spinand: Add Octal DTR SPI (8D-8D-8D) mode support Apurva Nandan
2021-07-13 13:05 ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 01/13] spi: spi-mem: Add DTR templates for cmd, address, dummy and data phase Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-07-14 17:06   ` Mark Brown
2021-07-14 17:06     ` Mark Brown
2021-08-23  7:57   ` Boris Brezillon
2021-08-23  7:57     ` Boris Brezillon
2021-07-13 13:05 ` [PATCH 02/13] mtd: spinand: Add enum spinand_proto to indicate current SPI IO mode Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 03/13] mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 18:30   ` Miquel Raynal
2021-08-06 18:30     ` Miquel Raynal
2021-08-20  9:52     ` Apurva Nandan [this message]
2021-08-20  9:52       ` Apurva Nandan
2021-08-20 12:08       ` Miquel Raynal
2021-08-20 12:08         ` Miquel Raynal
2021-08-23  7:11         ` Boris Brezillon
2021-08-23  7:11           ` Boris Brezillon
2021-08-23  7:24           ` Miquel Raynal
2021-08-23  7:24             ` Miquel Raynal
2021-07-13 13:05 ` [PATCH 04/13] mtd: spinand: Fix odd byte addr and data phase in read/write reg op and write VCR op for Octal DTR mode Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 18:43   ` Miquel Raynal
2021-08-06 18:43     ` Miquel Raynal
2021-08-20 10:27     ` Apurva Nandan
2021-08-20 10:27       ` Apurva Nandan
2021-08-20 12:06       ` Miquel Raynal
2021-08-20 12:06         ` Miquel Raynal
2021-07-13 13:05 ` [PATCH 05/13] mtd: spinand: Add adjust_op() in manufacturer_ops to modify the ops for manufacturer specific changes Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 06/13] mtd: spinand: Add macros for Octal DTR page read and write operations Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 18:54   ` Miquel Raynal
2021-08-06 18:54     ` Miquel Raynal
2021-08-20 10:35     ` Apurva Nandan
2021-08-20 10:35       ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 07/13] mtd: spinand: Allow enabling Octal DTR mode in the core Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 18:58   ` Miquel Raynal
2021-08-06 18:58     ` Miquel Raynal
2021-08-20 10:41     ` Apurva Nandan
2021-08-20 10:41       ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 08/13] mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is missing in manufacturer_op Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:01   ` Miquel Raynal
2021-08-06 19:01     ` Miquel Raynal
2021-08-20 11:26     ` Apurva Nandan
2021-08-20 11:26       ` Apurva Nandan
2021-08-20 12:14       ` Miquel Raynal
2021-08-20 12:14         ` Miquel Raynal
2021-08-20 13:54         ` Apurva Nandan
2021-08-20 13:54           ` Apurva Nandan
2021-08-20 14:38           ` Miquel Raynal
2021-08-20 14:38             ` Miquel Raynal
2021-08-20 15:53             ` Apurva Nandan
2021-08-20 15:53               ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 09/13] mtd: spinand: Add support for write volatile configuration register op Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:05   ` Miquel Raynal
2021-08-06 19:05     ` Miquel Raynal
2021-08-20 11:30     ` Apurva Nandan
2021-08-20 11:30       ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 10/13] mtd: spinand: Add octal_dtr_enable() for Winbond manufacturer_ops Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:06   ` Miquel Raynal
2021-08-06 19:06     ` Miquel Raynal
2021-08-20 11:31     ` Apurva Nandan
2021-08-20 11:31       ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 11/13] mtd: spinand: Add support for Power-on-Reset (PoR) instruction Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:08   ` Miquel Raynal
2021-08-06 19:08     ` Miquel Raynal
2021-08-20 11:39     ` Apurva Nandan
2021-08-20 11:39       ` Apurva Nandan
2021-08-20 12:18       ` Miquel Raynal
2021-08-20 12:18         ` Miquel Raynal
2021-08-20 13:41         ` Apurva Nandan
2021-08-20 13:41           ` Apurva Nandan
2021-08-20 14:17           ` Miquel Raynal
2021-08-20 14:17             ` Miquel Raynal
2021-08-20 15:56             ` Apurva Nandan
2021-08-20 15:56               ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 12/13] mtd: spinand: Perform Power-on-Reset when runtime_pm suspend is issued Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:12   ` Miquel Raynal
2021-08-06 19:12     ` Miquel Raynal
2021-08-20 11:45     ` Apurva Nandan
2021-08-20 11:45       ` Apurva Nandan
2021-07-13 13:05 ` [PATCH 13/13] mtd: spinand: Add support for Winbond W35N01JW SPI NAND flash Apurva Nandan
2021-07-13 13:05   ` Apurva Nandan
2021-08-06 19:14   ` Miquel Raynal
2021-08-06 19:14     ` Miquel Raynal
2021-08-20 11:51     ` Apurva Nandan
2021-08-20 11:51       ` Apurva Nandan
2021-08-20 12:02       ` Miquel Raynal
2021-08-20 12:02         ` Miquel Raynal
2021-08-20 13:14         ` Apurva Nandan
2021-08-20 13:14           ` Apurva Nandan
2021-07-20 16:53 ` [PATCH 00/13] mtd: spinand: Add Octal DTR SPI (8D-8D-8D) mode support Nandan, Apurva
2021-07-20 16:53   ` Nandan, Apurva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3de32033-2a6e-bc46-a65a-4027ce78c6d6@ti.com \
    --to=a-nandan@ti.com \
    --cc=boris.brezillon@collabora.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.