Re: [PATCH 04/21] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Joel Stanley <joel@jms.id.au>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-aspeed <linux-aspeed@lists.ozlabs.org>,
	narmstrong@baylibre.com, "David Airlie" <airlied@linux.ie>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	liviu.dudau@arm.com, stefan@agner.ch, philippe.cornu@st.com,
	paul@crapouillou.net,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	benjamin.gaignard@linaro.org, mihail.atanassov@arm.com,
	"Sam Ravnborg" <sam@ravnborg.org>,
	alexandre.torgue@st.com, "Marek Vasut" <marex@denx.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	abrodkin@synopsys.com,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	xinliang.liu@linaro.org, kong.kongxinwei@hisilicon.com,
	tomi.valkeinen@ti.com, james.qian.wang@arm.com,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	puck.chen@hisilicon.com, "Sascha Hauer" <s.hauer@pengutronix.de>,
	alison.wang@nxp.com,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	mripard@kernel.org, john.stultz@linaro.org, jsarha@ti.com,
	"Chen-Yu Tsai" <wens@csie.org>,
	vincent.abriou@st.com,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	dri-devel@lists.freedesktop.org, yannick.fertre@st.com,
	kieran.bingham+renesas@ideasonboard.com,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Kevin Hilman" <khilman@baylibre.com>,
	zourongrong@gmail.com, "Shawn Guo" <shawnguo@kernel.org>,
	brian.starkey@arm.com
Subject: Re: [PATCH 04/21] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS
Date: Fri, 9 Oct 2020 10:01:04 +0200	[thread overview]
Message-ID: <3df12a74-d8f3-d607-78ff-5a0f21e86cb9@suse.de> (raw)
In-Reply-To: <CACPK8XcGOAjocCMp9ubgQpfiBaqSj61i_frSU7ZdiKO_uSt-hQ@mail.gmail.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 2022 bytes --]

Hi

Am 09.10.20 um 09:54 schrieb Joel Stanley:
> On Fri, 22 May 2020 at 13:52, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver
>> to their defaults. No functional changes are made.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> I just found this in my inbox. I assume it has not been applied as you
> were after a review.

The patchset as a whole got an A-b and was merged a while ago.

> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>

Nevertheless thanks for taking a look at the patch.

Best regards
Thomas

> 
> I will apply it to drm-misc-next.
> 
> Cheers,
> 
> Joel
> 
>> ---
>>  drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
>> index 6b27242b9ee3c..1167ff78e24a3 100644
>> --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
>> +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
>> @@ -188,12 +188,7 @@ DEFINE_DRM_GEM_CMA_FOPS(fops);
>>
>>  static struct drm_driver aspeed_gfx_driver = {
>>         .driver_features        = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> -       .gem_create_object      = drm_cma_gem_create_object_default_funcs,
>> -       .dumb_create            = drm_gem_cma_dumb_create,
>> -       .prime_handle_to_fd     = drm_gem_prime_handle_to_fd,
>> -       .prime_fd_to_handle     = drm_gem_prime_fd_to_handle,
>> -       .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> -       .gem_prime_mmap         = drm_gem_prime_mmap,
>> +       DRM_GEM_CMA_DRIVER_OPS,
>>         .fops = &fops,
>>         .name = "aspeed-gfx-drm",
>>         .desc = "ASPEED GFX DRM",
>> --
>> 2.26.2
>>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel