[PATCH] USB: serial: pl2303: add device id for HP LM930 Display

[PATCH] USB: serial: pl2303: add device id for HP LM930 Display

[Scott Chen]

Add the device id for the HPLM930Display which is a PL2303GC based device

Signed-off-by: Scott Chen <scott@labau.com.tw>
---
 drivers/usb/serial/pl2303.c | 1 +
 drivers/usb/serial/pl2303.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 88b284d61681..1d878d05a658 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -106,6 +106,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
 	{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
 	{ USB_DEVICE(HP_VENDOR_ID, HP_LM920_PRODUCT_ID) },
+	{ USB_DEVICE(HP_VENDOR_ID, HP_LM930_PRODUCT_ID) },
 	{ USB_DEVICE(HP_VENDOR_ID, HP_LM940_PRODUCT_ID) },
 	{ USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
 	{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index c5406452b774..9d8102639e16 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -135,6 +135,7 @@
 #define HP_TD620_PRODUCT_ID	0x0956
 #define HP_LD960_PRODUCT_ID	0x0b39
 #define HP_LD381_PRODUCT_ID	0x0f7f
+#define HP_LM930_PRODUCT_ID     0x0f9b
 #define HP_LCM220_PRODUCT_ID	0x3139
 #define HP_LCM960_PRODUCT_ID	0x3239
 #define HP_LD220_PRODUCT_ID	0x3524
-- 
2.17.1

Re: [PATCH] USB: serial: pl2303: add device id for HP LM930 Display

[Greg Kroah-Hartman]

On Mon, Apr 25, 2022 at 03:24:52PM +0800, Scott Chen wrote:
> Add the device id for the HPLM930Display which is a PL2303GC based device
> 
> Signed-off-by: Scott Chen <scott@labau.com.tw>
> ---
>  drivers/usb/serial/pl2303.c | 1 +
>  drivers/usb/serial/pl2303.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 88b284d61681..1d878d05a658 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -106,6 +106,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
>  	{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
>  	{ USB_DEVICE(HP_VENDOR_ID, HP_LM920_PRODUCT_ID) },
> +	{ USB_DEVICE(HP_VENDOR_ID, HP_LM930_PRODUCT_ID) },
>  	{ USB_DEVICE(HP_VENDOR_ID, HP_LM940_PRODUCT_ID) },
>  	{ USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
>  	{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index c5406452b774..9d8102639e16 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -135,6 +135,7 @@
>  #define HP_TD620_PRODUCT_ID	0x0956
>  #define HP_LD960_PRODUCT_ID	0x0b39
>  #define HP_LD381_PRODUCT_ID	0x0f7f
> +#define HP_LM930_PRODUCT_ID     0x0f9b

Please use a tab here too.

thanks,

greg k-h

Re: [PATCH] USB: serial: pl2303: add device id for HP LM930 Display

[Sergey Shtylyov]

Hello!

On 4/25/22 10:24 AM, Scott Chen wrote:

> Add the device id for the HPLM930Display which is a PL2303GC based device
> 
> Signed-off-by: Scott Chen <scott@labau.com.tw>

[...]
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index c5406452b774..9d8102639e16 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -135,6 +135,7 @@
>  #define HP_TD620_PRODUCT_ID	0x0956
>  #define HP_LD960_PRODUCT_ID	0x0b39
>  #define HP_LD381_PRODUCT_ID	0x0f7f
> +#define HP_LM930_PRODUCT_ID     0x0f9b

  Indent with a tab please, like the entries above and below.

>  #define HP_LCM220_PRODUCT_ID	0x3139
>  #define HP_LCM960_PRODUCT_ID	0x3239
>  #define HP_LD220_PRODUCT_ID	0x3524

MBR, Sergey