* drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
@ 2021-03-01 7:02 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-03-01 7:02 UTC (permalink / raw)
To: kbuild, Chandan Uddaraju
Cc: lkp, kbuild-all, linux-kernel, Rob Clark, Vara Reddy,
Tanmay Shah, Abhinav Kumar, Kuogee Hsieh, Guenter Roeck,
Stephen Boyd
[-- Attachment #1: Type: text/plain, Size: 2621 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add displayPort driver support
config: arm64-randconfig-m031-20210301 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn: inconsistent indenting
vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private *hpd_priv;
c943b4948b5848 Chandan Uddaraju 2020-08-27 31
c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv = container_of(dp_usbpd, struct dp_hpd_private,
c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
c943b4948b5848 Chandan Uddaraju 2020-08-27 34
c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high = hpd;
c943b4948b5848 Chandan Uddaraju 2020-08-27 36
c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably || was intended instead of &&. If "hpd_priv->dp_cb" is NULL
this will Oops.
c943b4948b5848 Chandan Uddaraju 2020-08-27 38 && !hpd_priv->dp_cb->disconnect) {
c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb not initialized\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 43 hpd_priv->dp_cb->configure(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
c943b4948b5848 Chandan Uddaraju 2020-08-27 45 hpd_priv->dp_cb->disconnect(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 46
c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33102 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
@ 2021-03-01 7:02 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-03-01 7:02 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2669 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add displayPort driver support
config: arm64-randconfig-m031-20210301 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn: inconsistent indenting
vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private *hpd_priv;
c943b4948b5848 Chandan Uddaraju 2020-08-27 31
c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv = container_of(dp_usbpd, struct dp_hpd_private,
c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
c943b4948b5848 Chandan Uddaraju 2020-08-27 34
c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high = hpd;
c943b4948b5848 Chandan Uddaraju 2020-08-27 36
c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably || was intended instead of &&. If "hpd_priv->dp_cb" is NULL
this will Oops.
c943b4948b5848 Chandan Uddaraju 2020-08-27 38 && !hpd_priv->dp_cb->disconnect) {
c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb not initialized\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 43 hpd_priv->dp_cb->configure(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
c943b4948b5848 Chandan Uddaraju 2020-08-27 45 hpd_priv->dp_cb->disconnect(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 46
c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33102 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
@ 2021-03-01 7:02 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-03-01 7:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2669 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add displayPort driver support
config: arm64-randconfig-m031-20210301 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn: inconsistent indenting
vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private *hpd_priv;
c943b4948b5848 Chandan Uddaraju 2020-08-27 31
c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv = container_of(dp_usbpd, struct dp_hpd_private,
c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
c943b4948b5848 Chandan Uddaraju 2020-08-27 34
c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high = hpd;
c943b4948b5848 Chandan Uddaraju 2020-08-27 36
c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably || was intended instead of &&. If "hpd_priv->dp_cb" is NULL
this will Oops.
c943b4948b5848 Chandan Uddaraju 2020-08-27 38 && !hpd_priv->dp_cb->disconnect) {
c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb not initialized\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 43 hpd_priv->dp_cb->configure(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
c943b4948b5848 Chandan Uddaraju 2020-08-27 45 hpd_priv->dp_cb->disconnect(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 46
c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33102 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
2021-03-01 7:02 ` Dan Carpenter
@ 2021-03-04 0:26 ` abhinavk
-1 siblings, 0 replies; 6+ messages in thread
From: abhinavk @ 2021-03-04 0:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: kbuild, Chandan Uddaraju, lkp, kbuild-all, linux-kernel,
Rob Clark, Vara Reddy, Tanmay Shah, Kuogee Hsieh, Guenter Roeck,
Stephen Boyd
Hi Dan
Thanks for reporting this, will submit a change to fix this.
Abhinav
On 2021-02-28 23:02, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
> commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add
> displayPort driver support
> config: arm64-randconfig-m031-20210301 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we
> previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
> drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn:
> inconsistent indenting
>
> vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
>
> c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int
> dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
> c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private
> *hpd_priv;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 31
> c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv =
> container_of(dp_usbpd, struct dp_hpd_private,
> c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 34
> c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high =
> hpd;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 36
> c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb
> && !hpd_priv->dp_cb->configure
>
> ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Probably || was intended instead of &&. If "hpd_priv->dp_cb" is NULL
> this will Oops.
>
> c943b4948b5848 Chandan Uddaraju 2020-08-27 38 &&
> !hpd_priv->dp_cb->disconnect) {
> c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb
> not initialized\n");
> c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
> c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27 43
> hpd_priv->dp_cb->configure(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
> c943b4948b5848 Chandan Uddaraju 2020-08-27 45
> hpd_priv->dp_cb->disconnect(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 46
> c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
@ 2021-03-04 0:26 ` abhinavk
0 siblings, 0 replies; 6+ messages in thread
From: abhinavk @ 2021-03-04 0:26 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2862 bytes --]
Hi Dan
Thanks for reporting this, will submit a change to fix this.
Abhinav
On 2021-02-28 23:02, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
> commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add
> displayPort driver support
> config: arm64-randconfig-m031-20210301 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we
> previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
> drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn:
> inconsistent indenting
>
> vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
>
> c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int
> dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
> c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private
> *hpd_priv;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 31
> c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv =
> container_of(dp_usbpd, struct dp_hpd_private,
> c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 34
> c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high =
> hpd;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 36
> c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb
> && !hpd_priv->dp_cb->configure
>
> ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Probably || was intended instead of &&. If "hpd_priv->dp_cb" is NULL
> this will Oops.
>
> c943b4948b5848 Chandan Uddaraju 2020-08-27 38 &&
> !hpd_priv->dp_cb->disconnect) {
> c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb
> not initialized\n");
> c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
> c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27 43
> hpd_priv->dp_cb->configure(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
> c943b4948b5848 Chandan Uddaraju 2020-08-27 45
> hpd_priv->dp_cb->disconnect(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27 46
> c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
> c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
@ 2021-03-01 5:40 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-03-01 5:40 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3064 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Chandan Uddaraju <chandanu@codeaurora.org>
CC: Rob Clark <robdclark@chromium.org>
CC: Vara Reddy <varar@codeaurora.org>
CC: Tanmay Shah <tanmay@codeaurora.org>
CC: Abhinav Kumar <abhinavk@codeaurora.org>
CC: Kuogee Hsieh <khsieh@codeaurora.org>
CC: Guenter Roeck <groeck@chromium.org>
CC: Stephen Boyd <swboyd@chromium.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add displayPort driver support
date: 6 months ago
:::::: branch date: 6 hours ago
:::::: commit date: 6 months ago
config: arm64-randconfig-m031-20210301 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn: inconsistent indenting
vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
c943b4948b5848 Chandan Uddaraju 2020-08-27 26
c943b4948b5848 Chandan Uddaraju 2020-08-27 27 static int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 28 {
c943b4948b5848 Chandan Uddaraju 2020-08-27 29 int rc = 0;
c943b4948b5848 Chandan Uddaraju 2020-08-27 30 struct dp_hpd_private *hpd_priv;
c943b4948b5848 Chandan Uddaraju 2020-08-27 31
c943b4948b5848 Chandan Uddaraju 2020-08-27 32 hpd_priv = container_of(dp_usbpd, struct dp_hpd_private,
c943b4948b5848 Chandan Uddaraju 2020-08-27 33 dp_usbpd);
c943b4948b5848 Chandan Uddaraju 2020-08-27 34
c943b4948b5848 Chandan Uddaraju 2020-08-27 35 dp_usbpd->hpd_high = hpd;
c943b4948b5848 Chandan Uddaraju 2020-08-27 36
c943b4948b5848 Chandan Uddaraju 2020-08-27 @37 if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
c943b4948b5848 Chandan Uddaraju 2020-08-27 38 && !hpd_priv->dp_cb->disconnect) {
c943b4948b5848 Chandan Uddaraju 2020-08-27 39 pr_err("hpd dp_cb not initialized\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27 40 return -EINVAL;
c943b4948b5848 Chandan Uddaraju 2020-08-27 41 }
c943b4948b5848 Chandan Uddaraju 2020-08-27 42 if (hpd)
c943b4948b5848 Chandan Uddaraju 2020-08-27 43 hpd_priv->dp_cb->configure(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 44 else
c943b4948b5848 Chandan Uddaraju 2020-08-27 45 hpd_priv->dp_cb->disconnect(hpd_priv->dev);
c943b4948b5848 Chandan Uddaraju 2020-08-27 46
c943b4948b5848 Chandan Uddaraju 2020-08-27 47 return rc;
c943b4948b5848 Chandan Uddaraju 2020-08-27 48 }
c943b4948b5848 Chandan Uddaraju 2020-08-27 49
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33102 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-04 1:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 7:02 drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37) Dan Carpenter
2021-03-01 7:02 ` Dan Carpenter
2021-03-01 7:02 ` Dan Carpenter
2021-03-04 0:26 ` abhinavk
2021-03-04 0:26 ` abhinavk
-- strict thread matches above, loose matches on Subject: below --
2021-03-01 5:40 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.