* [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820
@ 2019-12-05 12:13 Igor Druzhinin
2019-12-05 12:20 ` Durrant, Paul
0 siblings, 1 reply; 4+ messages in thread
From: Igor Druzhinin @ 2019-12-05 12:13 UTC (permalink / raw)
To: xen-devel; +Cc: linux, pdurrant, jbeulich, Igor Druzhinin
The locking responsibilities have changed and a premature break in
this section now causes the following assertion:
Assertion '!preempt_count()' failed at preempt.c:36
Suggested-by: Paul Durrant <pdurrant@amazon.com>
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
---
xen/drivers/passthrough/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index ced0c28..c07a639 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl(
seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
ret = -EINVAL;
}
- break;
}
else if ( !ret )
ret = assign_device(d, seg, bus, devfn, flags);
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820
2019-12-05 12:13 [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820 Igor Druzhinin
@ 2019-12-05 12:20 ` Durrant, Paul
2019-12-05 12:26 ` Igor Druzhinin
2019-12-05 12:27 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Durrant, Paul @ 2019-12-05 12:20 UTC (permalink / raw)
To: Igor Druzhinin, xen-devel; +Cc: linux, jbeulich
> -----Original Message-----
> From: Igor Druzhinin <igor.druzhinin@citrix.com>
> Sent: 05 December 2019 12:14
> To: xen-devel@lists.xenproject.org
> Cc: jbeulich@suse.com; linux@eikelenboom.it; Durrant, Paul
> <pdurrant@amazon.com>; Igor Druzhinin <igor.druzhinin@citrix.com>
> Subject: [PATCH v2] passthrough: drop break statement following c/s
> cd7dedad820
>
> The locking responsibilities have changed and a premature break in
> this section now causes the following assertion:
>
> Assertion '!preempt_count()' failed at preempt.c:36
>
> Suggested-by: Paul Durrant <pdurrant@amazon.com>
Actually, it was suggested by Jan, but you can put my R-b on the patch.
Paul
> Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> ---
> xen/drivers/passthrough/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index ced0c28..c07a639 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl(
> seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
> ret = -EINVAL;
> }
> - break;
> }
> else if ( !ret )
> ret = assign_device(d, seg, bus, devfn, flags);
> --
> 2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820
2019-12-05 12:20 ` Durrant, Paul
@ 2019-12-05 12:26 ` Igor Druzhinin
2019-12-05 12:27 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Igor Druzhinin @ 2019-12-05 12:26 UTC (permalink / raw)
To: Durrant, Paul, xen-devel; +Cc: linux, jbeulich
On 05/12/2019 12:20, Durrant, Paul wrote:
>> -----Original Message-----
>> From: Igor Druzhinin <igor.druzhinin@citrix.com>
>> Sent: 05 December 2019 12:14
>> To: xen-devel@lists.xenproject.org
>> Cc: jbeulich@suse.com; linux@eikelenboom.it; Durrant, Paul
>> <pdurrant@amazon.com>; Igor Druzhinin <igor.druzhinin@citrix.com>
>> Subject: [PATCH v2] passthrough: drop break statement following c/s
>> cd7dedad820
>>
>> The locking responsibilities have changed and a premature break in
>> this section now causes the following assertion:
>>
>> Assertion '!preempt_count()' failed at preempt.c:36
>>
>> Suggested-by: Paul Durrant <pdurrant@amazon.com>
>
> Actually, it was suggested by Jan, but you can put my R-b on the patch.
>
Oh, indeed :) Please fix up while committing as you wish.
Igor
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820
2019-12-05 12:20 ` Durrant, Paul
2019-12-05 12:26 ` Igor Druzhinin
@ 2019-12-05 12:27 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2019-12-05 12:27 UTC (permalink / raw)
To: Igor Druzhinin; +Cc: xen-devel, Durrant, Paul, linux
On 05.12.2019 13:20, Durrant, Paul wrote:
>> -----Original Message-----
>> From: Igor Druzhinin <igor.druzhinin@citrix.com>
>> Sent: 05 December 2019 12:14
>> To: xen-devel@lists.xenproject.org
>> Cc: jbeulich@suse.com; linux@eikelenboom.it; Durrant, Paul
>> <pdurrant@amazon.com>; Igor Druzhinin <igor.druzhinin@citrix.com>
>> Subject: [PATCH v2] passthrough: drop break statement following c/s
>> cd7dedad820
>>
>> The locking responsibilities have changed and a premature break in
>> this section now causes the following assertion:
>>
>> Assertion '!preempt_count()' failed at preempt.c:36
>>
>> Suggested-by: Paul Durrant <pdurrant@amazon.com>
>
> Actually, it was suggested by Jan, but you can put my R-b on the patch.
And mine:
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I'll get this committed soon.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-05 12:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 12:13 [Xen-devel] [PATCH v2] passthrough: drop break statement following c/s cd7dedad820 Igor Druzhinin
2019-12-05 12:20 ` Durrant, Paul
2019-12-05 12:26 ` Igor Druzhinin
2019-12-05 12:27 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.