* [PATCH] docs/kselftest: Fix build commands in guidelines
@ 2022-07-04 8:34 Muhammad Usama Anjum
2022-07-08 16:51 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-07-04 8:34 UTC (permalink / raw)
To: Shuah Khan, Jonathan Corbet, Muhammad Usama Anjum
Cc: kernel, Shuah Khan, linux-kselftest, linux-doc, linux-kernel
Build commands start with "make". It is missing. Add "make" to the start
of the build command.
Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding new tests")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
Documentation/dev-tools/kselftest.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
index ee6467ca8293..9dd94c334f05 100644
--- a/Documentation/dev-tools/kselftest.rst
+++ b/Documentation/dev-tools/kselftest.rst
@@ -255,9 +255,9 @@ Contributing new tests (details)
* All changes should pass::
- kselftest-{all,install,clean,gen_tar}
- kselftest-{all,install,clean,gen_tar} O=abo_path
- kselftest-{all,install,clean,gen_tar} O=rel_path
+ make kselftest-{all,install,clean,gen_tar}
+ make kselftest-{all,install,clean,gen_tar} O=abs_path
+ make kselftest-{all,install,clean,gen_tar} O=rel_path
make -C tools/testing/selftests {all,install,clean,gen_tar}
make -C tools/testing/selftests {all,install,clean,gen_tar} O=abs_path
make -C tools/testing/selftests {all,install,clean,gen_tar} O=rel_path
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] docs/kselftest: Fix build commands in guidelines
2022-07-04 8:34 [PATCH] docs/kselftest: Fix build commands in guidelines Muhammad Usama Anjum
@ 2022-07-08 16:51 ` Shuah Khan
2022-07-26 4:59 ` Muhammad Usama Anjum
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2022-07-08 16:51 UTC (permalink / raw)
To: Muhammad Usama Anjum, Shuah Khan, Jonathan Corbet
Cc: kernel, linux-kselftest, linux-doc, linux-kernel, Shuah Khan
On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
> Build commands start with "make". It is missing. Add "make" to the start
> of the build command.
>
> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding new tests")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Documentation/dev-tools/kselftest.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index ee6467ca8293..9dd94c334f05 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -255,9 +255,9 @@ Contributing new tests (details)
>
> * All changes should pass::
>
> - kselftest-{all,install,clean,gen_tar}
> - kselftest-{all,install,clean,gen_tar} O=abo_path
> - kselftest-{all,install,clean,gen_tar} O=rel_path
> + make kselftest-{all,install,clean,gen_tar}
> + make kselftest-{all,install,clean,gen_tar} O=abs_path
> + make kselftest-{all,install,clean,gen_tar} O=rel_path
> make -C tools/testing/selftests {all,install,clean,gen_tar}
> make -C tools/testing/selftests {all,install,clean,gen_tar} O=abs_path
> make -C tools/testing/selftests {all,install,clean,gen_tar} O=rel_path
>
Looks like it depends on a patch already in doc tree?
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] docs/kselftest: Fix build commands in guidelines
2022-07-08 16:51 ` Shuah Khan
@ 2022-07-26 4:59 ` Muhammad Usama Anjum
2022-08-04 15:18 ` Muhammad Usama Anjum
0 siblings, 1 reply; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-07-26 4:59 UTC (permalink / raw)
To: Shuah Khan, Shuah Khan, Jonathan Corbet
Cc: usama.anjum, kernel, linux-kselftest, linux-doc, linux-kernel
On 7/8/22 9:51 PM, Shuah Khan wrote:
> On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
>> Build commands start with "make". It is missing. Add "make" to the start
>> of the build command.
>>
>> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding
>> new tests")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> Documentation/dev-tools/kselftest.rst | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/dev-tools/kselftest.rst
>> b/Documentation/dev-tools/kselftest.rst
>> index ee6467ca8293..9dd94c334f05 100644
>> --- a/Documentation/dev-tools/kselftest.rst
>> +++ b/Documentation/dev-tools/kselftest.rst
>> @@ -255,9 +255,9 @@ Contributing new tests (details)
>> * All changes should pass::
>> - kselftest-{all,install,clean,gen_tar}
>> - kselftest-{all,install,clean,gen_tar} O=abo_path
>> - kselftest-{all,install,clean,gen_tar} O=rel_path
>> + make kselftest-{all,install,clean,gen_tar}
>> + make kselftest-{all,install,clean,gen_tar} O=abs_path
>> + make kselftest-{all,install,clean,gen_tar} O=rel_path
>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>> O=abs_path
>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>> O=rel_path
>>
>
> Looks like it depends on a patch already in doc tree?
Yes, the dependent patch is in doc tree. Corbet should pick up this patch.
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
> thanks,
> -- Shuah
--
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] docs/kselftest: Fix build commands in guidelines
2022-07-26 4:59 ` Muhammad Usama Anjum
@ 2022-08-04 15:18 ` Muhammad Usama Anjum
0 siblings, 0 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-08-04 15:18 UTC (permalink / raw)
To: Jonathan Corbet
Cc: usama.anjum, kernel, linux-kselftest, linux-doc, linux-kernel,
Shuah Khan, Shuah Khan
On 7/26/22 9:59 AM, Muhammad Usama Anjum wrote:
> On 7/8/22 9:51 PM, Shuah Khan wrote:
>> On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
>>> Build commands start with "make". It is missing. Add "make" to the start
>>> of the build command.
>>>
>>> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding
>>> new tests")
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>> Documentation/dev-tools/kselftest.rst | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/dev-tools/kselftest.rst
>>> b/Documentation/dev-tools/kselftest.rst
>>> index ee6467ca8293..9dd94c334f05 100644
>>> --- a/Documentation/dev-tools/kselftest.rst
>>> +++ b/Documentation/dev-tools/kselftest.rst
>>> @@ -255,9 +255,9 @@ Contributing new tests (details)
>>> * All changes should pass::
>>> - kselftest-{all,install,clean,gen_tar}
>>> - kselftest-{all,install,clean,gen_tar} O=abo_path
>>> - kselftest-{all,install,clean,gen_tar} O=rel_path
>>> + make kselftest-{all,install,clean,gen_tar}
>>> + make kselftest-{all,install,clean,gen_tar} O=abs_path
>>> + make kselftest-{all,install,clean,gen_tar} O=rel_path
>>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=abs_path
>>> make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=rel_path
>>>
>>
>> Looks like it depends on a patch already in doc tree?
> Yes, the dependent patch is in doc tree. Corbet should pick up this patch.
Reminder!
>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>> thanks,
>> -- Shuah
>
--
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-04 15:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 8:34 [PATCH] docs/kselftest: Fix build commands in guidelines Muhammad Usama Anjum
2022-07-08 16:51 ` Shuah Khan
2022-07-26 4:59 ` Muhammad Usama Anjum
2022-08-04 15:18 ` Muhammad Usama Anjum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.