[PATCH 4/5] wic: fix 'founded' typo

[PATCH 4/5] wic: fix 'founded' typo

[Vivien Didelot]

Replace 'founded' with 'found'.

Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
---
 scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py b/scripts/lib/wic/plugins/source/bootimg-partition.py
index 138986a71e..5dbe2558d2 100644
--- a/scripts/lib/wic/plugins/source/bootimg-partition.py
+++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
@@ -141,7 +141,7 @@ class BootimgPartitionPlugin(SourcePlugin):
                     break
 
             if not kernel_name:
-                raise WicError('No kernel file founded')
+                raise WicError('No kernel file found')
 
             # Compose the extlinux.conf
             extlinux_conf = "default Yocto\n"
-- 
2.30.0

Re: [poky] [PATCH 4/5] wic: fix 'founded' typo

[Richard Purdie]

On Mon, 2021-01-04 at 12:37 -0500, Vivien Didelot wrote:
> Replace 'founded' with 'found'.
> 
> Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> ---
>  scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py
> b/scripts/lib/wic/plugins/source/bootimg-partition.py
> index 138986a71e..5dbe2558d2 100644
> --- a/scripts/lib/wic/plugins/source/bootimg-partition.py
> +++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
> @@ -141,7 +141,7 @@ class BootimgPartitionPlugin(SourcePlugin):
>                      break
>  
>              if not kernel_name:
> -                raise WicError('No kernel file founded')
> +                raise WicError('No kernel file found')
>  
>              # Compose the extlinux.conf
>              extlinux_conf = "default Yocto\n"
> 

Thanks, I've queued the other patches in this series. This one is
against the oe-core repository and needs to go to the openembedded-core
list. It was also fixed back in August so I'm guessing this was against
an older branch?:

http://git.yoctoproject.org/cgit.cgi/poky/commit/scripts/lib/wic/plugins/source/bootimg-partition.py?id=f39694933ace695e2dfe917c5ac74349a2e00409

Cheers,

Richard

Re: [poky] [PATCH 4/5] wic: fix 'founded' typo

[Vivien Didelot]

On Mon, 04 Jan 2021 18:02:07 +0000 Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> On Mon, 2021-01-04 at 12:37 -0500, Vivien Didelot wrote:
> > Replace 'founded' with 'found'.
> > 
> > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> > ---
> >  scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > index 138986a71e..5dbe2558d2 100644
> > --- a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > +++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > @@ -141,7 +141,7 @@ class BootimgPartitionPlugin(SourcePlugin):
> >                      break
> >  
> >              if not kernel_name:
> > -                raise WicError('No kernel file founded')
> > +                raise WicError('No kernel file found')
> >  
> >              # Compose the extlinux.conf
> >              extlinux_conf = "default Yocto\n"
> > 
> 
> Thanks, I've queued the other patches in this series. This one is
> against the oe-core repository and needs to go to the openembedded-core
> list. It was also fixed back in August so I'm guessing this was against
> an older branch?:
> 
> http://git.yoctoproject.org/cgit.cgi/poky/commit/scripts/lib/wic/plugins/source/bootimg-partition.py?id=f39694933ace695e2dfe917c5ac74349a2e00409

I'm not sure, these patches are based on latest dunfell:

d45ec07e5e87 ("sphinx: update link to bitbake docs")

where scripts/lib/wic/plugins/source/bootimg-partition.py contains
the typo.


Thanks,

	Vivien

Re: [poky] [PATCH 4/5] wic: fix 'founded' typo

[Richard Purdie]

On Mon, 2021-01-04 at 13:13 -0500, Vivien Didelot wrote:
> On Mon, 04 Jan 2021 18:02:07 +0000 Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2021-01-04 at 12:37 -0500, Vivien Didelot wrote:
> > > Replace 'founded' with 'found'.
> > > 
> > > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> > > ---
> > >  scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > index 138986a71e..5dbe2558d2 100644
> > > --- a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > +++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > @@ -141,7 +141,7 @@ class BootimgPartitionPlugin(SourcePlugin):
> > >                      break
> > >  
> > >              if not kernel_name:
> > > -                raise WicError('No kernel file founded')
> > > +                raise WicError('No kernel file found')
> > >  
> > >              # Compose the extlinux.conf
> > >              extlinux_conf = "default Yocto\n"
> > > 
> > 
> > Thanks, I've queued the other patches in this series. This one is
> > against the oe-core repository and needs to go to the openembedded-
> > core
> > list. It was also fixed back in August so I'm guessing this was
> > against
> > an older branch?:
> > 
> > http://git.yoctoproject.org/cgit.cgi/poky/commit/scripts/lib/wic/plugins/source/bootimg-partition.py?id=f39694933ace695e2dfe917c5ac74349a2e00409
> 
> I'm not sure, these patches are based on latest dunfell:
> 
> d45ec07e5e87 ("sphinx: update link to bitbake docs")
> 
> where scripts/lib/wic/plugins/source/bootimg-partition.py contains
> the typo.

You're right, its not in dunfell but I believe the stable maintainer
for dunfell now plans to backport it.

Cheers,

Richard

Re: [poky] [PATCH 4/5] wic: fix 'founded' typo

[Steve Sakoman]

On Mon, Jan 4, 2021 at 1:08 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2021-01-04 at 13:13 -0500, Vivien Didelot wrote:
> > On Mon, 04 Jan 2021 18:02:07 +0000 Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > On Mon, 2021-01-04 at 12:37 -0500, Vivien Didelot wrote:
> > > > Replace 'founded' with 'found'.
> > > >
> > > > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> > > > ---
> > > >  scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > > b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > > index 138986a71e..5dbe2558d2 100644
> > > > --- a/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > > +++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
> > > > @@ -141,7 +141,7 @@ class BootimgPartitionPlugin(SourcePlugin):
> > > >                      break
> > > >
> > > >              if not kernel_name:
> > > > -                raise WicError('No kernel file founded')
> > > > +                raise WicError('No kernel file found')
> > > >
> > > >              # Compose the extlinux.conf
> > > >              extlinux_conf = "default Yocto\n"
> > > >
> > >
> > > Thanks, I've queued the other patches in this series. This one is
> > > against the oe-core repository and needs to go to the openembedded-
> > > core
> > > list. It was also fixed back in August so I'm guessing this was
> > > against
> > > an older branch?:
> > >
> > > http://git.yoctoproject.org/cgit.cgi/poky/commit/scripts/lib/wic/plugins/source/bootimg-partition.py?id=f39694933ace695e2dfe917c5ac74349a2e00409
> >
> > I'm not sure, these patches are based on latest dunfell:
> >
> > d45ec07e5e87 ("sphinx: update link to bitbake docs")
> >
> > where scripts/lib/wic/plugins/source/bootimg-partition.py contains
> > the typo.
>
> You're right, its not in dunfell but I believe the stable maintainer
> for dunfell now plans to backport it.

Yes, it should be in next week's pull request.

Steve