[OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball

[OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball

[Ian Jackson]

xen.git/tools/firmware/etherboot/Makefile tries to get a tarball from
xen-extfiles first and if that fails, tries cloning from ipxe.org.

ipxe.org is sometimes down (or half-down) and when that happens
without a tarball the build breaks and is hard to fix.

We would like, therefore, to ensure that the tarball is always made
before the commit which refers to it is in xen.git#master.

osstest has no knowledge of ipxe as a separate thing and just lets
xen.git have whatever version is in Config.mk.  So osstest never needs
to specify particular ipxe version by hash, or the like.

So simply make osstest rely on the tarball existing, by having it
specify a completely invalid URL for the git clone.  This will detect
attempts to update IPXE_GIT_TAG without making a corresponding
tarball.

CC: Paul Durrant <paul.durrant@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 ts-xen-build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ts-xen-build b/ts-xen-build
index 48bf062f..6ddfc533 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -95,6 +95,7 @@ sub checkout () {
 	echo >>.config debug=$debug_build
 	echo >>.config GIT_HTTP=y
 	echo >>.config LIBLEAFDIR_x86_64=lib
+	echo >>.config IPXE_GIT_URL=file:////osstest/IPXE-GIT-FORBIDDEN
 	echo >>.config KERNELS=''
 END
                (${enable_livepatch} ? <<END : '').
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball

[Paul Durrant]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@eu.citrix.com]
> Sent: 05 November 2018 18:36
> To: xen-devel@lists.xenproject.org
> Cc: Ian Jackson <Ian.Jackson@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Wei Liu <wei.liu2@citrix.com>
> Subject: [OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball
> 
> xen.git/tools/firmware/etherboot/Makefile tries to get a tarball from
> xen-extfiles first and if that fails, tries cloning from ipxe.org.
> 
> ipxe.org is sometimes down (or half-down) and when that happens
> without a tarball the build breaks and is hard to fix.
> 
> We would like, therefore, to ensure that the tarball is always made
> before the commit which refers to it is in xen.git#master.
> 
> osstest has no knowledge of ipxe as a separate thing and just lets
> xen.git have whatever version is in Config.mk.  So osstest never needs
> to specify particular ipxe version by hash, or the like.
> 
> So simply make osstest rely on the tarball existing, by having it
> specify a completely invalid URL for the git clone.  This will detect
> attempts to update IPXE_GIT_TAG without making a corresponding
> tarball.
> 
> CC: Paul Durrant <paul.durrant@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  ts-xen-build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ts-xen-build b/ts-xen-build
> index 48bf062f..6ddfc533 100755
> --- a/ts-xen-build
> +++ b/ts-xen-build
> @@ -95,6 +95,7 @@ sub checkout () {
>  	echo >>.config debug=$debug_build
>  	echo >>.config GIT_HTTP=y
>  	echo >>.config LIBLEAFDIR_x86_64=lib
> +	echo >>.config IPXE_GIT_URL=file:////osstest/IPXE-GIT-FORBIDDEN

Do you really need four '/'? I thought three would be enough for a FQPN. Since it's supposed to be an invalid URL though it doesn't really matter...

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

>  	echo >>.config KERNELS=''
>  END
>                 (${enable_livepatch} ? <<END : '').
> --
> 2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball

[Wei Liu]

On Mon, Nov 05, 2018 at 06:35:54PM +0000, Ian Jackson wrote:
> xen.git/tools/firmware/etherboot/Makefile tries to get a tarball from
> xen-extfiles first and if that fails, tries cloning from ipxe.org.
> 
> ipxe.org is sometimes down (or half-down) and when that happens
> without a tarball the build breaks and is hard to fix.
> 
> We would like, therefore, to ensure that the tarball is always made
> before the commit which refers to it is in xen.git#master.
> 
> osstest has no knowledge of ipxe as a separate thing and just lets
> xen.git have whatever version is in Config.mk.  So osstest never needs
> to specify particular ipxe version by hash, or the like.
> 
> So simply make osstest rely on the tarball existing, by having it
> specify a completely invalid URL for the git clone.  This will detect
> attempts to update IPXE_GIT_TAG without making a corresponding
> tarball.
> 

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel