From: "Christ, Austin" <austinwc@codeaurora.org> To: Jeremy Linton <jeremy.linton@arm.com>, linux-acpi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, will.deacon@arm.com, catalin.marinas@arm.com, gregkh@linuxfoundation.org, viresh.kumar@linaro.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jhugo@codeaurora.org, wangxiongfeng2@huawei.com, Jonathan.Zhang@cavium.com, ahs3@redhat.com, Jayachandran.Nair@cavium.com Subject: Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing Date: Fri, 20 Oct 2017 13:53:45 -0600 [thread overview] Message-ID: <3e898236-0e7d-a8b0-e4c2-443012472296@codeaurora.org> (raw) In-Reply-To: <20171012194856.13844-2-jeremy.linton@arm.com> Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: > +static int topology_setup_acpi_cpu(struct acpi_table_header *table, > + unsigned int cpu, int level) > +{ > + struct acpi_pptt_processor *cpu_node; > + u32 acpi_cpu_id = acpi_cpu_get_madt_gicc(cpu)->uid; This lookup for the acpi id is architecture dependent. Can you use a function that would work for any user of PPTT and MADT? It may require writing and exporting the inverse lookup of the function acpi_get_cpuid() which is exported from processor_core.c > + > + cpu_node = acpi_find_processor_node(table, acpi_cpu_id); > + if (cpu_node) { > + cpu_node = acpi_find_processor_package_id(table, cpu_node, level); > + /* Only the first level has a guaranteed id */ > + if (level == 0) > + return cpu_node->acpi_processor_id; > + return (int)((u8 *)cpu_node - (u8 *)table); > + } > + pr_err_once("PPTT table found, but unable to locate core for %d\n", > + cpu); > + return -ENOENT; > +} -- Austin Christ Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: austinwc@codeaurora.org (Christ, Austin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing Date: Fri, 20 Oct 2017 13:53:45 -0600 [thread overview] Message-ID: <3e898236-0e7d-a8b0-e4c2-443012472296@codeaurora.org> (raw) In-Reply-To: <20171012194856.13844-2-jeremy.linton@arm.com> Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: > +static int topology_setup_acpi_cpu(struct acpi_table_header *table, > + unsigned int cpu, int level) > +{ > + struct acpi_pptt_processor *cpu_node; > + u32 acpi_cpu_id = acpi_cpu_get_madt_gicc(cpu)->uid; This lookup for the acpi id is architecture dependent. Can you use a function that would work for any user of PPTT and MADT? It may require writing and exporting the inverse lookup of the function acpi_get_cpuid() which is exported from processor_core.c > + > + cpu_node = acpi_find_processor_node(table, acpi_cpu_id); > + if (cpu_node) { > + cpu_node = acpi_find_processor_package_id(table, cpu_node, level); > + /* Only the first level has a guaranteed id */ > + if (level == 0) > + return cpu_node->acpi_processor_id; > + return (int)((u8 *)cpu_node - (u8 *)table); > + } > + pr_err_once("PPTT table found, but unable to locate core for %d\n", > + cpu); > + return -ENOENT; > +} -- Austin Christ Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-10-20 19:53 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-12 19:48 [PATCH v3 0/7] Support PPTT for ARM64 Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-12 19:48 ` [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-13 9:56 ` Julien Thierry 2017-10-13 9:56 ` Julien Thierry 2017-10-13 22:41 ` Jeremy Linton 2017-10-13 22:41 ` Jeremy Linton 2017-10-13 14:23 ` tn 2017-10-13 14:23 ` tn 2017-10-13 19:58 ` Jeremy Linton 2017-10-13 19:58 ` Jeremy Linton 2017-10-16 14:24 ` John Garry 2017-10-16 14:24 ` John Garry 2017-10-16 14:24 ` John Garry 2017-10-17 13:25 ` Tomasz Nowicki 2017-10-17 13:25 ` Tomasz Nowicki 2017-10-17 15:22 ` Jeremy Linton 2017-10-17 15:22 ` Jeremy Linton 2017-10-18 1:10 ` Xiongfeng Wang 2017-10-18 1:10 ` Xiongfeng Wang 2017-10-18 1:10 ` Xiongfeng Wang 2017-10-18 5:39 ` Tomasz Nowicki 2017-10-18 5:39 ` Tomasz Nowicki 2017-10-18 10:24 ` Tomasz Nowicki 2017-10-18 10:24 ` Tomasz Nowicki 2017-10-18 17:30 ` Jeremy Linton 2017-10-18 17:30 ` Jeremy Linton 2017-10-19 5:18 ` Tomasz Nowicki 2017-10-19 5:18 ` Tomasz Nowicki 2017-10-19 10:25 ` John Garry 2017-10-19 10:25 ` John Garry 2017-10-19 10:25 ` John Garry 2017-10-27 5:21 ` Tomasz Nowicki 2017-10-27 5:21 ` Tomasz Nowicki 2017-10-19 14:24 ` Jeremy Linton 2017-10-19 14:24 ` Jeremy Linton 2017-10-19 10:22 ` Lorenzo Pieralisi 2017-10-19 10:22 ` Lorenzo Pieralisi 2017-10-19 15:43 ` Jeremy Linton 2017-10-19 15:43 ` Jeremy Linton 2017-10-20 10:15 ` Lorenzo Pieralisi 2017-10-20 10:15 ` Lorenzo Pieralisi 2017-10-20 19:53 ` Christ, Austin [this message] 2017-10-20 19:53 ` Christ, Austin 2017-10-23 21:14 ` Jeremy Linton 2017-10-23 21:14 ` Jeremy Linton 2017-10-12 19:48 ` [PATCH v3 2/7] ACPI: Enable PPTT support on ARM64 Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-13 9:53 ` Hanjun Guo 2017-10-13 9:53 ` Hanjun Guo 2017-10-13 9:53 ` Hanjun Guo 2017-10-13 17:51 ` Jeremy Linton 2017-10-13 17:51 ` Jeremy Linton 2017-10-18 16:47 ` Lorenzo Pieralisi 2017-10-18 16:47 ` Lorenzo Pieralisi 2017-10-18 17:38 ` Jeremy Linton 2017-10-18 17:38 ` Jeremy Linton 2017-10-19 9:12 ` Lorenzo Pieralisi 2017-10-19 9:12 ` Lorenzo Pieralisi 2017-10-12 19:48 ` [PATCH v3 3/7] drivers: base: cacheinfo: arm64: Add support for ACPI based firmware tables Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-19 15:20 ` Lorenzo Pieralisi 2017-10-19 15:20 ` Lorenzo Pieralisi 2017-10-19 15:52 ` Jeremy Linton 2017-10-19 15:52 ` Jeremy Linton 2017-10-12 19:48 ` [PATCH v3 4/7] Topology: Add cluster on die macros and arm64 decoding Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-12 19:48 ` [PATCH v3 5/7] arm64: Fixup users of topology_physical_package_id Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-12 19:48 ` [PATCH v3 6/7] arm64: topology: Enable ACPI/PPTT based CPU topology Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-19 15:56 ` Lorenzo Pieralisi 2017-10-19 15:56 ` Lorenzo Pieralisi 2017-10-19 16:13 ` Jeremy Linton 2017-10-19 16:13 ` Jeremy Linton 2017-10-20 9:14 ` Lorenzo Pieralisi 2017-10-20 9:14 ` Lorenzo Pieralisi 2017-10-20 16:14 ` Jeremy Linton 2017-10-20 16:14 ` Jeremy Linton 2017-10-20 16:42 ` Sudeep Holla 2017-10-20 16:42 ` Sudeep Holla 2017-10-20 19:55 ` Jeffrey Hugo 2017-10-20 19:55 ` Jeffrey Hugo 2017-10-23 21:26 ` Jeremy Linton 2017-10-23 21:26 ` Jeremy Linton 2017-10-19 16:54 ` Jeremy Linton 2017-10-19 16:54 ` Jeremy Linton 2017-10-20 9:22 ` Lorenzo Pieralisi 2017-10-20 9:22 ` Lorenzo Pieralisi 2017-11-01 20:29 ` Al Stone 2017-11-01 20:29 ` Al Stone 2017-11-02 10:48 ` Lorenzo Pieralisi 2017-11-02 10:48 ` Lorenzo Pieralisi 2017-10-12 19:48 ` [PATCH v3 7/7] ACPI: Add PPTT to injectable table list Jeremy Linton 2017-10-12 19:48 ` Jeremy Linton 2017-10-13 11:08 ` [PATCH v3 0/7] Support PPTT for ARM64 John Garry 2017-10-13 11:08 ` John Garry 2017-10-13 11:08 ` John Garry 2017-10-13 19:34 ` Jeremy Linton 2017-10-13 19:34 ` Jeremy Linton 2017-10-31 12:46 ` Jon Masters 2017-10-31 12:46 ` Jon Masters
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3e898236-0e7d-a8b0-e4c2-443012472296@codeaurora.org \ --to=austinwc@codeaurora.org \ --cc=Jayachandran.Nair@cavium.com \ --cc=Jonathan.Zhang@cavium.com \ --cc=ahs3@redhat.com \ --cc=catalin.marinas@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=hanjun.guo@linaro.org \ --cc=jeremy.linton@arm.com \ --cc=jhugo@codeaurora.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=viresh.kumar@linaro.org \ --cc=wangxiongfeng2@huawei.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.