[meta-cgl][PATCH] meta-cgl-common: depend on meta-python2 layer

[meta-cgl][PATCH] meta-cgl-common: depend on meta-python2 layer

[Chen Qi]

It requires meta-python2 to be there at the moment.
More specifically, the crmsh recipe needs python-setuptools-native.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta-cgl-common/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-cgl-common/conf/layer.conf b/meta-cgl-common/conf/layer.conf
index 6035b4b..6b689ea 100644
--- a/meta-cgl-common/conf/layer.conf
+++ b/meta-cgl-common/conf/layer.conf
@@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "cgl-common"
 BBFILE_PATTERN_cgl-common = "^${LAYERDIR}/"
 BBFILE_PRIORITY_cgl-common = "7"
 
-LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux"
+LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux meta-python2"
 
 LAYERSERIES_COMPAT_cgl-common = "warrior zeus dunfell"
 
-- 
2.17.1

Re: [yocto] [meta-cgl][PATCH] meta-cgl-common: depend on meta-python2 layer

[Randy MacLeod]

[-- Attachment #1: Type: text/plain, Size: 2499 bytes --]

On 2020-09-23 4:01 a.m., Chen Qi wrote:
> It requires meta-python2 to be there at the moment.
> More specifically, the crmsh recipe needs python-setuptools-native.

Hi Qi,

Are you sure?
It looks like crmsh moved to python3 a while ago as
indicated below.

If there's still a dependency, please open an issue:

https://github.com/ClusterLabs/crmsh/issues?q=is%3Aissue+is%3Aopen+setuptools

Thanks,

../Randy


$ cd .../crmsh.git

$ git status
HEAD detached at 4.2.0
nothing to commit, working tree clean

$ grep -r setuptools *

contrib/setup.py:from setuptools import setup
crmsh.spec.in:BuildRequires:  python3-setuptools
doc/website-v1/development.adoc:* `setuptools`
Dockerfile:RUN zypper -n --gpg-auto-import-keys ref && zypper -n 
--gpg-auto-import-keys in pacemaker python3 python3-lxml 
python3-python-dateutil python3-parallax libglue-devel 
python3-setuptools python3-tox asciidoc autoconf automake make pkgconfig 
which libxslt-tools mailx procps python3-nose python3-PyYAML 
python3-curses tar
README.md:It then calls the python setuptools setup.py to actually 
process the
setup.py:from setuptools import setup


git log -1 --stat 845af7b9fb7a4c212d2e67b8a44cf655e702edaa
commit 845af7b9fb7a4c212d2e67b8a44cf655e702edaa
Author: Kristoffer Grönlund <krig@koru.se>
Date:   Fri Oct 27 05:47:02 2017

     dev: Updated spec file

  crmsh.spec | 106 
+++++++++++++++++...+++++++++-----------------------------------------
  1 file changed, 65 insertions(+), 41 deletions(-)

$ grep setuptools crmsh.spec.in
BuildRequires:  python3-setuptools


>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta-cgl-common/conf/layer.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-cgl-common/conf/layer.conf b/meta-cgl-common/conf/layer.conf
> index 6035b4b..6b689ea 100644
> --- a/meta-cgl-common/conf/layer.conf
> +++ b/meta-cgl-common/conf/layer.conf
> @@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "cgl-common"
>   BBFILE_PATTERN_cgl-common = "^${LAYERDIR}/"
>   BBFILE_PRIORITY_cgl-common = "7"
>   
> -LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux"
> +LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux meta-python2"
>   
>   LAYERSERIES_COMPAT_cgl-common = "warrior zeus dunfell"
>   
>
> 
>

-- 
# Randy MacLeod
# Wind River Linux


[-- Attachment #2: Type: text/html, Size: 3885 bytes --]

Re: [yocto] [meta-cgl][PATCH] meta-cgl-common: depend on meta-python2 layer

[Chen Qi]

[-- Attachment #1: Type: text/plain, Size: 2689 bytes --]

THANKS. I've sent out a new patch.

On 09/23/2020 11:58 PM, Randy MacLeod wrote:
> On 2020-09-23 4:01 a.m., Chen Qi wrote:
>> It requires meta-python2 to be there at the moment.
>> More specifically, the crmsh recipe needs python-setuptools-native.
>
> Hi Qi,
>
> Are you sure?
> It looks like crmsh moved to python3 a while ago as
> indicated below.
>
> If there's still a dependency, please open an issue:
>
> https://github.com/ClusterLabs/crmsh/issues?q=is%3Aissue+is%3Aopen+setuptools
>
> Thanks,
>
> ../Randy
>
>
> $ cd .../crmsh.git
>
> $ git status
> HEAD detached at 4.2.0
> nothing to commit, working tree clean
>
> $ grep -r setuptools *
>
> contrib/setup.py:from setuptools import setup
> crmsh.spec.in:BuildRequires:  python3-setuptools
> doc/website-v1/development.adoc:* `setuptools`
> Dockerfile:RUN zypper -n --gpg-auto-import-keys ref && zypper -n 
> --gpg-auto-import-keys in pacemaker python3 python3-lxml 
> python3-python-dateutil python3-parallax libglue-devel 
> python3-setuptools python3-tox asciidoc autoconf automake make 
> pkgconfig which libxslt-tools mailx procps python3-nose python3-PyYAML 
> python3-curses tar
> README.md:It then calls the python setuptools setup.py to actually 
> process the
> setup.py:from setuptools import setup
>
>
> git log -1 --stat 845af7b9fb7a4c212d2e67b8a44cf655e702edaa
> commit 845af7b9fb7a4c212d2e67b8a44cf655e702edaa
> Author: Kristoffer Grönlund <krig@koru.se>
> Date:   Fri Oct 27 05:47:02 2017
>
>     dev: Updated spec file
>
>  crmsh.spec | 106 
> +++++++++++++++++...+++++++++-----------------------------------------
>  1 file changed, 65 insertions(+), 41 deletions(-)
>
> $ grep setuptools crmsh.spec.in
> BuildRequires:  python3-setuptools
>
>
>> Signed-off-by: Chen Qi<Qi.Chen@windriver.com>
>> ---
>>   meta-cgl-common/conf/layer.conf | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-cgl-common/conf/layer.conf b/meta-cgl-common/conf/layer.conf
>> index 6035b4b..6b689ea 100644
>> --- a/meta-cgl-common/conf/layer.conf
>> +++ b/meta-cgl-common/conf/layer.conf
>> @@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "cgl-common"
>>   BBFILE_PATTERN_cgl-common = "^${LAYERDIR}/"
>>   BBFILE_PRIORITY_cgl-common = "7"
>>   
>> -LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux"
>> +LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux meta-python2"
>>   
>>   LAYERSERIES_COMPAT_cgl-common = "warrior zeus dunfell"
>>   
>>
>> 
>>
>
> -- 
> # Randy MacLeod
> # Wind River Linux



[-- Attachment #2: Type: text/html, Size: 4505 bytes --]

Re: [yocto] [meta-cgl][PATCH] meta-cgl-common: depend on meta-python2 layer

[Chen Qi]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Just like Randy points out, please ignore this patch.
I've sent out a new patch to remove 'python-setuptools-native' from 
crmsh's DEPENDS.

On 09/23/2020 04:01 PM, Chen Qi wrote:
> It requires meta-python2 to be there at the moment.
> More specifically, the crmsh recipe needs python-setuptools-native.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta-cgl-common/conf/layer.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-cgl-common/conf/layer.conf b/meta-cgl-common/conf/layer.conf
> index 6035b4b..6b689ea 100644
> --- a/meta-cgl-common/conf/layer.conf
> +++ b/meta-cgl-common/conf/layer.conf
> @@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "cgl-common"
>   BBFILE_PATTERN_cgl-common = "^${LAYERDIR}/"
>   BBFILE_PRIORITY_cgl-common = "7"
>   
> -LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux"
> +LAYERDEPENDS_cgl-common = "core openembedded-layer networking-layer perl-layer filesystems-layer security selinux meta-python2"
>   
>   LAYERSERIES_COMPAT_cgl-common = "warrior zeus dunfell"
>   
>
>
> 
>


[-- Attachment #2: Type: text/html, Size: 1746 bytes --]